Patchwork [CONSOLIDATED,PULL,03/22] site/common-uclibc: Cache gl_cv_func_wcwidth_works

login
mail settings
Submitter Saul Wold
Date Jan. 10, 2012, 5:53 a.m.
Message ID <a471d342424502de48f28c4f8297d490f2cd1443.1326174744.git.sgw@linux.intel.com>
Download mbox | patch
Permalink /patch/18835/
State New
Headers show

Comments

Saul Wold - Jan. 10, 2012, 5:53 a.m.
From: Khem Raj <raj.khem@gmail.com>

Its not computed properly during configure and
we configure uclibc with widechar support anyway
so its fine to cache it. It fixes the errors like

| In file included from ./stdio.h:31:0,
|                  from fpurge.h:20,
|                  from fpurge.c:20:
| /home/kraj/work/angstrom/sources/openembedded-core/build/tmp-uclibc/sysroots/qemux86/usr/include/stdio.h:662:40: error: expected declaration specifiers or '...' before '(' token
| make[4]: *** [fpurge.o] Error 1

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/site/common-uclibc |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Khem Raj - Jan. 10, 2012, 6:13 p.m.
please drop this patch. Its superseded by my pull request.

On Mon, Jan 9, 2012 at 9:53 PM, Saul Wold <sgw@linux.intel.com> wrote:
> From: Khem Raj <raj.khem@gmail.com>
>
> Its not computed properly during configure and
> we configure uclibc with widechar support anyway
> so its fine to cache it. It fixes the errors like
>
> | In file included from ./stdio.h:31:0,
> |                  from fpurge.h:20,
> |                  from fpurge.c:20:
> | /home/kraj/work/angstrom/sources/openembedded-core/build/tmp-uclibc/sysroots/qemux86/usr/include/stdio.h:662:40: error: expected declaration specifiers or '...' before '(' token
> | make[4]: *** [fpurge.o] Error 1
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/site/common-uclibc |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/meta/site/common-uclibc b/meta/site/common-uclibc
> index 331c2a2..c2ad42d 100644
> --- a/meta/site/common-uclibc
> +++ b/meta/site/common-uclibc
> @@ -21,6 +21,7 @@ ac_cv_func_vsnprintf_c99=${ac_cv_func_vsnprintf_c99=yes}
>  glib_cv_compliant_posix_memalign=${glib_cv_compliant_posix_memalign=1}
>  glib_cv_long_long_format=${glib_cv_long_long_format=ll}
>  glib_cv_have_qsort_r=${glib_cv_have_qsort_r=no}
> +gl_cv_func_wcwidth_works=${gl_cv_func_wcwidth_works=yes}
>
>  #dbus-glib
>  ac_cv_have_abstract_sockets=${ac_cv_have_abstract_sockets=yes}
> --
> 1.7.6.5
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Saul Wold - Jan. 10, 2012, 6:18 p.m.
On 01/10/2012 10:13 AM, Khem Raj wrote:
> please drop this patch. Its superseded by my pull request.
>
Looks like this got pulled, will there be a problem?

Sau!

> On Mon, Jan 9, 2012 at 9:53 PM, Saul Wold<sgw@linux.intel.com>  wrote:
>> From: Khem Raj<raj.khem@gmail.com>
>>
>> Its not computed properly during configure and
>> we configure uclibc with widechar support anyway
>> so its fine to cache it. It fixes the errors like
>>
>> | In file included from ./stdio.h:31:0,
>> |                  from fpurge.h:20,
>> |                  from fpurge.c:20:
>> | /home/kraj/work/angstrom/sources/openembedded-core/build/tmp-uclibc/sysroots/qemux86/usr/include/stdio.h:662:40: error: expected declaration specifiers or '...' before '(' token
>> | make[4]: *** [fpurge.o] Error 1
>>
>> Signed-off-by: Khem Raj<raj.khem@gmail.com>
>> ---
>>   meta/site/common-uclibc |    1 +
>>   1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/meta/site/common-uclibc b/meta/site/common-uclibc
>> index 331c2a2..c2ad42d 100644
>> --- a/meta/site/common-uclibc
>> +++ b/meta/site/common-uclibc
>> @@ -21,6 +21,7 @@ ac_cv_func_vsnprintf_c99=${ac_cv_func_vsnprintf_c99=yes}
>>   glib_cv_compliant_posix_memalign=${glib_cv_compliant_posix_memalign=1}
>>   glib_cv_long_long_format=${glib_cv_long_long_format=ll}
>>   glib_cv_have_qsort_r=${glib_cv_have_qsort_r=no}
>> +gl_cv_func_wcwidth_works=${gl_cv_func_wcwidth_works=yes}
>>
>>   #dbus-glib
>>   ac_cv_have_abstract_sockets=${ac_cv_have_abstract_sockets=yes}
>> --
>> 1.7.6.5
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Khem Raj - Jan. 10, 2012, 6:24 p.m.
On Tue, Jan 10, 2012 at 10:18 AM, Saul Wold <sgw@linux.intel.com> wrote:
> On 01/10/2012 10:13 AM, Khem Raj wrote:
>>
>> please drop this patch. Its superseded by my pull request.
>>
> Looks like this got pulled, will there be a problem?

I think there could be a problem when wchar feature is unset. Although
since it sets.
gl_cv_func_wcwidth_works=${gl_cv_func_wcwidth_works=yes}

It might honor the setting coming from recipe through CONFIGUREVARS
but not sure.
its probably best to revert it.

>
> Sau!
>
>
>> On Mon, Jan 9, 2012 at 9:53 PM, Saul Wold<sgw@linux.intel.com>  wrote:
>>>
>>> From: Khem Raj<raj.khem@gmail.com>
>>>
>>> Its not computed properly during configure and
>>> we configure uclibc with widechar support anyway
>>> so its fine to cache it. It fixes the errors like
>>>
>>> | In file included from ./stdio.h:31:0,
>>> |                  from fpurge.h:20,
>>> |                  from fpurge.c:20:
>>> |
>>> /home/kraj/work/angstrom/sources/openembedded-core/build/tmp-uclibc/sysroots/qemux86/usr/include/stdio.h:662:40:
>>> error: expected declaration specifiers or '...' before '(' token
>>> | make[4]: *** [fpurge.o] Error 1
>>>
>>> Signed-off-by: Khem Raj<raj.khem@gmail.com>
>>> ---
>>>  meta/site/common-uclibc |    1 +
>>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/meta/site/common-uclibc b/meta/site/common-uclibc
>>> index 331c2a2..c2ad42d 100644
>>> --- a/meta/site/common-uclibc
>>> +++ b/meta/site/common-uclibc
>>> @@ -21,6 +21,7 @@
>>> ac_cv_func_vsnprintf_c99=${ac_cv_func_vsnprintf_c99=yes}
>>>  glib_cv_compliant_posix_memalign=${glib_cv_compliant_posix_memalign=1}
>>>  glib_cv_long_long_format=${glib_cv_long_long_format=ll}
>>>  glib_cv_have_qsort_r=${glib_cv_have_qsort_r=no}
>>> +gl_cv_func_wcwidth_works=${gl_cv_func_wcwidth_works=yes}
>>>
>>>  #dbus-glib
>>>  ac_cv_have_abstract_sockets=${ac_cv_have_abstract_sockets=yes}
>>> --
>>> 1.7.6.5
>>>
>>>
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/site/common-uclibc b/meta/site/common-uclibc
index 331c2a2..c2ad42d 100644
--- a/meta/site/common-uclibc
+++ b/meta/site/common-uclibc
@@ -21,6 +21,7 @@  ac_cv_func_vsnprintf_c99=${ac_cv_func_vsnprintf_c99=yes}
 glib_cv_compliant_posix_memalign=${glib_cv_compliant_posix_memalign=1}
 glib_cv_long_long_format=${glib_cv_long_long_format=ll}
 glib_cv_have_qsort_r=${glib_cv_have_qsort_r=no}
+gl_cv_func_wcwidth_works=${gl_cv_func_wcwidth_works=yes}
 
 #dbus-glib
 ac_cv_have_abstract_sockets=${ac_cv_have_abstract_sockets=yes}