Patchwork [2/2] systemd: split out systemd-analyze

login
register
mail settings
Submitter Anders Darander
Date Jan. 9, 2012, 1:18 p.m.
Message ID <5fec4c565130ce5590d5073421f211898d12dc24.1326114932.git.anders@chargestorm.se>
Download mbox | patch
Permalink /patch/18793/
State Superseded
Headers show

Comments

Anders Darander - Jan. 9, 2012, 1:18 p.m.
Split systemd-analyze to a separate package, to remove the implicit
dependency on python. (At least the rpm-packaging backend created a
run-time dependency on python).

Signed-off-by: Anders Darander <anders@chargestorm.se>
---
 meta-oe/recipes-core/systemd/systemd_git.bb |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
Martin Jansa - Jan. 9, 2012, 1:28 p.m.
On Mon, Jan 09, 2012 at 02:18:38PM +0100, Anders Darander wrote:
> Split systemd-analyze to a separate package, to remove the implicit
> dependency on python. (At least the rpm-packaging backend created a
> run-time dependency on python).
> 
> Signed-off-by: Anders Darander <anders@chargestorm.se>
> ---
>  meta-oe/recipes-core/systemd/systemd_git.bb |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-oe/recipes-core/systemd/systemd_git.bb b/meta-oe/recipes-core/systemd/systemd_git.bb
> index bdaaf16..1d71bb6 100644
> --- a/meta-oe/recipes-core/systemd/systemd_git.bb
> +++ b/meta-oe/recipes-core/systemd/systemd_git.bb
> @@ -14,7 +14,7 @@ inherit gitpkgv
>  PKGV = "v${GITPKGVTAG}"
>  
>  PV = "git"
> -PR = "r7"
> +PR = "r8"
>  
>  inherit useradd pkgconfig autotools vala perlnative
>  
> @@ -57,11 +57,13 @@ do_install() {
>  	ln -s ${base_bindir}/systemd ${D}/init
>  }
>  
> -PACKAGES =+ "${PN}-gui ${PN}-vconsole-setup ${PN}-initramfs"
> +PACKAGES =+ "${PN}-gui ${PN}-vconsole-setup ${PN}-initramfs ${PN}-analyze"
>  
>  USERADD_PACKAGES = "${PN}"
>  GROUPADD_PARAM_${PN} = "-r lock"
>  
> +FILES_${PN}-analyze = "${bindir}/systemd-analyze"

according to your commit message, why not add
RDEPENDS_${PN}-analyze = "python"
here?

and maybe
RSUGGESTS_${PN} += "${PN}-analyze"

> +
>  FILES_${PN}-initramfs = "/init"
>  RDEPENDS_${PN}-initramfs = "${PN}"
>  
> -- 
> 1.7.8.2
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Anders Darander - Jan. 9, 2012, 1:37 p.m.
* Martin Jansa <martin.jansa@gmail.com> [120109 14:28]:

> On Mon, Jan 09, 2012 at 02:18:38PM +0100, Anders Darander wrote:
> > Split systemd-analyze to a separate package, to remove the implicit
> > dependency on python. (At least the rpm-packaging backend created a
> > run-time dependency on python).

> > +PACKAGES =+ "${PN}-gui ${PN}-vconsole-setup ${PN}-initramfs ${PN}-analyze"

> >  USERADD_PACKAGES = "${PN}"
> >  GROUPADD_PARAM_${PN} = "-r lock"

> > +FILES_${PN}-analyze = "${bindir}/systemd-analyze"

> according to your commit message, why not add
> RDEPENDS_${PN}-analyze = "python"
> here?

Yes, I should probably spin a v2 with:
RDEPENDS_${PN}-analyze = "python-dbus"
as python alone isn't enough to run systemd-analyze.

Missing that as on our larger image, python was always explicitly
installed by other packages, and on this smaller one, we didn't want it.
Good catch, though!

> and maybe
> RSUGGESTS_${PN} += "${PN}-analyze"

Not sure about this one. It should probably be safe to add, although I'm
undecided...

Cheers,
Anders

> > +
> >  FILES_${PN}-initramfs = "/init"
> >  RDEPENDS_${PN}-initramfs = "${PN}"
Anders Darander - Jan. 9, 2012, 1:44 p.m.
* Anders Darander <anders@chargestorm.se> [120109 14:37]:
> * Martin Jansa <martin.jansa@gmail.com> [120109 14:28]:

> > On Mon, Jan 09, 2012 at 02:18:38PM +0100, Anders Darander wrote:
> > > Split systemd-analyze to a separate package, to remove the implicit
> > > dependency on python. (At least the rpm-packaging backend created a
> > > run-time dependency on python).

> > > +PACKAGES =+ "${PN}-gui ${PN}-vconsole-setup ${PN}-initramfs ${PN}-analyze"

> > >  USERADD_PACKAGES = "${PN}"
> > >  GROUPADD_PARAM_${PN} = "-r lock"

> > > +FILES_${PN}-analyze = "${bindir}/systemd-analyze"

> > according to your commit message, why not add
> > RDEPENDS_${PN}-analyze = "python"
> > here?

> Yes, I should probably spin a v2 with:
> RDEPENDS_${PN}-analyze = "python-dbus"
> as python alone isn't enough to run systemd-analyze.

Just pushed the above fix to the same systemd-move branch on github.

Cheers,
Anders

> Missing that as on our larger image, python was always explicitly
> installed by other packages, and on this smaller one, we didn't want it.
> Good catch, though!
Otavio Salvador - Jan. 9, 2012, 2:34 p.m.
On Mon, Jan 9, 2012 at 11:44, Anders Darander <anders@chargestorm.se> wrote:

> Just pushed the above fix to the same systemd-move branch on github.
>

Please send an updated patchset so people can review it.
Koen Kooi - Jan. 10, 2012, 7:27 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 09-01-12 14:37, Anders Darander schreef:
> * Martin Jansa <martin.jansa@gmail.com> [120109 14:28]:
> 
>> On Mon, Jan 09, 2012 at 02:18:38PM +0100, Anders Darander wrote:
>>> Split systemd-analyze to a separate package, to remove the implicit 
>>> dependency on python. (At least the rpm-packaging backend created a 
>>> run-time dependency on python).
> 
>>> +PACKAGES =+ "${PN}-gui ${PN}-vconsole-setup ${PN}-initramfs
>>> ${PN}-analyze"
> 
>>> USERADD_PACKAGES = "${PN}" GROUPADD_PARAM_${PN} = "-r lock"
> 
>>> +FILES_${PN}-analyze = "${bindir}/systemd-analyze"
> 
>> according to your commit message, why not add RDEPENDS_${PN}-analyze =
>> "python" here?
> 
> Yes, I should probably spin a v2 with: RDEPENDS_${PN}-analyze =
> "python-dbus" as python alone isn't enough to run systemd-analyze.

Don't forget python-pycairo for 'systemd-analyze plot'

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (Darwin)
Comment: GPGTools - http://gpgtools.org

iEYEARECAAYFAk8L6EMACgkQMkyGM64RGpFsMwCfYYRYu/3dMHcSatOubVTWgz8U
i8kAoI8iJsmGCdwTYWz492C5LJMn3uPH
=BrPL
-----END PGP SIGNATURE-----
Anders Darander - Jan. 10, 2012, 7:53 a.m.
* Koen Kooi <koen@dominion.thruhere.net> [120110 08:27]:

> Op 09-01-12 14:37, Anders Darander schreef:
> > * Martin Jansa <martin.jansa@gmail.com> [120109 14:28]:

> >> On Mon, Jan 09, 2012 at 02:18:38PM +0100, Anders Darander wrote:
> >>> Split systemd-analyze to a separate package, to remove the implicit 
> >>> dependency on python. (At least the rpm-packaging backend created a 
> >>> run-time dependency on python).

> >>> +PACKAGES =+ "${PN}-gui ${PN}-vconsole-setup ${PN}-initramfs
> >>> ${PN}-analyze"

> >>> USERADD_PACKAGES = "${PN}" GROUPADD_PARAM_${PN} = "-r lock"

> >>> +FILES_${PN}-analyze = "${bindir}/systemd-analyze"

> >> according to your commit message, why not add RDEPENDS_${PN}-analyze =
> >> "python" here?

> > Yes, I should probably spin a v2 with: RDEPENDS_${PN}-analyze =
> > "python-dbus" as python alone isn't enough to run systemd-analyze.

> Don't forget python-pycairo for 'systemd-analyze plot'

Thanks, I'll add it as a RRECOMMENDS and send an updated patch series.
(I've only used systemd an headless systems, without any graphics
libraries at all, thus never been running systemd-analyze plot)

I'll use RRECOMMENDS as it is not necessary for running systemd-analyze,
which python-dbus is. Well, it is necessary for running 'systemd-analyze
plot', but not for the other commands in systemd-analyze.

Cheers,
Anders

Patch

diff --git a/meta-oe/recipes-core/systemd/systemd_git.bb b/meta-oe/recipes-core/systemd/systemd_git.bb
index bdaaf16..1d71bb6 100644
--- a/meta-oe/recipes-core/systemd/systemd_git.bb
+++ b/meta-oe/recipes-core/systemd/systemd_git.bb
@@ -14,7 +14,7 @@  inherit gitpkgv
 PKGV = "v${GITPKGVTAG}"
 
 PV = "git"
-PR = "r7"
+PR = "r8"
 
 inherit useradd pkgconfig autotools vala perlnative
 
@@ -57,11 +57,13 @@  do_install() {
 	ln -s ${base_bindir}/systemd ${D}/init
 }
 
-PACKAGES =+ "${PN}-gui ${PN}-vconsole-setup ${PN}-initramfs"
+PACKAGES =+ "${PN}-gui ${PN}-vconsole-setup ${PN}-initramfs ${PN}-analyze"
 
 USERADD_PACKAGES = "${PN}"
 GROUPADD_PARAM_${PN} = "-r lock"
 
+FILES_${PN}-analyze = "${bindir}/systemd-analyze"
+
 FILES_${PN}-initramfs = "/init"
 RDEPENDS_${PN}-initramfs = "${PN}"