Patchwork busybox: defconfig modified in order to activate CONFIG_EXPR_MATH_SUPPORT_64

login
register
mail settings
Submitter Andrei Gherzan
Date Jan. 9, 2012, 12:03 a.m.
Message ID <1326067422-30771-1-git-send-email-andrei@gherzan.ro>
Download mbox | patch
Permalink /patch/18783/
State Accepted
Commit 5ab12509051b732944a5027750505fa860133f1b
Headers show

Comments

Andrei Gherzan - Jan. 9, 2012, 12:03 a.m.
From: Andrei Gherzan <andrei.gherzan@windriver.com>

Enable 64-bit math support in the expr applet. This will make
the applet slightly larger, but will allow computation with very
large numbers.

[YOCTO #1767]

Signed-off-by: Andrei Gherzan <andrei@gherzan.ro>
---
 meta/recipes-core/busybox/busybox-1.19.3/defconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
McClintock Matthew-B29882 - Jan. 9, 2012, 5:08 a.m.
Is anyone working on more fine grained control of busybox? Some ideas include:

1) configure via PACKAGECONFIG?

2) supply a defconfig for busybox?

3) multiple busybox recipes?

-M

On Sun, Jan 8, 2012 at 6:03 PM, Andrei Gherzan <andrei@gherzan.ro> wrote:
> From: Andrei Gherzan <andrei.gherzan@windriver.com>
>
> Enable 64-bit math support in the expr applet. This will make
> the applet slightly larger, but will allow computation with very
> large numbers.
>
> [YOCTO #1767]
>
> Signed-off-by: Andrei Gherzan <andrei@gherzan.ro>
> ---
>  meta/recipes-core/busybox/busybox-1.19.3/defconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-core/busybox/busybox-1.19.3/defconfig b/meta/recipes-core/busybox/busybox-1.19.3/defconfig
> index 1990f28..ebd751d 100644
> --- a/meta/recipes-core/busybox/busybox-1.19.3/defconfig
> +++ b/meta/recipes-core/busybox/busybox-1.19.3/defconfig
> @@ -214,7 +214,7 @@ CONFIG_FEATURE_ENV_LONG_OPTIONS=y
>  # CONFIG_EXPAND is not set
>  # CONFIG_FEATURE_EXPAND_LONG_OPTIONS is not set
>  CONFIG_EXPR=y
> -# CONFIG_EXPR_MATH_SUPPORT_64 is not set
> +CONFIG_EXPR_MATH_SUPPORT_64=y
>  CONFIG_FALSE=y
>  # CONFIG_FOLD is not set
>  # CONFIG_FSYNC is not set
> --
> 1.7.5.4
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
NiQingliang - Jan. 9, 2012, 6:06 a.m.
indeed, I think maybe providing specific config file for specific
machine is better, but not spliting the config to fragments.

On Mon, 2012-01-09 at 13:08 +0800, McClintock Matthew-B29882 wrote:
> Is anyone working on more fine grained control of busybox? Some ideas include:
> 
> 1) configure via PACKAGECONFIG?
> 
> 2) supply a defconfig for busybox?
> 
> 3) multiple busybox recipes?
> 
> -M
> 
> On Sun, Jan 8, 2012 at 6:03 PM, Andrei Gherzan <andrei@gherzan.ro> wrote:
> > From: Andrei Gherzan <andrei.gherzan@windriver.com>
> >
> > Enable 64-bit math support in the expr applet. This will make
> > the applet slightly larger, but will allow computation with very
> > large numbers.
> >
> > [YOCTO #1767]
> >
> > Signed-off-by: Andrei Gherzan <andrei@gherzan.ro>
> > ---
> >  meta/recipes-core/busybox/busybox-1.19.3/defconfig |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/meta/recipes-core/busybox/busybox-1.19.3/defconfig b/meta/recipes-core/busybox/busybox-1.19.3/defconfig
> > index 1990f28..ebd751d 100644
> > --- a/meta/recipes-core/busybox/busybox-1.19.3/defconfig
> > +++ b/meta/recipes-core/busybox/busybox-1.19.3/defconfig
> > @@ -214,7 +214,7 @@ CONFIG_FEATURE_ENV_LONG_OPTIONS=y
> >  # CONFIG_EXPAND is not set
> >  # CONFIG_FEATURE_EXPAND_LONG_OPTIONS is not set
> >  CONFIG_EXPR=y
> > -# CONFIG_EXPR_MATH_SUPPORT_64 is not set
> > +CONFIG_EXPR_MATH_SUPPORT_64=y
> >  CONFIG_FALSE=y
> >  # CONFIG_FOLD is not set
> >  # CONFIG_FSYNC is not set
> > --
> > 1.7.5.4
> >
> >
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Phil Blundell - Jan. 9, 2012, 8:09 a.m.
You could take a look at the busybox-config.inc stuff in oe-classic as a
starting point.  It doesn't do PACKAGECONFIG (since oe-classic doesn't
have that) but it can do the equivalent with DISTRO_FEATURES.

p.

On Mon, 2012-01-09 at 05:08 +0000, McClintock Matthew-B29882 wrote:
> Is anyone working on more fine grained control of busybox? Some ideas include:
> 
> 1) configure via PACKAGECONFIG?
> 
> 2) supply a defconfig for busybox?
> 
> 3) multiple busybox recipes?
> 
> -M
> 
> On Sun, Jan 8, 2012 at 6:03 PM, Andrei Gherzan <andrei@gherzan.ro> wrote:
> > From: Andrei Gherzan <andrei.gherzan@windriver.com>
> >
> > Enable 64-bit math support in the expr applet. This will make
> > the applet slightly larger, but will allow computation with very
> > large numbers.
> >
> > [YOCTO #1767]
> >
> > Signed-off-by: Andrei Gherzan <andrei@gherzan.ro>
> > ---
> >  meta/recipes-core/busybox/busybox-1.19.3/defconfig |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/meta/recipes-core/busybox/busybox-1.19.3/defconfig b/meta/recipes-core/busybox/busybox-1.19.3/defconfig
> > index 1990f28..ebd751d 100644
> > --- a/meta/recipes-core/busybox/busybox-1.19.3/defconfig
> > +++ b/meta/recipes-core/busybox/busybox-1.19.3/defconfig
> > @@ -214,7 +214,7 @@ CONFIG_FEATURE_ENV_LONG_OPTIONS=y
> >  # CONFIG_EXPAND is not set
> >  # CONFIG_FEATURE_EXPAND_LONG_OPTIONS is not set
> >  CONFIG_EXPR=y
> > -# CONFIG_EXPR_MATH_SUPPORT_64 is not set
> > +CONFIG_EXPR_MATH_SUPPORT_64=y
> >  CONFIG_FALSE=y
> >  # CONFIG_FOLD is not set
> >  # CONFIG_FSYNC is not set
> > --
> > 1.7.5.4
> >
> >
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Mark Hatle - Jan. 9, 2012, 4:26 p.m.
On 1/9/12 2:09 AM, Phil Blundell wrote:
> You could take a look at the busybox-config.inc stuff in oe-classic as a
> starting point.  It doesn't do PACKAGECONFIG (since oe-classic doesn't
> have that) but it can do the equivalent with DISTRO_FEATURES.

At Wind River we've discussed using the kernel configuration fragment patching 
process as a way to control busybox.  This would allow the recipe to provide a 
default fragment (configuration), with machines, architectures, and other 
configurations providing additional fragments -- that together would produce the 
busybox that the end use wants.

I think this is a better long term approach then hacking the defconfig file each 
time it's not quite right for a system.  (We may still need to modify it over 
time, but the modifications need to be considered "generic" based on the use of 
busybox in say core-image-minimal...)

--Mark

> p.
>
> On Mon, 2012-01-09 at 05:08 +0000, McClintock Matthew-B29882 wrote:
>> Is anyone working on more fine grained control of busybox? Some ideas include:
>>
>> 1) configure via PACKAGECONFIG?
>>
>> 2) supply a defconfig for busybox?
>>
>> 3) multiple busybox recipes?
>>
>> -M
>>
>> On Sun, Jan 8, 2012 at 6:03 PM, Andrei Gherzan<andrei@gherzan.ro>  wrote:
>>> From: Andrei Gherzan<andrei.gherzan@windriver.com>
>>>
>>> Enable 64-bit math support in the expr applet. This will make
>>> the applet slightly larger, but will allow computation with very
>>> large numbers.
>>>
>>> [YOCTO #1767]
>>>
>>> Signed-off-by: Andrei Gherzan<andrei@gherzan.ro>
>>> ---
>>>   meta/recipes-core/busybox/busybox-1.19.3/defconfig |    2 +-
>>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/meta/recipes-core/busybox/busybox-1.19.3/defconfig b/meta/recipes-core/busybox/busybox-1.19.3/defconfig
>>> index 1990f28..ebd751d 100644
>>> --- a/meta/recipes-core/busybox/busybox-1.19.3/defconfig
>>> +++ b/meta/recipes-core/busybox/busybox-1.19.3/defconfig
>>> @@ -214,7 +214,7 @@ CONFIG_FEATURE_ENV_LONG_OPTIONS=y
>>>   # CONFIG_EXPAND is not set
>>>   # CONFIG_FEATURE_EXPAND_LONG_OPTIONS is not set
>>>   CONFIG_EXPR=y
>>> -# CONFIG_EXPR_MATH_SUPPORT_64 is not set
>>> +CONFIG_EXPR_MATH_SUPPORT_64=y
>>>   CONFIG_FALSE=y
>>>   # CONFIG_FOLD is not set
>>>   # CONFIG_FSYNC is not set
>>> --
>>> 1.7.5.4
>>>
>>>
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Otavio Salvador - Jan. 9, 2012, 4:52 p.m.
On Mon, Jan 9, 2012 at 14:26, Mark Hatle <mark.hatle@windriver.com> wrote:

> On 1/9/12 2:09 AM, Phil Blundell wrote:
>
>> You could take a look at the busybox-config.inc stuff in oe-classic as a
>> starting point.  It doesn't do PACKAGECONFIG (since oe-classic doesn't
>> have that) but it can do the equivalent with DISTRO_FEATURES.
>>
>
> At Wind River we've discussed using the kernel configuration fragment
> patching process as a way to control busybox.  This would allow the recipe
> to provide a default fragment (configuration), with machines,
> architectures, and other configurations providing additional fragments --
> that together would produce the busybox that the end use wants.
>
> I think this is a better long term approach then hacking the defconfig
> file each time it's not quite right for a system.  (We may still need to
> modify it over time, but the modifications need to be considered "generic"
> based on the use of busybox in say core-image-minimal...)


I agree with the concept of the idea and long term solution however I also
think it needs to be well documented otherwise it is going to be a problem,
instead of a solution.

When I tried to use the kernel configuration fragment from Yocto I couldn't
figure it out by myself and it seems very undocumented thus its learn curve
is not as good as I'd hope for...
Saul Wold - Jan. 12, 2012, 8:23 p.m.
On 01/08/2012 04:03 PM, Andrei Gherzan wrote:
> From: Andrei Gherzan<andrei.gherzan@windriver.com>
>
> Enable 64-bit math support in the expr applet. This will make
> the applet slightly larger, but will allow computation with very
> large numbers.
>

Just to confirm, I have seen discussion about finer-grain control over 
bitbake configuration, but are there any direct objections to this 
change going in?

Sau!

> [YOCTO #1767]
>
> Signed-off-by: Andrei Gherzan<andrei@gherzan.ro>
> ---
>   meta/recipes-core/busybox/busybox-1.19.3/defconfig |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-core/busybox/busybox-1.19.3/defconfig b/meta/recipes-core/busybox/busybox-1.19.3/defconfig
> index 1990f28..ebd751d 100644
> --- a/meta/recipes-core/busybox/busybox-1.19.3/defconfig
> +++ b/meta/recipes-core/busybox/busybox-1.19.3/defconfig
> @@ -214,7 +214,7 @@ CONFIG_FEATURE_ENV_LONG_OPTIONS=y
>   # CONFIG_EXPAND is not set
>   # CONFIG_FEATURE_EXPAND_LONG_OPTIONS is not set
>   CONFIG_EXPR=y
> -# CONFIG_EXPR_MATH_SUPPORT_64 is not set
> +CONFIG_EXPR_MATH_SUPPORT_64=y
>   CONFIG_FALSE=y
>   # CONFIG_FOLD is not set
>   # CONFIG_FSYNC is not set
Lauri Hintsala - Jan. 13, 2012, 7:07 a.m.
Hello Andrei

On 01/09/2012 02:03 AM, Andrei Gherzan wrote:
> From: Andrei Gherzan<andrei.gherzan@windriver.com>
>
> Enable 64-bit math support in the expr applet. This will make
> the applet slightly larger, but will allow computation with very
> large numbers.
>
> [YOCTO #1767]

This bug should be fixed already:
http://lists.linuxtogo.org/pipermail/openembedded-core/2011-December/014487.html

Please inform if my fix doesn't work.

BR,
Lauri
Andrei Gherzan - Jan. 13, 2012, 8:16 a.m.
As i could see that patch has nothing in common with this bug. Yes, it uses
expr from busybox... but that is all. No fix for 64bit numbers support.

@g
On Jan 13, 2012 9:07 AM, "Lauri Hintsala" <lauri.hintsala@bluegiga.com>
wrote:

> Hello Andrei
>
> On 01/09/2012 02:03 AM, Andrei Gherzan wrote:
>
>> From: Andrei Gherzan<andrei.gherzan@**windriver.com<andrei.gherzan@windriver.com>
>> >
>>
>> Enable 64-bit math support in the expr applet. This will make
>> the applet slightly larger, but will allow computation with very
>> large numbers.
>>
>> [YOCTO #1767]
>>
>
> This bug should be fixed already:
> http://lists.linuxtogo.org/**pipermail/openembedded-core/**
> 2011-December/014487.html<http://lists.linuxtogo.org/pipermail/openembedded-core/2011-December/014487.html>
>
> Please inform if my fix doesn't work.
>
> BR,
> Lauri
>
Lauri Hintsala - Jan. 13, 2012, 9:50 a.m.
On 01/13/2012 10:16 AM, Andrei Gherzan wrote:
> As i could see that patch has nothing in common with this bug. Yes, it
> uses expr from busybox... but that is all. No fix for 64bit numbers support.

Sorry, my fingers were faster than my head. I thought this bug was 
opened because of yocto time set issue:
https://lists.yoctoproject.org/pipermail/yocto/2012-January/006437.html

I see this is general issue. You can forget my previous message.

BR,
Lauri
Darren Hart - Jan. 13, 2012, 3:12 p.m.
On 01/09/2012 08:52 AM, Otavio Salvador wrote:
> On Mon, Jan 9, 2012 at 14:26, Mark Hatle <mark.hatle@windriver.com
> <mailto:mark.hatle@windriver.com>> wrote:
> 
>     On 1/9/12 2:09 AM, Phil Blundell wrote:
> 
>         You could take a look at the busybox-config.inc stuff in
>         oe-classic as a
>         starting point.  It doesn't do PACKAGECONFIG (since oe-classic
>         doesn't
>         have that) but it can do the equivalent with DISTRO_FEATURES.
> 
> 
>     At Wind River we've discussed using the kernel configuration
>     fragment patching process as a way to control busybox.  This would
>     allow the recipe to provide a default fragment (configuration), with
>     machines, architectures, and other configurations providing
>     additional fragments -- that together would produce the busybox that
>     the end use wants.
> 
>     I think this is a better long term approach then hacking the
>     defconfig file each time it's not quite right for a system.  (We may
>     still need to modify it over time, but the modifications need to be
>     considered "generic" based on the use of busybox in say
>     core-image-minimal...)
> 
> 
> I agree with the concept of the idea and long term solution however I
> also think it needs to be well documented otherwise it is going to be a
> problem, instead of a solution.
> 
> When I tried to use the kernel configuration fragment from Yocto I
> couldn't figure it out by myself and it seems very undocumented thus its
> learn curve is not as good as I'd hope for...

The need for something like this was also highlighted during my
poky-tiny work for Yocto. We need a config fragment manager for busybox,
although the yocto-kernel tools may be overkill. We also need something
that adjusts those fragments based on DISTRO_FEATURES, especially the
libc bits.

I can see the value of busybox "profiles", such as tiny and standard for
a start. The yocto-kernel tooling might be a good fit for this, but it
could also be accomplished with a couple busybox recipes and the
PREFERRED_PROVIDER mechanism.
Saul Wold - Jan. 19, 2012, 6:31 p.m.
On 01/08/2012 04:03 PM, Andrei Gherzan wrote:
> From: Andrei Gherzan<andrei.gherzan@windriver.com>
>
> Enable 64-bit math support in the expr applet. This will make
> the applet slightly larger, but will allow computation with very
> large numbers.
>
> [YOCTO #1767]
>
> Signed-off-by: Andrei Gherzan<andrei@gherzan.ro>
> ---
>   meta/recipes-core/busybox/busybox-1.19.3/defconfig |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-core/busybox/busybox-1.19.3/defconfig b/meta/recipes-core/busybox/busybox-1.19.3/defconfig
> index 1990f28..ebd751d 100644
> --- a/meta/recipes-core/busybox/busybox-1.19.3/defconfig
> +++ b/meta/recipes-core/busybox/busybox-1.19.3/defconfig
> @@ -214,7 +214,7 @@ CONFIG_FEATURE_ENV_LONG_OPTIONS=y
>   # CONFIG_EXPAND is not set
>   # CONFIG_FEATURE_EXPAND_LONG_OPTIONS is not set
>   CONFIG_EXPR=y
> -# CONFIG_EXPR_MATH_SUPPORT_64 is not set
> +CONFIG_EXPR_MATH_SUPPORT_64=y
>   CONFIG_FALSE=y
>   # CONFIG_FOLD is not set
>   # CONFIG_FSYNC is not set

Merged into OE-Core

Thanks
	Sau!

Patch

diff --git a/meta/recipes-core/busybox/busybox-1.19.3/defconfig b/meta/recipes-core/busybox/busybox-1.19.3/defconfig
index 1990f28..ebd751d 100644
--- a/meta/recipes-core/busybox/busybox-1.19.3/defconfig
+++ b/meta/recipes-core/busybox/busybox-1.19.3/defconfig
@@ -214,7 +214,7 @@  CONFIG_FEATURE_ENV_LONG_OPTIONS=y
 # CONFIG_EXPAND is not set
 # CONFIG_FEATURE_EXPAND_LONG_OPTIONS is not set
 CONFIG_EXPR=y
-# CONFIG_EXPR_MATH_SUPPORT_64 is not set
+CONFIG_EXPR_MATH_SUPPORT_64=y
 CONFIG_FALSE=y
 # CONFIG_FOLD is not set
 # CONFIG_FSYNC is not set