Patchwork [meta-oe] udisks: add sytemd to DEPENDS

login
register
mail settings
Submitter Andreas Müller
Date Jan. 8, 2012, 1:33 a.m.
Message ID <1325986434-2020-1-git-send-email-schnitzeltony@gmx.de>
Download mbox | patch
Permalink /patch/18761/
State New, archived
Headers show

Comments

Andreas Müller - Jan. 8, 2012, 1:33 a.m.
If systemd was not yet build, udisks configure caused systemd files not being
build so udisks-sytemd package was empty. On do_rootfs we got:
| Collected errors:
|  * opkg_install_cmd: Cannot install package udisks-systemd.

Signed-off-by: Andreas Müller <schnitzeltony@gmx.de>
---
 meta-oe/recipes-support/udisks/udisks_1.0.4.bb |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Koen Kooi - Jan. 9, 2012, 9:38 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 08-01-12 02:33, Andreas Müller schreef:
> If systemd was not yet build, udisks configure caused systemd files not
> being build so udisks-sytemd package was empty. On do_rootfs we got: |
> Collected errors: |  * opkg_install_cmd: Cannot install package
> udisks-systemd.
> 
> Signed-off-by: Andreas Müller <schnitzeltony@gmx.de>

I'm not sure this is the right solution, but I'll take the patch if someone
doesn't come up with a better way to solve this.

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (Darwin)
Comment: GPGTools - http://gpgtools.org

iEYEARECAAYFAk8KtX0ACgkQMkyGM64RGpEdiQCdHJrxZ2qeZVKMPhnOBIZIge+4
jXkAnj+eSR0cBM8Rs/GQSmFdVLFGRKsz
=UdTQ
-----END PGP SIGNATURE-----
Otavio Salvador - Jan. 9, 2012, 11:29 a.m.
On Mon, Jan 9, 2012 at 07:38, Koen Kooi <koen@dominion.thruhere.net> wrote:

> I'm not sure this is the right solution, but I'll take the patch if someone
> doesn't come up with a better way to solve this.
>

The right fix is to handle it in systemd.bbclass and bump every package PR
using it.
Andreas Müller - Jan. 11, 2012, 10:30 p.m.
On Monday, January 09, 2012 12:29:47 PM Otavio Salvador wrote:
> On Mon, Jan 9, 2012 at 07:38, Koen Kooi <koen@dominion.thruhere.net> wrote:
> > I'm not sure this is the right solution, but I'll take the patch if
> > someone doesn't come up with a better way to solve this.
> 
> The right fix is to handle it in systemd.bbclass and bump every package PR
> using it.
Can we agree on that? I would volunteer to prepare these patches.

Andreas
Peter Bigot - Jan. 30, 2012, 5:26 p.m.
On Wed, Jan 11, 2012 at 4:30 PM, Andreas Müller <schnitzeltony@gmx.de> wrote:
> On Monday, January 09, 2012 12:29:47 PM Otavio Salvador wrote:
>> On Mon, Jan 9, 2012 at 07:38, Koen Kooi <koen@dominion.thruhere.net> wrote:
>> > I'm not sure this is the right solution, but I'll take the patch if
>> > someone doesn't come up with a better way to solve this.

Seems this patch is also necessary for building from the current master.

>> The right fix is to handle it in systemd.bbclass and bump every package PR
>> using it.
> Can we agree on that? I would volunteer to prepare these patches.

Is this still the plan?

Peter

Patch

diff --git a/meta-oe/recipes-support/udisks/udisks_1.0.4.bb b/meta-oe/recipes-support/udisks/udisks_1.0.4.bb
index c3e2664..0e330fa 100644
--- a/meta-oe/recipes-support/udisks/udisks_1.0.4.bb
+++ b/meta-oe/recipes-support/udisks/udisks_1.0.4.bb
@@ -2,7 +2,7 @@  DESCRIPTION = "A storage daemon that implements well-defined D-Bus interfaces th
 LICENSE = "GPLv2+"
 LIC_FILES_CHKSUM = "file://COPYING;md5=73d83aebe7e4b62346afde80e0e94273"
 
-DEPENDS = "libatasmart sg3-utils polkit udev dbus-glib glib-2.0"
+DEPENDS = "libatasmart sg3-utils polkit udev dbus-glib glib-2.0 systemd"
 # optional dependencies: device-mapper parted
 
 SRC_URI = "http://hal.freedesktop.org/releases/${BPN}-${PV}.tar.gz;name=${BPN} \
@@ -12,7 +12,7 @@  SRC_URI = "http://hal.freedesktop.org/releases/${BPN}-${PV}.tar.gz;name=${BPN} \
 SRC_URI[udisks.md5sum] = "86c63b2b5484f2060499a052b5b6256b"
 SRC_URI[udisks.sha256sum] = "854b89368733b9c3a577101b761ad5397ae75a05110c8698ac5b29de9a8bf8f5"
 
-PR = "r1"
+PR = "r2"
 
 inherit autotools systemd