Patchwork [RFC,v2] gtk-icon-cache.bbclass: add -f option to gtk-update-icon-cache in postinst

login
register
mail settings
Submitter Steve Sakoman
Date Jan. 7, 2012, 4:51 a.m.
Message ID <1325911915-16001-3-git-send-email-steve@sakoman.com>
Download mbox | patch
Permalink /patch/18751/
State Accepted
Commit b3bb99c6faaf5c1613246309fd05cd95c39c77f4
Headers show

Comments

Steve Sakoman - Jan. 7, 2012, 4:51 a.m.
The gtk-update-icon-cache utility does not create a cache file if
one does not already exist.  Since some packages (notably gnome-icon-theme)
do not ship a cache file by default, the results of the utility are
not saved.  Adding the force option writes out the cache even if there
wasn't a default cache in the package.

Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
 meta/classes/gtk-icon-cache.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Saul Wold - Jan. 12, 2012, 6:28 a.m.
On 01/06/2012 08:51 PM, Steve Sakoman wrote:
> The gtk-update-icon-cache utility does not create a cache file if
> one does not already exist.  Since some packages (notably gnome-icon-theme)
> do not ship a cache file by default, the results of the utility are
> not saved.  Adding the force option writes out the cache even if there
> wasn't a default cache in the package.
>
> Signed-off-by: Steve Sakoman<steve@sakoman.com>
> ---
>   meta/classes/gtk-icon-cache.bbclass |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta/classes/gtk-icon-cache.bbclass b/meta/classes/gtk-icon-cache.bbclass
> index eac3061..0204fd3 100644
> --- a/meta/classes/gtk-icon-cache.bbclass
> +++ b/meta/classes/gtk-icon-cache.bbclass
> @@ -14,7 +14,7 @@ GDK_PIXBUF_MODULEDIR=${libdir}/gdk-pixbuf-2.0/2.10.0/loaders gdk-pixbuf-query-lo
>
>   for icondir in /usr/share/icons/* ; do
>       if [ -d $icondir ] ; then
> -        gtk-update-icon-cache -qt  $icondir
> +        gtk-update-icon-cache -fqt  $icondir
>       fi
>   done
>   }

Seemed reasonable, so merged into OE-Core

Thanks
	Sau!

Patch

diff --git a/meta/classes/gtk-icon-cache.bbclass b/meta/classes/gtk-icon-cache.bbclass
index eac3061..0204fd3 100644
--- a/meta/classes/gtk-icon-cache.bbclass
+++ b/meta/classes/gtk-icon-cache.bbclass
@@ -14,7 +14,7 @@  GDK_PIXBUF_MODULEDIR=${libdir}/gdk-pixbuf-2.0/2.10.0/loaders gdk-pixbuf-query-lo
 
 for icondir in /usr/share/icons/* ; do
     if [ -d $icondir ] ; then
-        gtk-update-icon-cache -qt  $icondir
+        gtk-update-icon-cache -fqt  $icondir
     fi
 done
 }