diff mbox series

[2/2] wic/efi-bootdisk.wks: Fix for 6.1 kernel versions

Message ID 20230126171648.2527833-2-richard.purdie@linuxfoundation.org
State Accepted, archived
Commit 16e0b8a8fc36f5525b1801888851958f0dbe84c2
Headers show
Series [1/2] oeqa/selftest/devtool: Fix for linux 6.1 versions onwards | expand

Commit Message

Richard Purdie Jan. 26, 2023, 5:16 p.m. UTC
oe-selftest efibootpartition.GenericEFITest.test_boot_efi was failing for 6.1 kernels with:

| ERROR: _exec_cmd: export PATH=[...] mcopy -i [...]/rootfs_boot.1.vfat -s [...]/rootfs1/* ::/ returned '1' instead of 0
| output: Disk full

I believe we hit a file boundary size and having "0" overhead in the image meant
the files couldn't be installed. Allow a small amount of overhead to avoid
the error.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 scripts/lib/wic/canned-wks/efi-bootdisk.wks.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Khem Raj Jan. 26, 2023, 6:30 p.m. UTC | #1
On Thu, Jan 26, 2023 at 9:16 AM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> oe-selftest efibootpartition.GenericEFITest.test_boot_efi was failing for 6.1 kernels with:
>
> | ERROR: _exec_cmd: export PATH=[...] mcopy -i [...]/rootfs_boot.1.vfat -s [...]/rootfs1/* ::/ returned '1' instead of 0
> | output: Disk full
>
> I believe we hit a file boundary size and having "0" overhead in the image meant
> the files couldn't be installed. Allow a small amount of overhead to avoid
> the error.

Just curious. how big is 6.1 size compared to 5.19 ?

>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  scripts/lib/wic/canned-wks/efi-bootdisk.wks.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/lib/wic/canned-wks/efi-bootdisk.wks.in b/scripts/lib/wic/canned-wks/efi-bootdisk.wks.in
> index 7300e65e32d..2fd286ff982 100644
> --- a/scripts/lib/wic/canned-wks/efi-bootdisk.wks.in
> +++ b/scripts/lib/wic/canned-wks/efi-bootdisk.wks.in
> @@ -1,3 +1,3 @@
>  bootloader --ptable gpt
> -part /boot --source rootfs --rootfs-dir=${IMAGE_ROOTFS}/boot --fstype=vfat --label boot --active --align 1024 --use-uuid --overhead-factor 1.0
> +part /boot --source rootfs --rootfs-dir=${IMAGE_ROOTFS}/boot --fstype=vfat --label boot --active --align 1024 --use-uuid --overhead-factor 1.1
>  part / --source rootfs --fstype=ext4 --label root --align 1024 --exclude-path boot/
> --
> 2.37.2
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#176412): https://lists.openembedded.org/g/openembedded-core/message/176412
> Mute This Topic: https://lists.openembedded.org/mt/96547775/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/scripts/lib/wic/canned-wks/efi-bootdisk.wks.in b/scripts/lib/wic/canned-wks/efi-bootdisk.wks.in
index 7300e65e32d..2fd286ff982 100644
--- a/scripts/lib/wic/canned-wks/efi-bootdisk.wks.in
+++ b/scripts/lib/wic/canned-wks/efi-bootdisk.wks.in
@@ -1,3 +1,3 @@ 
 bootloader --ptable gpt
-part /boot --source rootfs --rootfs-dir=${IMAGE_ROOTFS}/boot --fstype=vfat --label boot --active --align 1024 --use-uuid --overhead-factor 1.0
+part /boot --source rootfs --rootfs-dir=${IMAGE_ROOTFS}/boot --fstype=vfat --label boot --active --align 1024 --use-uuid --overhead-factor 1.1
 part / --source rootfs --fstype=ext4 --label root --align 1024 --exclude-path boot/