| Submitter | Otavio Salvador |
|---|---|
| Date | Jan. 6, 2012, 6:59 p.m. |
| Message ID | <b61f46cb503582b669cbc56b0ea04d7fdaafd256.1325876341.git.otavio@ossystems.com.br> |
| Download | mbox | patch |
| Permalink | /patch/18687/ |
| State | Accepted |
| Commit | 6ae89951a73c97f6f1b4bbde39f3dadb72fa3dcd |
| Headers | show |
Comments
On Fri, 2012-01-06 at 18:59 +0000, Otavio Salvador wrote:
> +EXTRA_OECONF = "--disable-man-pages"
why is this desirable?
p.
On Fri, Jan 6, 2012 at 17:57, Phil Blundell <philb@gnu.org> wrote: > On Fri, 2012-01-06 at 18:59 +0000, Otavio Salvador wrote: > > +EXTRA_OECONF = "--disable-man-pages" > > why is this desirable? > Because it was breaking builds for me.
On 1/6/12 2:10 PM, Otavio Salvador wrote: > On Fri, Jan 6, 2012 at 17:57, Phil Blundell<philb@gnu.org> wrote: > >> On Fri, 2012-01-06 at 18:59 +0000, Otavio Salvador wrote: >>> +EXTRA_OECONF = "--disable-man-pages" >> >> why is this desirable? >> > > Because it was breaking builds for me. > In what way? Most of the problems I've observed in the past have been docbook related, but I think those have been resolved within OE-Core. Man pages are very desirable for a class of systems, so I'm hesitant to simply remove them w/o a reason or replacement (i.e. a static page) --Mark
On Fri, Jan 6, 2012 at 19:13, Mark Hatle <mark.hatle@windriver.com> wrote: > In what way? Most of the problems I've observed in the past have been > docbook related, but I think those have been resolved within OE-Core. > Docbook related problems; you prefer if we fix those then?
On Fri, Jan 6, 2012 at 19:49, Otavio Salvador <otavio@ossystems.com.br>wrote: > On Fri, Jan 6, 2012 at 19:13, Mark Hatle <mark.hatle@windriver.com> wrote: > >> In what way? Most of the problems I've observed in the past have been >> docbook related, but I think those have been resolved within OE-Core. >> > > Docbook related problems; you prefer if we fix those then? > It uses xsltproc and there's no native recipe at this moment.
On 1/6/12 4:21 PM, Otavio Salvador wrote: > On Fri, Jan 6, 2012 at 19:49, Otavio Salvador<otavio@ossystems.com.br>wrote: > >> On Fri, Jan 6, 2012 at 19:13, Mark Hatle<mark.hatle@windriver.com> wrote: >> >>> In what way? Most of the problems I've observed in the past have been >>> docbook related, but I think those have been resolved within OE-Core. >>> >> >> Docbook related problems; you prefer if we fix those then? >> > > It uses xsltproc and there's no native recipe at this moment. > Hmm, I think the best solution is to fix the docbook problems, but baring that a static version of the man pages is the next best alternative. Advantage to fixing docbook is it will work for the next package. :) --Mark
On Mon, Jan 9, 2012 at 14:02, Mark Hatle <mark.hatle@windriver.com> wrote: > Hmm, I think the best solution is to fix the docbook problems, but baring > that a static version of the man pages is the next best alternative. > > Advantage to fixing docbook is it will work for the next package. :) I fully agree but I am short in time for our deadline so this wasn't an option thus we choose the shortest route for now.
On Mon, Jan 09, 2012 at 10:02:02AM -0600, Mark Hatle wrote: > On 1/6/12 4:21 PM, Otavio Salvador wrote: > > On Fri, Jan 6, 2012 at 19:49, Otavio Salvador<otavio@ossystems.com.br>wrote: > > > >> On Fri, Jan 6, 2012 at 19:13, Mark Hatle<mark.hatle@windriver.com> wrote: > >> > >>> In what way? Most of the problems I've observed in the past have been > >>> docbook related, but I think those have been resolved within OE-Core. > >>> > >> > >> Docbook related problems; you prefer if we fix those then? > >> > > > > It uses xsltproc and there's no native recipe at this moment. > > > > Hmm, I think the best solution is to fix the docbook problems, but baring that a > static version of the man pages is the next best alternative. > > Advantage to fixing docbook is it will work for the next package. :) and for all xorg-* stuff... http://www.mail-archive.com/openembedded-devel@lists.openembedded.org/msg23006.html But right now I'm using patches to disable it for xorg-* too...
On (09/01/12 15:19), Otavio Salvador wrote: > On Mon, Jan 9, 2012 at 14:02, Mark Hatle <mark.hatle@windriver.com> wrote: > > > Hmm, I think the best solution is to fix the docbook problems, but baring > > that a static version of the man pages is the next best alternative. > > > > Advantage to fixing docbook is it will work for the next package. :) > > > I fully agree but I am short in time for our deadline so this wasn't an > option thus we choose the shortest route for now. I think if we keep this thing going without addressing underlying problem it degrades the quility of metadata. Documentation is important aspect of a package and we should make it possible to generate it as much no body is going to remove that option later when xsltproc-native starts working since this package will be building with or without xslt at that time. So in my opion fixing it at the same time is more efficient though a bit more effort I concur.
Patch
diff --git a/meta-oe/recipes-support/udisks/udisks_1.0.4.bb b/meta-oe/recipes-support/udisks/udisks_1.0.4.bb index c3e2664..55b115e 100644 --- a/meta-oe/recipes-support/udisks/udisks_1.0.4.bb +++ b/meta-oe/recipes-support/udisks/udisks_1.0.4.bb @@ -12,13 +12,15 @@ SRC_URI = "http://hal.freedesktop.org/releases/${BPN}-${PV}.tar.gz;name=${BPN} \ SRC_URI[udisks.md5sum] = "86c63b2b5484f2060499a052b5b6256b" SRC_URI[udisks.sha256sum] = "854b89368733b9c3a577101b761ad5397ae75a05110c8698ac5b29de9a8bf8f5" -PR = "r1" +PR = "r2" inherit autotools systemd SYSTEMD_PACKAGES = "${PN}-systemd" SYSTEMD_SERVICE_${PN}-systemd = "udisks-daemon.service" +EXTRA_OECONF = "--disable-man-pages" + PACKAGES =+ "${PN}-systemd" FILES_${PN}-systemd = "${base_libdir}/systemd/system/"
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> --- meta-oe/recipes-support/udisks/udisks_1.0.4.bb | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)