Patchwork [v2] filesystems: fix mount order

login
register
mail settings
Submitter Gary Thomas
Date Jan. 6, 2012, 1:35 p.m.
Message ID <4F06F8BA.8010700@mlbassoc.com>
Download mbox | patch
Permalink /patch/18655/
State New
Headers show

Comments

Gary Thomas - Jan. 6, 2012, 1:35 p.m.
This changes the order that file system [types] are tried
when using 'mount' in busybox when the file system type is
not explictly specified.  The pervious ordering is
incorrect in that less capable file system types are tried
first, e.g. ext2 before ext3, which will cause an ext3 file
system to be mounted as ext2, disabling some of the ext3
features such as journaling.

The change also moves infrequently used file system types to
the end as checking for them is just a waste of effort in
most cases.  The list now also includes ext4.

Signed-off-by: Gary Thomas <gary@mlbassoc.com>
---
  .../recipes-core/base-files/base-files/filesystems |    9 +++++----
  1 files changed, 5 insertions(+), 4 deletions(-)
Richard Purdie - Jan. 6, 2012, 2:42 p.m.
On Fri, 2012-01-06 at 06:35 -0700, Gary Thomas wrote:
> This changes the order that file system [types] are tried
> when using 'mount' in busybox when the file system type is
> not explictly specified.  The pervious ordering is
> incorrect in that less capable file system types are tried
> first, e.g. ext2 before ext3, which will cause an ext3 file
> system to be mounted as ext2, disabling some of the ext3
> features such as journaling.
> 
> The change also moves infrequently used file system types to
> the end as checking for them is just a waste of effort in
> most cases.  The list now also includes ext4.
> 
> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
> ---
>   .../recipes-core/base-files/base-files/filesystems |    9 +++++----
>   1 files changed, 5 insertions(+), 4 deletions(-)

Merged to master, thanks.

I had to add a PR bump, mention base-files in the commit summary and for
some reason the patch was corrupt and wouldn't apply either so I had to
do so manually.

Cheers,

Richard

Patch

diff --git a/meta/recipes-core/base-files/base-files/filesystems b/meta/recipes-core/base-files/base-files/filesystems
index 2af6a7e..7e6c41c 100644
--- a/meta/recipes-core/base-files/base-files/filesystems
+++ b/meta/recipes-core/base-files/base-files/filesystems
@@ -1,7 +1,8 @@ 
-minix
-fat
-vfat
-ext2
+ext4
  ext3
+ext2
+vfat
+fat
  btrfs
+minix
  *