Patchwork [0/7,PULL] Hob2 related oe-core changes

login
register
mail settings
Submitter Dongxiao Xu
Date Jan. 6, 2012, 9:04 a.m.
Message ID <cover.1325840092.git.dongxiao.xu@intel.com>
Download mbox
Permalink /patch/18649/
State New
Headers show

Pull-request

git://git.pokylinux.org/poky-contrib dxu4/hob-oecore-changes

Comments

Dongxiao Xu - Jan. 6, 2012, 9:04 a.m.
Hi Richard,

This pull request is the hob2 related oe-core changes.
Please help to review and pull.

Note that this pull request has dependency on the hob related bitbake changes.

Thanks,
Dongxiao

The following changes since commit 4a85312568a6bb052cc511c15b4ae842ff7f8e59:
  Richard Purdie (1):
        image-mklibs/package_ipk: Remove bashisms

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib dxu4/hob-oecore-changes
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dxu4/hob-oecore-changes

Dongxiao Xu (6):
  bblayers.conf.sample: Use ?= to set BBLAYERS
  image.bbclass: Use ?= to set LINGUAS_INSTALL
  packageinfo.bbclass: add a new bbclass to pass package information
  hob.bb: Add a empty image template
  hob-toolchain: add a new recipe hob-toolchain
  layers: add a new folder to put user added layers

Shane Wang (1):
  package.bbclass: set package size into pkgdata for hob2's use

 layers/README                           |    1 +
 meta/classes/image.bbclass              |    2 +-
 meta/classes/package.bbclass            |    8 ++++++++
 meta/classes/packageinfo.bbclass        |   30 ++++++++++++++++++++++++++++++
 meta/conf/bblayers.conf.sample          |    2 +-
 meta/recipes-core/images/hob.bb         |    1 +
 meta/recipes-core/meta/hob-toolchain.bb |   10 ++++++++++
 7 files changed, 52 insertions(+), 2 deletions(-)
 create mode 100644 layers/README
 create mode 100644 meta/classes/packageinfo.bbclass
 create mode 100644 meta/recipes-core/images/hob.bb
 create mode 100644 meta/recipes-core/meta/hob-toolchain.bb
Richard Purdie - Jan. 6, 2012, 4:27 p.m.
On Fri, 2012-01-06 at 17:04 +0800, Dongxiao Xu wrote:
> Hi Richard,
> 
> This pull request is the hob2 related oe-core changes.
> Please help to review and pull.
> 
> Note that this pull request has dependency on the hob related bitbake changes.
> 
> Thanks,
> Dongxiao
> 
> The following changes since commit 4a85312568a6bb052cc511c15b4ae842ff7f8e59:
>   Richard Purdie (1):
>         image-mklibs/package_ipk: Remove bashisms
> 
> are available in the git repository at:
> 
>   git://git.pokylinux.org/poky-contrib dxu4/hob-oecore-changes
>   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dxu4/hob-oecore-changes
> 
> Dongxiao Xu (6):
>   bblayers.conf.sample: Use ?= to set BBLAYERS
>   image.bbclass: Use ?= to set LINGUAS_INSTALL

I merged these.

>   packageinfo.bbclass: add a new bbclass to pass package information

I still have quite a strong dislike of this code, its rather nasty to
require this and I wish we could come up with a less ugly way to collect
up this information.

>   hob.bb: Add a empty image template
>   hob-toolchain: add a new recipe hob-toolchain
>   layers: add a new folder to put user added layers

I don't like these three. They're horribly hob specific and IMO
shouldn't be in the general metadata. If there is no way to avoid them,
they should perhaps go into a meta-hob layer directory to keep them
separate from the rest of the system.

I'm still puzzled how the layers directory helps. We deliberately
support generic layer locations so forcing the user to place them in a
particular place seems like a bit of a backwards step? :/.

Cheers,

Richard
Mark Hatle - Jan. 6, 2012, 4:37 p.m.
On 1/6/12 10:27 AM, Richard Purdie wrote:
> On Fri, 2012-01-06 at 17:04 +0800, Dongxiao Xu wrote:
>> Hi Richard,
>>
>> This pull request is the hob2 related oe-core changes.
>> Please help to review and pull.
>>
>> Note that this pull request has dependency on the hob related bitbake changes.
>>
>> Thanks,
>> Dongxiao
>>
>> The following changes since commit 4a85312568a6bb052cc511c15b4ae842ff7f8e59:
>>    Richard Purdie (1):
>>          image-mklibs/package_ipk: Remove bashisms
>>
>> are available in the git repository at:
>>
>>    git://git.pokylinux.org/poky-contrib dxu4/hob-oecore-changes
>>    http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dxu4/hob-oecore-changes
>>
>> Dongxiao Xu (6):
>>    bblayers.conf.sample: Use ?= to set BBLAYERS
>>    image.bbclass: Use ?= to set LINGUAS_INSTALL
>
> I merged these.
>
>>    packageinfo.bbclass: add a new bbclass to pass package information
>
> I still have quite a strong dislike of this code, its rather nasty to
> require this and I wish we could come up with a less ugly way to collect
> up this information.
>
>>    hob.bb: Add a empty image template
>>    hob-toolchain: add a new recipe hob-toolchain
>>    layers: add a new folder to put user added layers
>
> I don't like these three. They're horribly hob specific and IMO
> shouldn't be in the general metadata. If there is no way to avoid them,
> they should perhaps go into a meta-hob layer directory to keep them
> separate from the rest of the system.
>
> I'm still puzzled how the layers directory helps. We deliberately
> support generic layer locations so forcing the user to place them in a
> particular place seems like a bit of a backwards step? :/.

I think the layer directory is useful for distributions based on oe-core.  But I 
agree, it seems wrong to have it in OE-core itself -- unless there is a strong 
demand from the users of a "standard place" to put layers in their tree.  (So 
far I've not heard such a request.)

--Mark

> Cheers,
>
> Richard
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Koen Kooi - Jan. 6, 2012, 4:41 p.m.
Op 6 jan. 2012, om 17:27 heeft Richard Purdie het volgende geschreven:

> On Fri, 2012-01-06 at 17:04 +0800, Dongxiao Xu wrote:
>> Hi Richard,
>> 
>> This pull request is the hob2 related oe-core changes.
>> Please help to review and pull.
>> 
>> Note that this pull request has dependency on the hob related bitbake changes.
>> 
>> Thanks,
>> Dongxiao
>> 
>> The following changes since commit 4a85312568a6bb052cc511c15b4ae842ff7f8e59:
>>  Richard Purdie (1):
>>        image-mklibs/package_ipk: Remove bashisms
>> 
>> are available in the git repository at:
>> 
>>  git://git.pokylinux.org/poky-contrib dxu4/hob-oecore-changes
>>  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dxu4/hob-oecore-changes
>> 
>> Dongxiao Xu (6):
>>  bblayers.conf.sample: Use ?= to set BBLAYERS
>>  image.bbclass: Use ?= to set LINGUAS_INSTALL
> 
> I merged these.
> 
>>  packageinfo.bbclass: add a new bbclass to pass package information
> 
> I still have quite a strong dislike of this code, its rather nasty to
> require this and I wish we could come up with a less ugly way to collect
> up this information.
> 
>>  hob.bb: Add a empty image template
>>  hob-toolchain: add a new recipe hob-toolchain
>>  layers: add a new folder to put user added layers
> 
> I don't like these three. They're horribly hob specific and IMO
> shouldn't be in the general metadata. If there is no way to avoid them,
> they should perhaps go into a meta-hob layer directory to keep them
> separate from the rest of the system.

And I still don't get why hob can't load local.conf to load the defaults instead of ignoring it completely.
Dongxiao Xu - Jan. 7, 2012, 7:40 a.m.
Hi Richard,

> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org
> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> Richard Purdie
> Sent: Saturday, January 07, 2012 12:28 AM
> To: Patches and discussions about the oe-core layer
> Subject: Re: [OE-core] [PATCH 0/7][PULL] Hob2 related oe-core changes
> 
> On Fri, 2012-01-06 at 17:04 +0800, Dongxiao Xu wrote:
> > Hi Richard,
> >
> > This pull request is the hob2 related oe-core changes.
> > Please help to review and pull.
> >
> > Note that this pull request has dependency on the hob related bitbake
> changes.
> >
> > Thanks,
> > Dongxiao
> >
> > The following changes since commit
> 4a85312568a6bb052cc511c15b4ae842ff7f8e59:
> >   Richard Purdie (1):
> >         image-mklibs/package_ipk: Remove bashisms
> >
> > are available in the git repository at:
> >
> >   git://git.pokylinux.org/poky-contrib dxu4/hob-oecore-changes
> >
> > http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dxu4/hob-oecore-
> > changes
> >
> > Dongxiao Xu (6):
> >   bblayers.conf.sample: Use ?= to set BBLAYERS
> >   image.bbclass: Use ?= to set LINGUAS_INSTALL
> 
> I merged these.

Thanks!

> 
> >   packageinfo.bbclass: add a new bbclass to pass package information
> 
> I still have quite a strong dislike of this code, its rather nasty to require this and I
> wish we could come up with a less ugly way to collect up this information.

I am sorry if this patch makes you feel uncomfortable.

Actually this approach was brought out early in the HOB2 design phase, and that time I didn't get explicit objection about it.
Refer to bug http://bugzilla.pokylinux.org/show_bug.cgi?id=1750, which is a M2 task.

Later we had some discussions of finding new way to dump all the available packages from server side.
Due to the schedule reason, we have to put it into M3. Refer to bug http://bugzilla.pokylinux.org/show_bug.cgi?id=1871.

But I think this approach is similar with buildhistory.bbclass. (Actually I am not aware there is buildhistory.bbclass exists when I wrote my code).
What the main difference is, buildhistory.bbclass writes the information into a local file, but packageinfo.bbclass emit the info as an event.

> 
> >   hob.bb: Add a empty image template
> >   hob-toolchain: add a new recipe hob-toolchain
> >   layers: add a new folder to put user added layers
> 
> I don't like these three. They're horribly hob specific and IMO shouldn't be in the
> general metadata. If there is no way to avoid them, they should perhaps go into
> a meta-hob layer directory to keep them separate from the rest of the system.

If we need to support the split of client and server, there is a principle that client GUI should not access any server directories or files.
Therefore HOB will not automatically generate any image bb files and copy it to meta directory.
This is the reason why we need to generate two empty image/toolchain files for the GUI to use.

If you do not like the name of hob.bb or hob-toolchain.bb, I can rename it to a generic one, like dummy-image.bb and dummy-toolchain.bb.
Actually putting them into meta-hob layer also works, but this requires the hob user to manually add meta-hob layer each time when he launches the HOB GUI. Of course we can defaultly add meta-hob layer into bblayers.conf.sample in meta-yocto layer if you think it is feasible.

> 
> I'm still puzzled how the layers directory helps. We deliberately support generic
> layer locations so forcing the user to place them in a particular place seems like
> a bit of a backwards step? :/.

We do not need the "layers" directory if users know where the layers are and then they can edit bblayers.conf.
And in non-split HOB case, users can still put their layers anywhere. HOB supports file browser and user can add layer by that.

But one new situation is, client GUI and server may run in different machines.
How could a client GUI user get the information what are the available layers in server?
I definitely welcome good suggestions.

Thanks,
Dongxiao

> 
> Cheers,
> 
> Richard
> 
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Dongxiao Xu - Jan. 7, 2012, 7:47 a.m.
Hi Koen,

> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org
> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> Koen Kooi
> Sent: Saturday, January 07, 2012 12:42 AM
> To: Patches and discussions about the oe-core layer
> Subject: Re: [OE-core] [PATCH 0/7][PULL] Hob2 related oe-core changes
> 
> 
> Op 6 jan. 2012, om 17:27 heeft Richard Purdie het volgende geschreven:
> 
> > On Fri, 2012-01-06 at 17:04 +0800, Dongxiao Xu wrote:
> >> Hi Richard,
> >>
> >> This pull request is the hob2 related oe-core changes.
> >> Please help to review and pull.
> >>
> >> Note that this pull request has dependency on the hob related bitbake
> changes.
> >>
> >> Thanks,
> >> Dongxiao
> >>
> >> The following changes since commit
> 4a85312568a6bb052cc511c15b4ae842ff7f8e59:
> >>  Richard Purdie (1):
> >>        image-mklibs/package_ipk: Remove bashisms
> >>
> >> are available in the git repository at:
> >>
> >>  git://git.pokylinux.org/poky-contrib dxu4/hob-oecore-changes
> >> http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dxu4/hob-oecore
> >> -changes
> >>
> >> Dongxiao Xu (6):
> >>  bblayers.conf.sample: Use ?= to set BBLAYERS
> >>  image.bbclass: Use ?= to set LINGUAS_INSTALL
> >
> > I merged these.
> >
> >>  packageinfo.bbclass: add a new bbclass to pass package information
> >
> > I still have quite a strong dislike of this code, its rather nasty to
> > require this and I wish we could come up with a less ugly way to
> > collect up this information.
> >
> >>  hob.bb: Add a empty image template
> >>  hob-toolchain: add a new recipe hob-toolchain
> >>  layers: add a new folder to put user added layers
> >
> > I don't like these three. They're horribly hob specific and IMO
> > shouldn't be in the general metadata. If there is no way to avoid
> > them, they should perhaps go into a meta-hob layer directory to keep
> > them separate from the rest of the system.
> 
> And I still don't get why hob can't load local.conf to load the defaults instead of
> ignoring it completely.

The new Hob doesn't ignore local.conf, it will load all its values (except BB_NUMBER_THREADS and PARALLEL_MAKE) as the default configuration.

Thanks,
Dongxiao

> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Dongxiao Xu - Jan. 7, 2012, 7:53 a.m.
> -----Original Message-----
> From: Xu, Dongxiao
> Sent: Saturday, January 07, 2012 3:48 PM
> To: Patches and discussions about the oe-core layer
> Subject: RE: [OE-core] [PATCH 0/7][PULL] Hob2 related oe-core changes
> 
> Hi Koen,
> 
> > -----Original Message-----
> > From: openembedded-core-bounces@lists.openembedded.org
> > [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> > Koen Kooi
> > Sent: Saturday, January 07, 2012 12:42 AM
> > To: Patches and discussions about the oe-core layer
> > Subject: Re: [OE-core] [PATCH 0/7][PULL] Hob2 related oe-core changes
> >
> >
> > Op 6 jan. 2012, om 17:27 heeft Richard Purdie het volgende geschreven:
> >
> > > On Fri, 2012-01-06 at 17:04 +0800, Dongxiao Xu wrote:
> > >> Hi Richard,
> > >>
> > >> This pull request is the hob2 related oe-core changes.
> > >> Please help to review and pull.
> > >>
> > >> Note that this pull request has dependency on the hob related
> > >> bitbake
> > changes.
> > >>
> > >> Thanks,
> > >> Dongxiao
> > >>
> > >> The following changes since commit
> > 4a85312568a6bb052cc511c15b4ae842ff7f8e59:
> > >>  Richard Purdie (1):
> > >>        image-mklibs/package_ipk: Remove bashisms
> > >>
> > >> are available in the git repository at:
> > >>
> > >>  git://git.pokylinux.org/poky-contrib dxu4/hob-oecore-changes
> > >> http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dxu4/hob-oeco
> > >> re
> > >> -changes
> > >>
> > >> Dongxiao Xu (6):
> > >>  bblayers.conf.sample: Use ?= to set BBLAYERS
> > >>  image.bbclass: Use ?= to set LINGUAS_INSTALL
> > >
> > > I merged these.
> > >
> > >>  packageinfo.bbclass: add a new bbclass to pass package information
> > >
> > > I still have quite a strong dislike of this code, its rather nasty
> > > to require this and I wish we could come up with a less ugly way to
> > > collect up this information.
> > >
> > >>  hob.bb: Add a empty image template
> > >>  hob-toolchain: add a new recipe hob-toolchain
> > >>  layers: add a new folder to put user added layers
> > >
> > > I don't like these three. They're horribly hob specific and IMO
> > > shouldn't be in the general metadata. If there is no way to avoid
> > > them, they should perhaps go into a meta-hob layer directory to keep
> > > them separate from the rest of the system.
> >
> > And I still don't get why hob can't load local.conf to load the
> > defaults instead of ignoring it completely.
> 
> The new Hob doesn't ignore local.conf, it will load all its values (except
> BB_NUMBER_THREADS and PARALLEL_MAKE) as the default configuration.

Make some clarification here:
Actually new HOB will also load the BB_NUMBER_THREADS and PARALLEL_MAKE from local.conf.
But if the two values are not set in the local.conf (thus the default value is "1"), HOB will set a proper value for them according to the server's CPU information.

Thanks,
Dongxiao

> 
> Thanks,
> Dongxiao
> 
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core