diff mbox series

[meta-ti,master/dunfell] conf: machine: j721s2: Fix DTB overlay extension for OV5640

Message ID 20230125080136.8308-1-sinthu.raja@ti.com
State Superseded
Delegated to: Ryan Eatmon
Headers show
Series [meta-ti,master/dunfell] conf: machine: j721s2: Fix DTB overlay extension for OV5640 | expand

Commit Message

Sinthu Raja M Jan. 25, 2023, 8:01 a.m. UTC
From: Sinthu Raja <sinthu.raja@ti.com>

The extension for the OV5640 overlay is incorrect. Therefore, update the
correct extension to build the overlay as .dtbo

Fixes: f67e9805 ("conf: machine: j721s2: Add AM68 SK specific dtb and dtbo to KERNEL_DEVICETREE")
Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
---
 conf/machine/j721s2-evm.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Denys Dmytriyenko Jan. 25, 2023, 11:18 p.m. UTC | #1
The only minor issue is that this only applies to dunfell and won't apply to 
master due to the layer restructure. Otherwise looks fine to me.


On Wed, Jan 25, 2023 at 01:31:36PM +0530, Sinthu Raja M via lists.yoctoproject.org wrote:
> From: Sinthu Raja <sinthu.raja@ti.com>
> 
> The extension for the OV5640 overlay is incorrect. Therefore, update the
> correct extension to build the overlay as .dtbo
> 
> Fixes: f67e9805 ("conf: machine: j721s2: Add AM68 SK specific dtb and dtbo to KERNEL_DEVICETREE")
> Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
> ---
>  conf/machine/j721s2-evm.conf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/conf/machine/j721s2-evm.conf b/conf/machine/j721s2-evm.conf
> index 8d3f8db8..488a1140 100644
> --- a/conf/machine/j721s2-evm.conf
> +++ b/conf/machine/j721s2-evm.conf
> @@ -14,7 +14,7 @@ OPTEE_K3_USART = "0x8"
>  
>  KERNEL_DEVICETREE = " \
>      ti/k3-am68-sk-base-board.dtb \
> -    ti/k3-am68-sk-bb-csi2-ov5640.dtb \
> +    ti/k3-am68-sk-bb-csi2-ov5640.dtbo \
>      ti/k3-am68-sk-bb-rpi-cam-imx219.dtbo \
>      ti/k3-am68-sk-som-ddr_mem_carveout.dtbo \
>      ti/k3-j721s2-common-proc-board.dtb \
> -- 
> 2.36.1
Sinthu Raja M Jan. 26, 2023, 5:45 a.m. UTC | #2
On Thu, Jan 26, 2023 at 4:48 AM Denys Dmytriyenko <denis@denix.org> wrote:
>
> The only minor issue is that this only applies to dunfell and won't apply to
> master due to the layer restructure. Otherwise looks fine to me.

I will send out a separate patch for the master branch. Do I need to
send another version with the subject change.

>
>
> On Wed, Jan 25, 2023 at 01:31:36PM +0530, Sinthu Raja M via https://linkprotect.cudasvc.com/url?a=https%3a%2f%2flists.yoctoproject.org&c=E,1,XoeNd_k-NnR7e3sL9mgqs-1sBdpiQC_hgK0kbjqFH89ByeUNIYTa2JmcBHcgFGhAHBsUccnR5iW-EVLPrb7ko7KufCB8i29ZwW9tN1Cp&typo=1 wrote:
> > From: Sinthu Raja <sinthu.raja@ti.com>
> >
> > The extension for the OV5640 overlay is incorrect. Therefore, update the
> > correct extension to build the overlay as .dtbo
> >
> > Fixes: f67e9805 ("conf: machine: j721s2: Add AM68 SK specific dtb and dtbo to KERNEL_DEVICETREE")
> > Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
> > ---
> >  conf/machine/j721s2-evm.conf | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/conf/machine/j721s2-evm.conf b/conf/machine/j721s2-evm.conf
> > index 8d3f8db8..488a1140 100644
> > --- a/conf/machine/j721s2-evm.conf
> > +++ b/conf/machine/j721s2-evm.conf
> > @@ -14,7 +14,7 @@ OPTEE_K3_USART = "0x8"
> >
> >  KERNEL_DEVICETREE = " \
> >      ti/k3-am68-sk-base-board.dtb \
> > -    ti/k3-am68-sk-bb-csi2-ov5640.dtb \
> > +    ti/k3-am68-sk-bb-csi2-ov5640.dtbo \
> >      ti/k3-am68-sk-bb-rpi-cam-imx219.dtbo \
> >      ti/k3-am68-sk-som-ddr_mem_carveout.dtbo \
> >      ti/k3-j721s2-common-proc-board.dtb \
> > --
> > 2.36.1



--
With Regards
Sinthu Raja
diff mbox series

Patch

diff --git a/conf/machine/j721s2-evm.conf b/conf/machine/j721s2-evm.conf
index 8d3f8db8..488a1140 100644
--- a/conf/machine/j721s2-evm.conf
+++ b/conf/machine/j721s2-evm.conf
@@ -14,7 +14,7 @@  OPTEE_K3_USART = "0x8"
 
 KERNEL_DEVICETREE = " \
     ti/k3-am68-sk-base-board.dtb \
-    ti/k3-am68-sk-bb-csi2-ov5640.dtb \
+    ti/k3-am68-sk-bb-csi2-ov5640.dtbo \
     ti/k3-am68-sk-bb-rpi-cam-imx219.dtbo \
     ti/k3-am68-sk-som-ddr_mem_carveout.dtbo \
     ti/k3-j721s2-common-proc-board.dtb \