Patchwork Fix typo in ctcs that causes build failure

login
register
mail settings
Submitter philby john
Date Jan. 5, 2012, 12:53 p.m.
Message ID <1325767984.22038.4.camel@localhost.localdomain>
Download mbox | patch
Permalink /patch/18429/
State New, archived
Headers show

Comments

philby john - Jan. 5, 2012, 12:53 p.m.
From: Philby John <pjohn@mvista.com>
Date: Thu, 5 Jan 2012 18:01:11 +0530
Subject: [PATCH] Fix typo in ctcs that causes build failure

RDEPENDS includes a line perl-module-tcntl, which is
clearly a typo for perl-module-fcntl, without which
you get a build failure.

Signed-off-by: Philby John <pjohn@mvista.com>
---
 recipes/ctorrent/ctcs_1.4.1.bb |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Paul Menzel - Jan. 6, 2012, 8:36 a.m.
Dear Philby,


thank you for the patch.

Am Donnerstag, den 05.01.2012, 18:23 +0530 schrieb philby john:
> From: Philby John <pjohn@mvista.com>
> Date: Thu, 5 Jan 2012 18:01:11 +0530
> Subject: [PATCH] Fix typo in ctcs that causes build failure

Please adhere to the commit policy. Especially prefix the commit summary
with the package name.

> RDEPENDS includes a line perl-module-tcntl, which is
> clearly a typo for perl-module-fcntl, without which
> you get a build failure.

I see that this is an error and will push your improved patch. But I
tried `bitbake -k ctcs` with `angstrom-2010.x` for `MACHINE =
"beagleboard"` and it worked without problems. What command did you use
to get a build error and how does it look like? I guess it is in the
final image creation that the error occurs?

> Signed-off-by: Philby John <pjohn@mvista.com>
> ---
>  recipes/ctorrent/ctcs_1.4.1.bb |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)

[…]


Thanks,

Paul


[1] http://www.openembedded.org/wiki/Commit_Policy

Patch

diff --git a/recipes/ctorrent/ctcs_1.4.1.bb b/recipes/ctorrent/ctcs_1.4.1.bb
index afaee6f..8680b0c 100644
--- a/recipes/ctorrent/ctcs_1.4.1.bb
+++ b/recipes/ctorrent/ctcs_1.4.1.bb
@@ -1,10 +1,11 @@ 
 require ctorrent.inc
 
 DESCRIPTION += "This is the controller of the enhanced version"
-RDEPENDS_${PN} = "perl perl-module-strict perl-module-socket perl-module-tcntl \
+RDEPENDS_${PN} = "perl perl-module-strict perl-module-socket perl-module-fcntl \
             perl-module-errno perl-module-sys-hostname"
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/dtorrent/ctcs-${PV}.tar.gz"
+PR="r1"
 
 do_install () {
   install -d ${D}/usr/bin