Patchwork iw: use a newer commit in the public git

login
register
mail settings
Submitter Eyal Reizer
Date Jan. 5, 2012, 9:47 a.m.
Message ID <1325756829-6511-1-git-send-email-eyalr@ti.com>
Download mbox | patch
Permalink /patch/18415/
State Superseded
Headers show

Comments

Eyal Reizer - Jan. 5, 2012, 9:47 a.m.
switch to use a newer commit in the public git

Signed-off-by: Eyal Reizer <eyalr@ti.com>
---
 recipes/iw/iw_git.bb |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
Paul Menzel - Jan. 5, 2012, 9:58 a.m.
Dear Ayal,


Am Donnerstag, den 05.01.2012, 11:47 +0200 schrieb Eyal Reizer:
> switch to use a newer commit in the public git

That line is redundant to the commit summary. Why not use the following
as the summary?

        iw_git: Update to commit 8b2b1c6a (version 3.2)

Additionally please add if this just introduces new features or if it
fixes any problems for you.

And lastly please add how you have tested the new version.

> Signed-off-by: Eyal Reizer <eyalr@ti.com>
> ---
>  recipes/iw/iw_git.bb |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/recipes/iw/iw_git.bb b/recipes/iw/iw_git.bb
> index c98e1bc..f0dc7ff 100644
> --- a/recipes/iw/iw_git.bb
> +++ b/recipes/iw/iw_git.bb
> @@ -4,9 +4,9 @@ SECTION = "base"
>  PRIORITY = "optional"
>  LICENSE = "BSD"
>  
> -SRCREV = "0a236ef5f8e4ba7218aac7d0cdacf45673d5b35c"
> -PR = "r0"
> -PV = "0.9.22"
> +SRCREV = "8b2b1c6a77ee17e4128b22845cb8c5901de296c9"
> +PR = "r1"
> +PV = "3.2"
>  PR_append = "+gitr${SRCPV}"

I always forget, if a `PR` bump for a version update is needed if we
have `PR_append${SRCPV}`. Could you check that again, please.
 
>  DEPENDS = "libnl pkgconfig"


Thanks,

Paul
Denys Dmytriyenko - Jan. 5, 2012, 6:36 p.m.
On Thu, Jan 05, 2012 at 10:58:26AM +0100, Paul Menzel wrote:
> Dear Ayal,
> 
> 
> Am Donnerstag, den 05.01.2012, 11:47 +0200 schrieb Eyal Reizer:
> > switch to use a newer commit in the public git
> 
> That line is redundant to the commit summary. Why not use the following
> as the summary?
> 
>         iw_git: Update to commit 8b2b1c6a (version 3.2)
> 
> Additionally please add if this just introduces new features or if it
> fixes any problems for you.
> 
> And lastly please add how you have tested the new version.
> 
> > Signed-off-by: Eyal Reizer <eyalr@ti.com>
> > ---
> >  recipes/iw/iw_git.bb |    6 +++---
> >  1 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/recipes/iw/iw_git.bb b/recipes/iw/iw_git.bb
> > index c98e1bc..f0dc7ff 100644
> > --- a/recipes/iw/iw_git.bb
> > +++ b/recipes/iw/iw_git.bb
> > @@ -4,9 +4,9 @@ SECTION = "base"
> >  PRIORITY = "optional"
> >  LICENSE = "BSD"
> >  
> > -SRCREV = "0a236ef5f8e4ba7218aac7d0cdacf45673d5b35c"
> > -PR = "r0"
> > -PV = "0.9.22"
> > +SRCREV = "8b2b1c6a77ee17e4128b22845cb8c5901de296c9"
> > +PR = "r1"
> > +PV = "3.2"
> >  PR_append = "+gitr${SRCPV}"
> 
> I always forget, if a `PR` bump for a version update is needed if we
> have `PR_append${SRCPV}`. Could you check that again, please.

Actually, if the version (PV) is bumped, PR should go back to 0 or 1, ideally. 
Otherwise it's not needed to bump PR, when PV is increased.

Patch

diff --git a/recipes/iw/iw_git.bb b/recipes/iw/iw_git.bb
index c98e1bc..f0dc7ff 100644
--- a/recipes/iw/iw_git.bb
+++ b/recipes/iw/iw_git.bb
@@ -4,9 +4,9 @@  SECTION = "base"
 PRIORITY = "optional"
 LICENSE = "BSD"
 
-SRCREV = "0a236ef5f8e4ba7218aac7d0cdacf45673d5b35c"
-PR = "r0"
-PV = "0.9.22"
+SRCREV = "8b2b1c6a77ee17e4128b22845cb8c5901de296c9"
+PR = "r1"
+PV = "3.2"
 PR_append = "+gitr${SRCPV}"
 
 DEPENDS = "libnl pkgconfig"