| Submitter | Joshua Lock |
|---|---|
| Date | Jan. 4, 2012, 1:31 a.m. |
| Message ID | <a8eea7c83f33f5d5eab1e2758a88f3ee140e68a1.1325640149.git.josh@linux.intel.com> |
| Download | mbox | patch |
| Permalink | /patch/18261/ |
| State | Accepted |
| Commit | ab56f27d96cbd2c79ca16d12333687ca9720934c |
| Headers | show |
Comments
On Tue, Jan 3, 2012 at 7:31 PM, Joshua Lock <josh@linux.intel.com> wrote: > We have witnessed non-deterministic failures of perf for some platforms > whilst looking for bfd.h, a header provided by binutils. > > Signed-off-by: Joshua Lock <josh@linux.intel.com> > --- > meta/recipes-kernel/linux/linux-tools.inc | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/meta/recipes-kernel/linux/linux-tools.inc b/meta/recipes-kernel/linux/linux-tools.inc > index 950f197..aa45dba 100644 > --- a/meta/recipes-kernel/linux/linux-tools.inc > +++ b/meta/recipes-kernel/linux/linux-tools.inc > @@ -22,7 +22,7 @@ addtask install_perf after do_install before do_package > do_compile_perf[umask] = 022 > do_install_perf[umask] = 022 > > -PERFDEPENDS = "virtual/${MLPREFIX}libc:do_populate_sysroot ${MLPREFIX}elfutils:do_populate_sysroot" > +PERFDEPENDS = "virtual/${MLPREFIX}libc:do_populate_sysroot ${MLPREFIX}elfutils:do_populate_sysroot ${MLPREFIX}binutils:do_populate_sysroot" Does this build the rpm for binutils too? I've seen the following error recently when creating the rfs: | error: Failed dependencies: | binutils >= 2.21.1a is needed by perf-3.0.6-r2.p3060qds | libbfd-2.21.1.so is needed by perf-3.0.6-r2.p3060qds -M
On Wed, 2012-01-04 at 16:32 +0000, McClintock Matthew-B29882 wrote: > On Tue, Jan 3, 2012 at 7:31 PM, Joshua Lock <josh@linux.intel.com> wrote: > > We have witnessed non-deterministic failures of perf for some platforms > > whilst looking for bfd.h, a header provided by binutils. > > > > Signed-off-by: Joshua Lock <josh@linux.intel.com> > > --- > > meta/recipes-kernel/linux/linux-tools.inc | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/meta/recipes-kernel/linux/linux-tools.inc b/meta/recipes-kernel/linux/linux-tools.inc > > index 950f197..aa45dba 100644 > > --- a/meta/recipes-kernel/linux/linux-tools.inc > > +++ b/meta/recipes-kernel/linux/linux-tools.inc > > @@ -22,7 +22,7 @@ addtask install_perf after do_install before do_package > > do_compile_perf[umask] = 022 > > do_install_perf[umask] = 022 > > > > -PERFDEPENDS = "virtual/${MLPREFIX}libc:do_populate_sysroot ${MLPREFIX}elfutils:do_populate_sysroot" > > +PERFDEPENDS = "virtual/${MLPREFIX}libc:do_populate_sysroot ${MLPREFIX}elfutils:do_populate_sysroot ${MLPREFIX}binutils:do_populate_sysroot" > > Does this build the rpm for binutils too? I've seen the following > error recently when creating the rfs: > > | error: Failed dependencies: > | binutils >= 2.21.1a is needed by perf-3.0.6-r2.p3060qds > | libbfd-2.21.1.so is needed by perf-3.0.6-r2.p3060qds I suspect the patch is not enough to fix this... Cheers, Richard
On Wed, Jan 4, 2012 at 11:21 AM, Richard Purdie <richard.purdie@linuxfoundation.org> wrote: > On Wed, 2012-01-04 at 16:32 +0000, McClintock Matthew-B29882 wrote: >> On Tue, Jan 3, 2012 at 7:31 PM, Joshua Lock <josh@linux.intel.com> wrote: >> > We have witnessed non-deterministic failures of perf for some platforms >> > whilst looking for bfd.h, a header provided by binutils. >> > >> > Signed-off-by: Joshua Lock <josh@linux.intel.com> >> > --- >> > meta/recipes-kernel/linux/linux-tools.inc | 2 +- >> > 1 files changed, 1 insertions(+), 1 deletions(-) >> > >> > diff --git a/meta/recipes-kernel/linux/linux-tools.inc b/meta/recipes-kernel/linux/linux-tools.inc >> > index 950f197..aa45dba 100644 >> > --- a/meta/recipes-kernel/linux/linux-tools.inc >> > +++ b/meta/recipes-kernel/linux/linux-tools.inc >> > @@ -22,7 +22,7 @@ addtask install_perf after do_install before do_package >> > do_compile_perf[umask] = 022 >> > do_install_perf[umask] = 022 >> > >> > -PERFDEPENDS = "virtual/${MLPREFIX}libc:do_populate_sysroot ${MLPREFIX}elfutils:do_populate_sysroot" >> > +PERFDEPENDS = "virtual/${MLPREFIX}libc:do_populate_sysroot ${MLPREFIX}elfutils:do_populate_sysroot ${MLPREFIX}binutils:do_populate_sysroot" >> >> Does this build the rpm for binutils too? I've seen the following >> error recently when creating the rfs: >> >> | error: Failed dependencies: >> | binutils >= 2.21.1a is needed by perf-3.0.6-r2.p3060qds >> | libbfd-2.21.1.so is needed by perf-3.0.6-r2.p3060qds > > I suspect the patch is not enough to fix this... The error went away after adding this, but I'm not 100% the rpm's where not available the next time regardless of this patch. -M
Patch
diff --git a/meta/recipes-kernel/linux/linux-tools.inc b/meta/recipes-kernel/linux/linux-tools.inc index 950f197..aa45dba 100644 --- a/meta/recipes-kernel/linux/linux-tools.inc +++ b/meta/recipes-kernel/linux/linux-tools.inc @@ -22,7 +22,7 @@ addtask install_perf after do_install before do_package do_compile_perf[umask] = 022 do_install_perf[umask] = 022 -PERFDEPENDS = "virtual/${MLPREFIX}libc:do_populate_sysroot ${MLPREFIX}elfutils:do_populate_sysroot" +PERFDEPENDS = "virtual/${MLPREFIX}libc:do_populate_sysroot ${MLPREFIX}elfutils:do_populate_sysroot ${MLPREFIX}binutils:do_populate_sysroot" PERFDEPENDS_libc-uclibc = "" PERFRDEPENDS = "python perl elfutils" PERFRDEPENDS_libc-uclibc = ""
We have witnessed non-deterministic failures of perf for some platforms whilst looking for bfd.h, a header provided by binutils. Signed-off-by: Joshua Lock <josh@linux.intel.com> --- meta/recipes-kernel/linux/linux-tools.inc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)