From patchwork Wed Jan 11 17:58:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Hoyes X-Patchwork-Id: 18029 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6676C5479D for ; Wed, 11 Jan 2023 17:58:31 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.31330.1673459902979018226 for ; Wed, 11 Jan 2023 09:58:23 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: peter.hoyes@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 73E58FEC; Wed, 11 Jan 2023 09:59:04 -0800 (PST) Received: from e125920.cambridge.arm.com (unknown [10.1.199.64]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EA7653F587; Wed, 11 Jan 2023 09:58:21 -0800 (PST) From: Peter Hoyes To: meta-arm@lists.yoctoproject.org Cc: Peter Hoyes Subject: [PATCH 2/2] arm/scp-firmware: Disable cppcheck Date: Wed, 11 Jan 2023 17:58:03 +0000 Message-Id: <20230111175803.1446302-2-peter.hoyes@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230111175803.1446302-1-peter.hoyes@arm.com> References: <20230111175803.1446302-1-peter.hoyes@arm.com> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Wed, 11 Jan 2023 17:58:31 -0000 X-Groupsio-URL: https://lists.yoctoproject.org/g/meta-arm/message/4261 From: Peter Hoyes The SCP-firmware CMake compile step automatically attempts to execute cppcheck if both: * cppcheck can be located using find_program * DISABLE_CPPCHECK is not defined cppcheck is not readily available in OE-core and is not an essential part of the compilation process for end-users, so explicitly disable the cppcheck step by passing DISABLE_CPPCHECK to CMake. Additionally, because the OE-core CMake toolchain file cannot be used, find_program may locate cppcheck on the host machine, which will cause the build to fail if it is not the recommended version (as it is in recent Linux distros). Issue-Id: SCM-5864 Signed-off-by: Peter Hoyes Change-Id: Ia87a0cbbb67ac1d6f3b26cfb5747a85b46131f81 --- meta-arm/recipes-bsp/scp-firmware/scp-firmware_2.10.0.bb | 1 + 1 file changed, 1 insertion(+) diff --git a/meta-arm/recipes-bsp/scp-firmware/scp-firmware_2.10.0.bb b/meta-arm/recipes-bsp/scp-firmware/scp-firmware_2.10.0.bb index 5dbbff94..055e0c1b 100644 --- a/meta-arm/recipes-bsp/scp-firmware/scp-firmware_2.10.0.bb +++ b/meta-arm/recipes-bsp/scp-firmware/scp-firmware_2.10.0.bb @@ -46,6 +46,7 @@ CFLAGS[unexport] = "1" EXTRA_OECMAKE = "-D CMAKE_BUILD_TYPE=${SCP_BUILD_STR} \ -D SCP_LOG_LEVEL=${SCP_LOG_LEVEL} \ -D SCP_PLATFORM_FEATURE_SET=${SCP_PLATFORM_FEATURE_SET} \ + -D DISABLE_CPPCHECK=1 \ " do_configure() {