Patchwork [RFC,0/2] Add alsa-state from OE Classic

login
register
mail settings
Submitter Joshua Lock
Date Jan. 3, 2012, 2:26 a.m.
Message ID <cover.1325557342.git.josh@linux.intel.com>
Download mbox
Permalink /patch/17999/
State New
Headers show

Pull-request

git://git.openembedded.org/openembedded-core-contrib josh/devices

Comments

Joshua Lock - Jan. 3, 2012, 2:26 a.m.
Please review the following changes for suitability for inclusion. If you have
any objections or suggestions for improvement, please respond to the patches. If
you agree with the changes, please provide your Acked-by.

The small series following introduces the alsa-state recipe from oe-classic.
The reason for doing so is to remove the requirement for recipes like the
beagleboard-audio recipe in meta-yocto, which ensures the beagleboards sound
device has the volume turned up.

Long term I'd like to implement something more generic for handling device quirks,
but alsa-state is a simple fix for an immediate need that should standardise how
alsa configuration is handled in layers.

Cheers.
Joshua

The following changes since commit 8f348ccad083d6c02c200652ff6295e701e88f0d:

  coreutils: ensure --color works so DEPEND on libcap (2011-12-24 10:05:35 +0000)

are available in the git repository at:
  git://git.openembedded.org/openembedded-core-contrib josh/devices
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=josh/devices

Joshua Lock (2):
  alsa-state: add alsa-state from oe classic
  task-base: add alsa-state to task-base-alsa

 meta/recipes-bsp/alsa-state/alsa-state.bb          |   57 ++++++++++++++++++++
 meta/recipes-bsp/alsa-state/alsa-state/alsa-state  |   29 ++++++++++
 meta/recipes-bsp/alsa-state/alsa-state/asound.conf |   12 ++++
 .../recipes-bsp/alsa-state/alsa-state/asound.state |    1 +
 meta/recipes-core/tasks/task-base.bb               |    5 +-
 5 files changed, 102 insertions(+), 2 deletions(-)
 create mode 100644 meta/recipes-bsp/alsa-state/alsa-state.bb
 create mode 100755 meta/recipes-bsp/alsa-state/alsa-state/alsa-state
 create mode 100644 meta/recipes-bsp/alsa-state/alsa-state/asound.conf
 create mode 100644 meta/recipes-bsp/alsa-state/alsa-state/asound.state
Saul Wold - Jan. 4, 2012, 12:43 a.m.
On 01/02/2012 06:26 PM, Joshua Lock wrote:
> Please review the following changes for suitability for inclusion. If you have
> any objections or suggestions for improvement, please respond to the patches. If
> you agree with the changes, please provide your Acked-by.
>
> The small series following introduces the alsa-state recipe from oe-classic.
> The reason for doing so is to remove the requirement for recipes like the
> beagleboard-audio recipe in meta-yocto, which ensures the beagleboards sound
> device has the volume turned up.
>
> Long term I'd like to implement something more generic for handling device quirks,
> but alsa-state is a simple fix for an immediate need that should standardise how
> alsa configuration is handled in layers.
>
Will this address the similar issue that the n450-audio recipe does in 
the meta-intel layer?  The n450 seems to use amixer and not alsactl.

And if so, can you provide a patch for meta-intel?

Sau!

> Cheers.
> Joshua
>
> The following changes since commit 8f348ccad083d6c02c200652ff6295e701e88f0d:
>
>    coreutils: ensure --color works so DEPEND on libcap (2011-12-24 10:05:35 +0000)
>
> are available in the git repository at:
>    git://git.openembedded.org/openembedded-core-contrib josh/devices
>    http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=josh/devices
>
> Joshua Lock (2):
>    alsa-state: add alsa-state from oe classic
>    task-base: add alsa-state to task-base-alsa
>
>   meta/recipes-bsp/alsa-state/alsa-state.bb          |   57 ++++++++++++++++++++
>   meta/recipes-bsp/alsa-state/alsa-state/alsa-state  |   29 ++++++++++
>   meta/recipes-bsp/alsa-state/alsa-state/asound.conf |   12 ++++
>   .../recipes-bsp/alsa-state/alsa-state/asound.state |    1 +
>   meta/recipes-core/tasks/task-base.bb               |    5 +-
>   5 files changed, 102 insertions(+), 2 deletions(-)
>   create mode 100644 meta/recipes-bsp/alsa-state/alsa-state.bb
>   create mode 100755 meta/recipes-bsp/alsa-state/alsa-state/alsa-state
>   create mode 100644 meta/recipes-bsp/alsa-state/alsa-state/asound.conf
>   create mode 100644 meta/recipes-bsp/alsa-state/alsa-state/asound.state
>
Joshua Lock - Jan. 4, 2012, 12:53 a.m.
On 03/01/12 16:43, Saul Wold wrote:
> On 01/02/2012 06:26 PM, Joshua Lock wrote:
>> Please review the following changes for suitability for inclusion. If
>> you have
>> any objections or suggestions for improvement, please respond to the
>> patches. If
>> you agree with the changes, please provide your Acked-by.
>>
>> The small series following introduces the alsa-state recipe from
>> oe-classic.
>> The reason for doing so is to remove the requirement for recipes like the
>> beagleboard-audio recipe in meta-yocto, which ensures the beagleboards
>> sound
>> device has the volume turned up.
>>
>> Long term I'd like to implement something more generic for handling
>> device quirks,
>> but alsa-state is a simple fix for an immediate need that should
>> standardise how
>> alsa configuration is handled in layers.
>>
> Will this address the similar issue that the n450-audio recipe does in
> the meta-intel layer? The n450 seems to use amixer and not alsactl.

That's the intent. The beagleboard-audio recipe in meta-yocto also uses 
amixer not alsactl but alsactl and the alsa-state recipe offers more 
functionality IMHO (and fewer dependencies iirc).

>
> And if so, can you provide a patch for meta-intel?

Can do, I've already got one for meta-yocto prepared but was waiting for 
some C's before submitting.

Joshua