Patchwork procps: raise update-alternatives priority

login
register
mail settings
Submitter Koen Kooi
Date Dec. 31, 2011, 4:04 p.m.
Message ID <1325347496-9980-1-git-send-email-koen@dominion.thruhere.net>
Download mbox | patch
Permalink /patch/17923/
State Accepted
Commit f1b2d49d0cc6f1b75f0870941d8c7ce742378d4d
Headers show

Comments

Koen Kooi - Dec. 31, 2011, 4:04 p.m.
This fixes a problem with the uptime utility:

root@beagleboneA3-0088:/var/lib/cloud9# busybox uptime
 16:00:17 up 2 days,  6:46,  load average: 0.14, 0.04, 0.05
root@beagleboneA3-0088:/var/lib/cloud9# uptime.procps
 16:00:22 up 2 days,  6:46,  1 user,  load average: 0.14, 0.05, 0.06
root@beagleboneA3-0088:/var/lib/cloud9# uptime.coreutils
 16:00pm  up 4382 days 15:58,  1 user,  load average: 0.13, 0.05, 0.05
root@beagleboneA3-0088:/var/lib/cloud9# ls /usr/bin/uptime -la
lrwxrwxrwx 1 root root 16 Dec 26 08:56 /usr/bin/uptime -> uptime.coreutils

Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
---
 meta/recipes-extended/procps/procps_3.2.8.bb |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Otavio Salvador - Dec. 31, 2011, 8:13 p.m.
On Sat, Dec 31, 2011 at 14:04, Koen Kooi <koen@dominion.thruhere.net> wrote:

> This fixes a problem with the uptime utility:
>

This fixes nothing; this is a workaround.

It would be better to find why this fails instead of changing it.
Koen Kooi - Dec. 31, 2011, 9:58 p.m.
Op 31 dec. 2011, om 21:13 heeft Otavio Salvador het volgende geschreven:

> On Sat, Dec 31, 2011 at 14:04, Koen Kooi <koen@dominion.thruhere.net> wrote:
> This fixes a problem with the uptime utility:
> 
> This fixes nothing; this is a workaround.

And it's exactly what u-a is for: selecting a better alternative
Saul Wold - Jan. 3, 2012, 10:22 p.m.
On 12/31/2011 08:04 AM, Koen Kooi wrote:
> This fixes a problem with the uptime utility:
>
> root@beagleboneA3-0088:/var/lib/cloud9# busybox uptime
>   16:00:17 up 2 days,  6:46,  load average: 0.14, 0.04, 0.05
> root@beagleboneA3-0088:/var/lib/cloud9# uptime.procps
>   16:00:22 up 2 days,  6:46,  1 user,  load average: 0.14, 0.05, 0.06
> root@beagleboneA3-0088:/var/lib/cloud9# uptime.coreutils
>   16:00pm  up 4382 days 15:58,  1 user,  load average: 0.13, 0.05, 0.05
> root@beagleboneA3-0088:/var/lib/cloud9# ls /usr/bin/uptime -la
> lrwxrwxrwx 1 root root 16 Dec 26 08:56 /usr/bin/uptime ->  uptime.coreutils
>
> Signed-off-by: Koen Kooi<koen@dominion.thruhere.net>
> ---
>   meta/recipes-extended/procps/procps_3.2.8.bb |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-extended/procps/procps_3.2.8.bb b/meta/recipes-extended/procps/procps_3.2.8.bb
> index d989955..6a41ccd 100644
> --- a/meta/recipes-extended/procps/procps_3.2.8.bb
> +++ b/meta/recipes-extended/procps/procps_3.2.8.bb
> @@ -1,12 +1,12 @@
>   require procps.inc
>
> -PR = "r3"
> +PR = "r4"
>
>   inherit update-alternatives
>
>   ALTERNATIVE_LINKS = "${bindir}/top ${bindir}/uptime ${bindir}/free ${bindir}/pkill ${bindir}/pmap \
>                        ${base_bindir}/kill ${base_sbindir}/sysctl ${base_bindir}/ps"
> -ALTERNATIVE_PRIORITY = "90"
> +ALTERNATIVE_PRIORITY = "110"
>
>   SRC_URI += "file://procmodule.patch \
>               file://psmodule.patch \

Merged to OE-Core.

Is there a bug filed against coreutils uptime?

Thanks
Sau!
Koen Kooi - Jan. 3, 2012, 11:16 p.m.
Op 3 jan. 2012, om 23:22 heeft Saul Wold het volgende geschreven:

> On 12/31/2011 08:04 AM, Koen Kooi wrote:
>> This fixes a problem with the uptime utility:
>> 
>> root@beagleboneA3-0088:/var/lib/cloud9# busybox uptime
>>  16:00:17 up 2 days,  6:46,  load average: 0.14, 0.04, 0.05
>> root@beagleboneA3-0088:/var/lib/cloud9# uptime.procps
>>  16:00:22 up 2 days,  6:46,  1 user,  load average: 0.14, 0.05, 0.06
>> root@beagleboneA3-0088:/var/lib/cloud9# uptime.coreutils
>>  16:00pm  up 4382 days 15:58,  1 user,  load average: 0.13, 0.05, 0.05
>> root@beagleboneA3-0088:/var/lib/cloud9# ls /usr/bin/uptime -la
>> lrwxrwxrwx 1 root root 16 Dec 26 08:56 /usr/bin/uptime ->  uptime.coreutils
>> 
>> Signed-off-by: Koen Kooi<koen@dominion.thruhere.net>
>> ---
>>  meta/recipes-extended/procps/procps_3.2.8.bb |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/meta/recipes-extended/procps/procps_3.2.8.bb b/meta/recipes-extended/procps/procps_3.2.8.bb
>> index d989955..6a41ccd 100644
>> --- a/meta/recipes-extended/procps/procps_3.2.8.bb
>> +++ b/meta/recipes-extended/procps/procps_3.2.8.bb
>> @@ -1,12 +1,12 @@
>>  require procps.inc
>> 
>> -PR = "r3"
>> +PR = "r4"
>> 
>>  inherit update-alternatives
>> 
>>  ALTERNATIVE_LINKS = "${bindir}/top ${bindir}/uptime ${bindir}/free ${bindir}/pkill ${bindir}/pmap \
>>                       ${base_bindir}/kill ${base_sbindir}/sysctl ${base_bindir}/ps"
>> -ALTERNATIVE_PRIORITY = "90"
>> +ALTERNATIVE_PRIORITY = "110"
>> 
>>  SRC_URI += "file://procmodule.patch \
>>              file://psmodule.patch \
> 
> Merged to OE-Core.
> 
> Is there a bug filed against coreutils uptime?

Not yet, but systemd suffers from the same, I'm going to look into it after the holidays and pester Karel and Lennart, they are both in #systemd :)

Patch

diff --git a/meta/recipes-extended/procps/procps_3.2.8.bb b/meta/recipes-extended/procps/procps_3.2.8.bb
index d989955..6a41ccd 100644
--- a/meta/recipes-extended/procps/procps_3.2.8.bb
+++ b/meta/recipes-extended/procps/procps_3.2.8.bb
@@ -1,12 +1,12 @@ 
 require procps.inc
 
-PR = "r3"
+PR = "r4"
 
 inherit update-alternatives
 
 ALTERNATIVE_LINKS = "${bindir}/top ${bindir}/uptime ${bindir}/free ${bindir}/pkill ${bindir}/pmap \
                      ${base_bindir}/kill ${base_sbindir}/sysctl ${base_bindir}/ps"
-ALTERNATIVE_PRIORITY = "90"
+ALTERNATIVE_PRIORITY = "110"
 
 SRC_URI += "file://procmodule.patch \
             file://psmodule.patch \