Patchwork [PATCHv2,2011.03-maintenance] binutils_2.20.1 fixed md5 and sha256 sum

login
register
mail settings
Submitter Adriano Pallavicino
Date Dec. 31, 2011, 11:44 a.m.
Message ID <1325331840-23575-1-git-send-email-adriano.pallavicino@gmail.com>
Download mbox | patch
Permalink /patch/17921/
State Not Applicable
Headers show

Comments

Adriano Pallavicino - Dec. 31, 2011, 11:44 a.m.
Signed-off-by: Adriano Pallavicino <adriano.pallavicino@gmail.com>

Fixed md5sum and sha256sum
---
 recipes/binutils/binutils_2.20.1.bb |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Frans Meulenbroeks - Dec. 31, 2011, 12:59 p.m.
2011/12/31 Adriano Pallavicino <adrianopallavicino@gmail.com>

> Signed-off-by: Adriano Pallavicino <adriano.pallavicino@gmail.com>
>
> Fixed md5sum and sha256sum
> ---
>  recipes/binutils/binutils_2.20.1.bb |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/recipes/binutils/binutils_2.20.1.bb b/recipes/binutils/
> binutils_2.20.1.bb
> index 5154e2d..f40b676 100644
> --- a/recipes/binutils/binutils_2.20.1.bb
> +++ b/recipes/binutils/binutils_2.20.1.bb
> @@ -24,8 +24,8 @@ SRC_URI_append_nios2 =" \
>        file://binutils-nios2.patch \
>        "
>
> -SRC_URI[tarball.sha256sum] =
> "228b84722d87e88e7fdd36869e590e649ab523a0800a7d53df906498afe6f6f8"
> -SRC_URI[tarball.md5sum] = "9cdfb9d6ec0578c166d3beae5e15c4e5"
> +SRC_URI[tarball.sha256sum] =
> "71d37c96451333c5c0b84b170169fdcb138bbb27397dc06281905d9717c8ed64"
> +SRC_URI[tarball.md5sum] = "2b9dc8f2b7dbd5ec5992c6e29de0b764"
>
>  # powerpc patches
>  SRC_URI += "\
> --
> 1.7.4.1
>

As told on IRC, I'd suggest to compare against the version in master.
THere the issue was fixed using this patch:
http://cgit.openembedded.org/openembedded/commit/recipes/binutils/binutils_2.20.1.bb?id=262f9eb0f046cd77d041a9dcb055700c5ab6601b

Note that this also patches SRC_URI.
Guess the patch above should also go into master.

Did you by any chance download your binutils tarball manually?

Best regards, Frans
Adriano Pallavicino - Dec. 31, 2011, 2:25 p.m.
I can correctly download it from here
ftp://ftp.gnu.org/gnu/binutils/binutils-2.20.1.tar.bz2 (as indicated inside
bb file). The problem is only in sha256 and md5 sum. I'm using
2011.03-maintenance. I can desume that this branch is only for maintaining
2011.03 release. If someone decided to use binutils 2.20.1 why should I
introduce the new 2.20.1a from master? All the things are tested with
2.20.1 and imho the branch 2011.03-maintenance must continue to utilize
them.
Of course, if maintainers consider this patch useless, I'll remove it from
here.

2011/12/31 Frans Meulenbroeks <fransmeulenbroeks@gmail.com>

> 2011/12/31 Adriano Pallavicino <adrianopallavicino@gmail.com>
>
> > Signed-off-by: Adriano Pallavicino <adriano.pallavicino@gmail.com>
> >
> > Fixed md5sum and sha256sum
> > ---
> >  recipes/binutils/binutils_2.20.1.bb |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/recipes/binutils/binutils_2.20.1.bb b/recipes/binutils/
> > binutils_2.20.1.bb
> > index 5154e2d..f40b676 100644
> > --- a/recipes/binutils/binutils_2.20.1.bb
> > +++ b/recipes/binutils/binutils_2.20.1.bb
> > @@ -24,8 +24,8 @@ SRC_URI_append_nios2 =" \
> >        file://binutils-nios2.patch \
> >        "
> >
> > -SRC_URI[tarball.sha256sum] =
> > "228b84722d87e88e7fdd36869e590e649ab523a0800a7d53df906498afe6f6f8"
> > -SRC_URI[tarball.md5sum] = "9cdfb9d6ec0578c166d3beae5e15c4e5"
> > +SRC_URI[tarball.sha256sum] =
> > "71d37c96451333c5c0b84b170169fdcb138bbb27397dc06281905d9717c8ed64"
> > +SRC_URI[tarball.md5sum] = "2b9dc8f2b7dbd5ec5992c6e29de0b764"
> >
> >  # powerpc patches
> >  SRC_URI += "\
> > --
> > 1.7.4.1
> >
>
> As told on IRC, I'd suggest to compare against the version in master.
> THere the issue was fixed using this patch:
>
> http://cgit.openembedded.org/openembedded/commit/recipes/binutils/binutils_2.20.1.bb?id=262f9eb0f046cd77d041a9dcb055700c5ab6601b
>
> Note that this also patches SRC_URI.
> Guess the patch above should also go into master.
>
> Did you by any chance download your binutils tarball manually?
>
> Best regards, Frans
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
Frans Meulenbroeks - Dec. 31, 2011, 2:48 p.m.
Tom,

I feel it is a good plan to resolve this problem by adding
http://cgit.openembedded.org/openembedded/commit/?id=262f9eb0f046cd77d041a9dcb055700c5ab6601bto
the maintenance branch
This makes things buildable again.
As you are the commiter of the above patch, I feel you are in a better
position than me to judge this is ok.
However with the patch at least the angstrom people get the problem
resolved (minimal uses 2.21 and requries a different patch)

Best regards, Frans.

2011/12/31 Adriano Pallavicino <adrianopallavicino@gmail.com>

> I can correctly download it from here
> ftp://ftp.gnu.org/gnu/binutils/binutils-2.20.1.tar.bz2 (as indicated
> inside
> bb file). The problem is only in sha256 and md5 sum. I'm using
> 2011.03-maintenance. I can desume that this branch is only for maintaining
> 2011.03 release. If someone decided to use binutils 2.20.1 why should I
> introduce the new 2.20.1a from master? All the things are tested with
> 2.20.1 and imho the branch 2011.03-maintenance must continue to utilize
> them.
> Of course, if maintainers consider this patch useless, I'll remove it from
> here.
>
> 2011/12/31 Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
>
> > 2011/12/31 Adriano Pallavicino <adrianopallavicino@gmail.com>
> >
> > > Signed-off-by: Adriano Pallavicino <adriano.pallavicino@gmail.com>
> > >
> > > Fixed md5sum and sha256sum
> > > ---
> > >  recipes/binutils/binutils_2.20.1.bb |    4 ++--
> > >  1 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/recipes/binutils/binutils_2.20.1.bb b/recipes/binutils/
> > > binutils_2.20.1.bb
> > > index 5154e2d..f40b676 100644
> > > --- a/recipes/binutils/binutils_2.20.1.bb
> > > +++ b/recipes/binutils/binutils_2.20.1.bb
> > > @@ -24,8 +24,8 @@ SRC_URI_append_nios2 =" \
> > >        file://binutils-nios2.patch \
> > >        "
> > >
> > > -SRC_URI[tarball.sha256sum] =
> > > "228b84722d87e88e7fdd36869e590e649ab523a0800a7d53df906498afe6f6f8"
> > > -SRC_URI[tarball.md5sum] = "9cdfb9d6ec0578c166d3beae5e15c4e5"
> > > +SRC_URI[tarball.sha256sum] =
> > > "71d37c96451333c5c0b84b170169fdcb138bbb27397dc06281905d9717c8ed64"
> > > +SRC_URI[tarball.md5sum] = "2b9dc8f2b7dbd5ec5992c6e29de0b764"
> > >
> > >  # powerpc patches
> > >  SRC_URI += "\
> > > --
> > > 1.7.4.1
> > >
> >
> > As told on IRC, I'd suggest to compare against the version in master.
> > THere the issue was fixed using this patch:
> >
> >
> http://cgit.openembedded.org/openembedded/commit/recipes/binutils/binutils_2.20.1.bb?id=262f9eb0f046cd77d041a9dcb055700c5ab6601b
> >
> > Note that this also patches SRC_URI.
> > Guess the patch above should also go into master.
> >
> > Did you by any chance download your binutils tarball manually?
> >
> > Best regards, Frans
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
> >
>
>
>
> --
> Adriano Pallavicino
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
Paul Menzel - Jan. 1, 2012, 9:51 a.m.
Dear Adriano,


Am Samstag, den 31.12.2011, 15:25 +0100 schrieb Adriano Pallavicino:
> I can correctly download it from here
> ftp://ftp.gnu.org/gnu/binutils/binutils-2.20.1.tar.bz2 (as indicated inside
> bb file). The problem is only in sha256 and md5 sum. I'm using
> 2011.03-maintenance. I can desume that this branch is only for maintaining
> 2011.03 release. If someone decided to use binutils 2.20.1 why should I
> introduce the new 2.20.1a from master? All the things are tested with
> 2.20.1 and imho the branch 2011.03-maintenance must continue to utilize
> them.

please read the commit messages and the included links in the commit
messages for `binutils` in OpenEmbedded master branch. The link you
posted is [1] is just a symlink to 2.20.1a [2]. Try it out with `wget`.

The problem as mentioned in some commit messages was that some source
files were not included in 2.20.1 and therefore upstream had to update
that.

> Of course, if maintainers consider this patch useless, I'll remove it from
> here.


Thanks,

Paul


[1] ftp://ftp.gnu.org/gnu/binutils/binutils-2.20.1.tar.bz2
[2] ftp://ftp.gnu.org/gnu/binutils/binutils-2.20.1a.tar.bz2

Patch

diff --git a/recipes/binutils/binutils_2.20.1.bb b/recipes/binutils/binutils_2.20.1.bb
index 5154e2d..f40b676 100644
--- a/recipes/binutils/binutils_2.20.1.bb
+++ b/recipes/binutils/binutils_2.20.1.bb
@@ -24,8 +24,8 @@  SRC_URI_append_nios2 =" \
 	file://binutils-nios2.patch \
 	"
 
-SRC_URI[tarball.sha256sum] = "228b84722d87e88e7fdd36869e590e649ab523a0800a7d53df906498afe6f6f8"
-SRC_URI[tarball.md5sum] = "9cdfb9d6ec0578c166d3beae5e15c4e5"
+SRC_URI[tarball.sha256sum] = "71d37c96451333c5c0b84b170169fdcb138bbb27397dc06281905d9717c8ed64"
+SRC_URI[tarball.md5sum] = "2b9dc8f2b7dbd5ec5992c6e29de0b764"
 
 # powerpc patches
 SRC_URI += "\