diff mbox series

meta/classes-global: remove package_tar.bbclass

Message ID 20230104152958.13559-1-michael.opdenacker@bootlin.com
State Accepted, archived
Commit 90ce19122802a16e6067f3a2ce3447acf1070fe5
Headers show
Series meta/classes-global: remove package_tar.bbclass | expand

Commit Message

Michael Opdenacker Jan. 4, 2023, 3:29 p.m. UTC 
From: Michael Opdenacker <michael.opdenacker@bootlin.com>

Remove package_tar.bbclass, which is no longer in use in oe-core
and meta-oe, and which the document reports as broken and unsupported.

Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
---
 meta/classes-global/package_tar.bbclass | 77 -------------------------
 1 file changed, 77 deletions(-)
 delete mode 100644 meta/classes-global/package_tar.bbclass

Comments

Richard Purdie Jan. 6, 2023, 5:36 p.m. UTC | #1 
On Wed, 2023-01-04 at 16:29 +0100, Michael Opdenacker via
lists.openembedded.org wrote:
> From: Michael Opdenacker <michael.opdenacker@bootlin.com>
> 
> Remove package_tar.bbclass, which is no longer in use in oe-core
> and meta-oe, and which the document reports as broken and unsupported.
> 
> Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
> ---
>  meta/classes-global/package_tar.bbclass | 77 -------------------------
>  1 file changed, 77 deletions(-)
>  delete mode 100644 meta/classes-global/package_tar.bbclass

We've kept this around as whilst it isn't useful to an enduser, it
could be the basis of an image class which doesn't use package
management which is something I've wondered about adding.

We should certainly be telling users not to use it but I'm not sure I
want to delete it.

Cheers,

Richad
diff mbox series

Patch

diff --git a/meta/classes-global/package_tar.bbclass b/meta/classes-global/package_tar.bbclass
deleted file mode 100644
index de995f9747..0000000000
--- a/meta/classes-global/package_tar.bbclass
+++ /dev/null
@@ -1,77 +0,0 @@ 
-#
-# Copyright OpenEmbedded Contributors
-#
-# SPDX-License-Identifier: MIT
-#
-
-inherit package
-
-IMAGE_PKGTYPE ?= "tar"
-
-python do_package_tar () {
-    import subprocess
-
-    oldcwd = os.getcwd()
-
-    workdir = d.getVar('WORKDIR')
-    if not workdir:
-        bb.error("WORKDIR not defined, unable to package")
-        return
-
-    outdir = d.getVar('DEPLOY_DIR_TAR')
-    if not outdir:
-        bb.error("DEPLOY_DIR_TAR not defined, unable to package")
-        return
-
-    dvar = d.getVar('D')
-    if not dvar:
-        bb.error("D not defined, unable to package")
-        return
-
-    packages = d.getVar('PACKAGES')
-    if not packages:
-        bb.debug(1, "PACKAGES not defined, nothing to package")
-        return
-
-    pkgdest = d.getVar('PKGDEST')
-
-    bb.utils.mkdirhier(outdir)
-    bb.utils.mkdirhier(dvar)
-
-    for pkg in packages.split():
-        localdata = bb.data.createCopy(d)
-        root = "%s/%s" % (pkgdest, pkg)
-
-        overrides = localdata.getVar('OVERRIDES', False)
-        localdata.setVar('OVERRIDES', '%s:%s' % (overrides, pkg))
-
-        bb.utils.mkdirhier(root)
-        basedir = os.path.dirname(root)
-        tarfn = localdata.expand("${DEPLOY_DIR_TAR}/${PKG}-${PKGV}-${PKGR}.tar.gz")
-        os.chdir(root)
-        dlist = os.listdir(root)
-        if not dlist:
-            bb.note("Not creating empty archive for %s-%s-%s" % (pkg, localdata.getVar('PKGV'), localdata.getVar('PKGR')))
-            continue
-        args = "tar -cz --exclude=CONTROL --exclude=DEBIAN -f".split()
-        ret = subprocess.call(args + [tarfn] + dlist)
-        if ret != 0:
-            bb.error("Creation of tar %s failed." % tarfn)
-
-    os.chdir(oldcwd)
-}
-
-python () {
-    if d.getVar('PACKAGES') != '':
-        deps = ' tar-native:do_populate_sysroot virtual/fakeroot-native:do_populate_sysroot'
-        d.appendVarFlag('do_package_write_tar', 'depends', deps)
-        d.setVarFlag('do_package_write_tar', 'fakeroot', "1")
-}
-
-
-python do_package_write_tar () {
-    bb.build.exec_func("read_subpackage_metadata", d)
-    bb.build.exec_func("do_package_tar", d)
-}
-do_package_write_tar[dirs] = "${D}"
-addtask package_write_tar before do_build after do_packagedata do_package