Patchwork [1/2] u-boot: improved DESCRIPTION, fixed HOMEPAGE

login
register
mail settings
Submitter Frans Meulenbroeks
Date Dec. 27, 2011, 8:35 p.m.
Message ID <1325018118-30223-1-git-send-email-fransmeulenbroeks@gmail.com>
Download mbox | patch
Permalink /patch/17679/
State New
Headers show

Comments

Frans Meulenbroeks - Dec. 27, 2011, 8:35 p.m.
HOMEPAGE pointed to an sf.net page that said that the
page did not exist any more and after that it redirected
to the denx.de page; updated HOMEPAGE to point to that page
Also improved the description to use the official capitalisation

Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
---
 meta/recipes-bsp/u-boot/u-boot.inc |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Saul Wold - Dec. 27, 2011, 9:59 p.m.
On 12/27/2011 12:35 PM, Frans Meulenbroeks wrote:
> HOMEPAGE pointed to an sf.net page that said that the
> page did not exist any more and after that it redirected
> to the denx.de page; updated HOMEPAGE to point to that page
> Also improved the description to use the official capitalisation
>
> Signed-off-by: Frans Meulenbroeks<fransmeulenbroeks@gmail.com>
> ---
>   meta/recipes-bsp/u-boot/u-boot.inc |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/meta/recipes-bsp/u-boot/u-boot.inc b/meta/recipes-bsp/u-boot/u-boot.inc
> index 544acd2..a3f50bc 100644
> --- a/meta/recipes-bsp/u-boot/u-boot.inc
> +++ b/meta/recipes-bsp/u-boot/u-boot.inc
> @@ -1,3 +1,5 @@
> +DESCRIPTION = "U-Boot - the Universal Boot Loader"
> +HOMEPAGE = "http://www.denx.de/wiki/U-Boot/WebHome"
>   DESCRIPTION = "U-boot bootloader"
>   HOMEPAGE = "http://u-boot.sf.net"
>   SECTION = "bootloaders"
Should you be deleting the older DESCRIPTION and HOMEPAGE?

Sau!
NiQingliang - Dec. 28, 2011, 12:48 a.m.
I have just done a seperate env tools bb for my project, but use the
config file to assign the env size and address (which is generated on
booting from /proc/mtd). 

in the fdt, the u-boot env has a seperate partition identified by it's
name "u-boot environment"

and have some problem:
1. the fw_printenv will exit with 0 even though can't read the env (CRC
error).

2. the default env vars in fw_printenv(used when CRC error) are not same
as it in the u-boot.

On Wed, 2011-12-28 at 04:35 +0800, Frans Meulenbroeks wrote:
> HOMEPAGE pointed to an sf.net page that said that the
> page did not exist any more and after that it redirected
> to the denx.de page; updated HOMEPAGE to point to that page
> Also improved the description to use the official capitalisation
> 
> Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
> ---
>  meta/recipes-bsp/u-boot/u-boot.inc |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/meta/recipes-bsp/u-boot/u-boot.inc b/meta/recipes-bsp/u-boot/u-boot.inc
> index 544acd2..a3f50bc 100644
> --- a/meta/recipes-bsp/u-boot/u-boot.inc
> +++ b/meta/recipes-bsp/u-boot/u-boot.inc
> @@ -1,3 +1,5 @@
> +DESCRIPTION = "U-Boot - the Universal Boot Loader"
> +HOMEPAGE = "http://www.denx.de/wiki/U-Boot/WebHome"
>  DESCRIPTION = "U-boot bootloader"
>  HOMEPAGE = "http://u-boot.sf.net"
>  SECTION = "bootloaders"
> --
> 1.7.8.1
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Frans Meulenbroeks - Dec. 28, 2011, 10:22 a.m.
2011/12/28 Ni Qingliang <niqingliang@insigma.com.cn>

> I have just done a seperate env tools bb for my project, but use the
> config file to assign the env size and address (which is generated on
> booting from /proc/mtd).
>
> in the fdt, the u-boot env has a seperate partition identified by it's
> name "u-boot environment"
>
> and have some problem:
> 1. the fw_printenv will exit with 0 even though can't read the env (CRC
> error).
>

Apparently the author of the program did not consider this as an error.
See tools/env/fw_env.c


>
> 2. the default env vars in fw_printenv(used when CRC error) are not same
> as it in the u-boot.
>

If I recall correctly this is addressed in the 2nd patch I posted.
From memory:
Issue is that fw_env.h redefines CONFIG_BOOTCOMMAND. This gives you a
different boot command.
By putting #ifdef's around it the default one is taken

Enjoy!
Frans

Patch

diff --git a/meta/recipes-bsp/u-boot/u-boot.inc b/meta/recipes-bsp/u-boot/u-boot.inc
index 544acd2..a3f50bc 100644
--- a/meta/recipes-bsp/u-boot/u-boot.inc
+++ b/meta/recipes-bsp/u-boot/u-boot.inc
@@ -1,3 +1,5 @@ 
+DESCRIPTION = "U-Boot - the Universal Boot Loader"
+HOMEPAGE = "http://www.denx.de/wiki/U-Boot/WebHome"
 DESCRIPTION = "U-boot bootloader"
 HOMEPAGE = "http://u-boot.sf.net"
 SECTION = "bootloaders"