From patchwork Fri Dec 23 16:23:57 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: buildhistory: avoid quoting issues with the layer list for build-id Date: Fri, 23 Dec 2011 16:23:57 -0000 From: Christopher Larson X-Patchwork-Id: 17579 Message-Id: <3443259C5BCC4C21B2D92CD4C4B9AC73@gmail.com> To: Patches and discussions about the oe-core layer The layer list is multiline, and includes quotes, so including it within quotes is problematic, particularly if the revision includes characters which are not valid outside of a quoted string in shell. To reproduce this failure: do a build with an scm layer not on a branch. Signed-off-by: Christopher Larson Acked-by: Paul Eggleton --- meta/classes/buildhistory.bbclass | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/meta/classes/buildhistory.bbclass b/meta/classes/buildhistory.bbclass index 39f5ff6..6a08db4 100644 --- a/meta/classes/buildhistory.bbclass +++ b/meta/classes/buildhistory.bbclass @@ -325,7 +325,10 @@ buildhistory_get_imageinfo() { # Add some configuration information echo "${MACHINE}: ${IMAGE_BASENAME} configured for ${DISTRO} ${DISTRO_VERSION}" > ${BUILDHISTORY_DIR_IMAGE}/build-id - echo "${@buildhistory_get_layers(d)}" >> ${BUILDHISTORY_DIR_IMAGE}/build-id + + cat >> ${BUILDHISTORY_DIR_IMAGE}/build-id <