Patchwork [9/9] udev: split utilities onto udev-utils

login
register
mail settings
Submitter Otavio Salvador
Date Dec. 20, 2011, 7:04 p.m.
Message ID <444cb0c0c2b99cac90d3b9964d44021c08b1a774.1324407759.git.otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/17337/
State New
Headers show

Comments

Otavio Salvador - Dec. 20, 2011, 7:04 p.m.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 meta/recipes-core/udev/udev.inc    |    6 +++++-
 meta/recipes-core/udev/udev_164.bb |    2 +-
 2 files changed, 6 insertions(+), 2 deletions(-)
Joshua Lock - Dec. 20, 2011, 8:03 p.m.
On 20/12/11 11:04, Otavio Salvador wrote:
>  FILES_${PN} += "${libexecdir} ${libdir}/ConsoleKit"
> +RRECOMMENDS_${PN} += "udev-utils"
> +

<snip>

> +FILES_udev-utils = "${bindir}/udevinfo ${bindir}/udevtest ${base_sbindir}/udevadm"
> +

The sysvinit scripts for udev itself, and the live-install image call
the udevadm binary. Is RRECOMMENDS adequate to ensure it's available?

My reading of the documentation[1] leads me to believe so but I'm not
sure if all of the package back-ends support this properly. Can you
share which package back-end(s) you tested with?

Cheers,
Joshua

1.
http://www.yoctoproject.org/docs/current/poky-ref-manual/poky-ref-manual.html#var-RRECOMMENDS
Otavio Salvador - Dec. 20, 2011, 8:09 p.m.
On Tue, Dec 20, 2011 at 18:03, Joshua Lock <josh@linux.intel.com> wrote:

> The sysvinit scripts for udev itself, and the live-install image call
> the udevadm binary. Is RRECOMMENDS adequate to ensure it's available?
>

For opkg it works fine.

I can imagine if someone is doing  a quite specific image then it could be
removed; but obviously initscript would be broken on this case but if
he/she adds it for BAD_RECOMMENDATIONS then he/she knows what he/she is
doing.

Patch

diff --git a/meta/recipes-core/udev/udev.inc b/meta/recipes-core/udev/udev.inc
index 7b6ed64..8343eaf 100644
--- a/meta/recipes-core/udev/udev.inc
+++ b/meta/recipes-core/udev/udev.inc
@@ -36,7 +36,7 @@  libexecdir = "${base_libdir}/udev"
 EXTRA_OECONF = "--disable-introspection --with-rootlibdir=${base_libdir} \
                 --with-pci-ids-path=${datadir}/pci.ids"
 
-PACKAGES =+ "udev-acl udev-consolekit"
+PACKAGES =+ "udev-acl udev-consolekit udev-utils"
 PACKAGES =+ "udev-cache libudev libudev-dev libudev-dbg"
 PACKAGES =+ "libgudev libgudev-dev libgudev-dbg"
 
@@ -47,6 +47,8 @@  INITSCRIPT_NAME_udev-cache = "udev-cache"
 INITSCRIPT_PARAMS_udev-cache = "start 36 S ."
 
 FILES_${PN} += "${libexecdir} ${libdir}/ConsoleKit"
+RRECOMMENDS_${PN} += "udev-utils"
+
 FILES_${PN}-dbg += "${libexecdir}/.debug"
 FILES_${PN}-dev = "${datadir}/pkgconfig/udev.pc"
 FILES_libudev = "${base_libdir}/libudev.so.*"
@@ -61,6 +63,8 @@  FILES_udev-cache = "${sysconfdir}/init.d/udev-cache ${sysconfdir}/default/udev-c
 
 FILES_udev-acl = "${base_libdir}/udev/udev-acl ${base_libdir}/udev/rules.d/70-acl.rules"
 
+FILES_udev-utils = "${bindir}/udevinfo ${bindir}/udevtest ${base_sbindir}/udevadm"
+
 RDEPENDS_udev-consolekit += "udev-acl"
 FILES_udev-consolekit = "${libdir}/ConsoleKit"
 
diff --git a/meta/recipes-core/udev/udev_164.bb b/meta/recipes-core/udev/udev_164.bb
index b993a13..d661044 100644
--- a/meta/recipes-core/udev/udev_164.bb
+++ b/meta/recipes-core/udev/udev_164.bb
@@ -1,6 +1,6 @@ 
 include udev.inc
 
-PR = "r11"
+PR = "r12"
 
 SRC_URI += "file://udev-166-v4l1-1.patch"