Patchwork [bitbake-devel] Joshua Lock : ui/crumbs/runningbuild: handle InvalidTask events

login
mail settings
Submitter git@git.openembedded.org
Date Dec. 20, 2011, 1:21 p.m.
Message ID <20111220132128.4520210333@opal>
Download mbox | patch
Permalink /patch/17301/
State Not Applicable
Headers show

Comments

git@git.openembedded.org - Dec. 20, 2011, 1:21 p.m.
Module: bitbake.git
Branch: master
Commit: 540ba78075bd525776aa23bf38bee66350c66534
URL:    http://git.openembedded.org/?p=bitbake.git&a=commit;h=540ba78075bd525776aa23bf38bee66350c66534

Author: Joshua Lock <josh@linux.intel.com>
Date:   Tue Dec 13 14:45:41 2011 -0800

ui/crumbs/runningbuild: handle InvalidTask events

The knotty UI just ignores these and so should RunningBuild, if these events
aren't handled the UI appears to hang.

Fixes [YOCTO #1665]

Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

---

 lib/bb/ui/crumbs/runningbuild.py |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

Patch

diff --git a/lib/bb/ui/crumbs/runningbuild.py b/lib/bb/ui/crumbs/runningbuild.py
index 509590a..4f609fc 100644
--- a/lib/bb/ui/crumbs/runningbuild.py
+++ b/lib/bb/ui/crumbs/runningbuild.py
@@ -179,6 +179,10 @@  class RunningBuild (gobject.GObject):
             # that we need to attach to a task.
             self.tasks_to_iter[(package, task)] = i
 
+        # If we don't handle these the GUI does not proceed
+        elif isinstance(event, bb.build.TaskInvalid):
+            return
+
         elif isinstance(event, bb.build.TaskBase):
             current = self.tasks_to_iter[(package, task)]
             parent = self.tasks_to_iter[(package, None)]