Patchwork valgrind: add powerpc into the compatible host list

login
register
mail settings
Submitter Zhenhua Luo
Date Dec. 19, 2011, 10:12 a.m.
Message ID <1324289521-10140-1-git-send-email-b19537@freescale.com>
Download mbox | patch
Permalink /patch/17233/
State Superseded
Headers show

Comments

Zhenhua Luo - Dec. 19, 2011, 10:12 a.m.
From: Zhenhua Luo <b19537@freescale.com>

    add powerpc/powerpc64/ppc/ppc64 in COMPATIBLE_HOST variable

Signed-off-by: Zhenhua Luo <b19537@freescale.com>
---
 meta/recipes-devtools/valgrind/valgrind_3.6.1.bb |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Koen Kooi - Dec. 19, 2011, 10:29 a.m.
Op 19 dec. 2011, om 11:12 heeft <b19537@freescale.com> <b19537@freescale.com> het volgende geschreven:

> From: Zhenhua Luo <b19537@freescale.com>
> 
>    add powerpc/powerpc64/ppc/ppc64 in COMPATIBLE_HOST variable

Since valgrind works on arm as well it might be better just to drop the COMPATIBLE_HOST, no?

regards,

Koen

> 
> Signed-off-by: Zhenhua Luo <b19537@freescale.com>
> ---
> meta/recipes-devtools/valgrind/valgrind_3.6.1.bb |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-devtools/valgrind/valgrind_3.6.1.bb b/meta/recipes-devtools/valgrind/valgrind_3.6.1.bb
> index 021caa8..c09fc41 100644
> --- a/meta/recipes-devtools/valgrind/valgrind_3.6.1.bb
> +++ b/meta/recipes-devtools/valgrind/valgrind_3.6.1.bb
> @@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=c46082167a314d785d012a244748d803 \
>                     file://include/valgrind.h;beginline=1;endline=56;md5=13a71cedba99112334d8596162aec37e \
>                     file://COPYING.DOCS;md5=8fdeb5abdb235a08e76835f8f3260215"
> DEPENDS = "virtual/libx11"
> -PR = "r1"
> +PR = "r2"
> 
> SRC_URI = "http://www.valgrind.org/downloads/valgrind-${PV}.tar.bz2 \
> 	   file://fix_issue_caused_by_ccache.patch \
> @@ -17,7 +17,7 @@ SRC_URI = "http://www.valgrind.org/downloads/valgrind-${PV}.tar.bz2 \
> SRC_URI[md5sum] = "2c3aa122498baecc9d69194057ca88f5"
> SRC_URI[sha256sum] = "49bdcc4fbcf060049b5f0dcfd8a187a6e90e0b0e57309f633b64e44430726a0e"
> 
> -COMPATIBLE_HOST = '(i.86|x86_64).*-linux'
> +COMPATIBLE_HOST = '(i.86|x86_64|powerpc|powerpc64|ppc|ppc64).*-linux'
> 
> inherit autotools
> 
> -- 
> 1.7.0.4
> 
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Zhenhua Luo - Dec. 19, 2011, 10:32 a.m.
Sure, if valgrind can work on x86, powerpc, arm, COMPATIBLE_HOST can be removed, I will post a v2 patch. 


Best Regards,

Zhenhua


> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-
> core-bounces@lists.openembedded.org] On Behalf Of Koen Kooi
> Sent: Monday, December 19, 2011 6:30 PM
> To: Patches and discussions about the oe-core layer
> Subject: Re: [OE-core] [PATCH oe-core] valgrind: add powerpc into the compatible
> host list
> 
> 
> Op 19 dec. 2011, om 11:12 heeft <b19537@freescale.com> <b19537@freescale.com>
> het volgende geschreven:
> 
> > From: Zhenhua Luo <b19537@freescale.com>
> >
> >    add powerpc/powerpc64/ppc/ppc64 in COMPATIBLE_HOST variable
> 
> Since valgrind works on arm as well it might be better just to drop the
> COMPATIBLE_HOST, no?
> 
> regards,
> 
> Koen
> 
> >
> > Signed-off-by: Zhenhua Luo <b19537@freescale.com>
> > ---
> > meta/recipes-devtools/valgrind/valgrind_3.6.1.bb |    4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta/recipes-devtools/valgrind/valgrind_3.6.1.bb
> > b/meta/recipes-devtools/valgrind/valgrind_3.6.1.bb
> > index 021caa8..c09fc41 100644
> > --- a/meta/recipes-devtools/valgrind/valgrind_3.6.1.bb
> > +++ b/meta/recipes-devtools/valgrind/valgrind_3.6.1.bb
> > @@ -7,7 +7,7 @@ LIC_FILES_CHKSUM =
> "file://COPYING;md5=c46082167a314d785d012a244748d803 \
> >
> file://include/valgrind.h;beginline=1;endline=56;md5=13a71cedba99112334d8596162a
> ec37e \
> >                     file://COPYING.DOCS;md5=8fdeb5abdb235a08e76835f8f3260215"
> > DEPENDS = "virtual/libx11"
> > -PR = "r1"
> > +PR = "r2"
> >
> > SRC_URI = "http://www.valgrind.org/downloads/valgrind-${PV}.tar.bz2 \
> > 	   file://fix_issue_caused_by_ccache.patch \ @@ -17,7 +17,7 @@
> > SRC_URI = "http://www.valgrind.org/downloads/valgrind-${PV}.tar.bz2 \
> > SRC_URI[md5sum] = "2c3aa122498baecc9d69194057ca88f5"
> > SRC_URI[sha256sum] =
> "49bdcc4fbcf060049b5f0dcfd8a187a6e90e0b0e57309f633b64e44430726a0e"
> >
> > -COMPATIBLE_HOST = '(i.86|x86_64).*-linux'
> > +COMPATIBLE_HOST = '(i.86|x86_64|powerpc|powerpc64|ppc|ppc64).*-linux'
> >
> > inherit autotools
> >
> > --
> > 1.7.0.4
> >
> >
> >
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Richard Purdie - Dec. 19, 2011, 12:26 p.m.
On Mon, 2011-12-19 at 10:32 +0000, Luo Zhenhua-B19537 wrote:
> Sure, if valgrind can work on x86, powerpc, arm, COMPATIBLE_HOST can be removed, I will post a v2 patch. 

Can someone confirm it works on mips too please?

Cheers,

Richard
Phil Blundell - Dec. 19, 2011, 1:24 p.m.
On Mon, 2011-12-19 at 10:32 +0000, Luo Zhenhua-B19537 wrote:
> Sure, if valgrind can work on x86, powerpc, arm, COMPATIBLE_HOST can be removed, I will post a v2 patch. 

That still leaves mips unsupported.  But I don't really have a problem
with removing COMPATIBLE_HOST anyway since it doesn't really add much
value for valgrind. 

p.
Zhenhua Luo - Dec. 21, 2011, 6:21 a.m.
Since nobody confirm that it works on mips, I will create a new patch to define COMPATIBLE_HOST as following, does it make sense?
	COMPATIBLE_HOST = '(i.86|x86_64|powerpc|powerpc64|ppc|ppc64|arm).*-linux'


Best Regards,

Zhenhua


> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-
> core-bounces@lists.openembedded.org] On Behalf Of Richard Purdie
> Sent: Monday, December 19, 2011 8:27 PM
> To: Patches and discussions about the oe-core layer
> Subject: Re: [OE-core] [PATCH oe-core] valgrind: add powerpc into the compatible
> host list
> 
> On Mon, 2011-12-19 at 10:32 +0000, Luo Zhenhua-B19537 wrote:
> > Sure, if valgrind can work on x86, powerpc, arm, COMPATIBLE_HOST can be
> removed, I will post a v2 patch.
> 
> Can someone confirm it works on mips too please?
> 
> Cheers,
> 
> Richard
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Richard Purdie - Dec. 21, 2011, 5:07 p.m.
On Wed, 2011-12-21 at 06:21 +0000, Luo Zhenhua-B19537 wrote:
> Since nobody confirm that it works on mips, I will create a new patch to define COMPATIBLE_HOST as following, does it make sense?
> 	COMPATIBLE_HOST = '(i.86|x86_64|powerpc|powerpc64|ppc|ppc64|arm).*-linux'

Sounds good to me.

Cheers,

Richard
Sergey Lapin - Dec. 22, 2011, 11:09 a.m.
On Wed, Dec 21, 2011 at 9:07 PM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Wed, 2011-12-21 at 06:21 +0000, Luo Zhenhua-B19537 wrote:
>> Since nobody confirm that it works on mips, I will create a new patch to define COMPATIBLE_HOST as following, does it make sense?
>>       COMPATIBLE_HOST = '(i.86|x86_64|powerpc|powerpc64|ppc|ppc64|arm).*-linux'

Does it really work on armv4/v5?

S.
Zhenhua Luo - Dec. 23, 2011, 3:15 a.m.
Can somebody confirm whether valgrind works for armv4/v5, please?  


Best Regards,

Zhenhua


> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-
> core-bounces@lists.openembedded.org] On Behalf Of Sergey Lapin
> Sent: Thursday, December 22, 2011 7:09 PM
> To: Patches and discussions about the oe-core layer
> Subject: Re: [OE-core] [PATCH oe-core] valgrind: add powerpc into the compatible
> host list
> 
> On Wed, Dec 21, 2011 at 9:07 PM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Wed, 2011-12-21 at 06:21 +0000, Luo Zhenhua-B19537 wrote:
> >> Since nobody confirm that it works on mips, I will create a new patch to
> define COMPATIBLE_HOST as following, does it make sense?
> >>       COMPATIBLE_HOST = '(i.86|x86_64|powerpc|powerpc64|ppc|ppc64|arm).*-
> linux'
> 
> Does it really work on armv4/v5?
> 
> S.
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
McClintock Matthew-B29882 - Dec. 28, 2011, 1:35 a.m.
On Thu, Dec 22, 2011 at 9:15 PM, Luo Zhenhua-B19537
<B19537@freescale.com> wrote:
> Can somebody confirm whether valgrind works for armv4/v5, please?

We should probably ask this on a valgrind list...

-M

Patch

diff --git a/meta/recipes-devtools/valgrind/valgrind_3.6.1.bb b/meta/recipes-devtools/valgrind/valgrind_3.6.1.bb
index 021caa8..c09fc41 100644
--- a/meta/recipes-devtools/valgrind/valgrind_3.6.1.bb
+++ b/meta/recipes-devtools/valgrind/valgrind_3.6.1.bb
@@ -7,7 +7,7 @@  LIC_FILES_CHKSUM = "file://COPYING;md5=c46082167a314d785d012a244748d803 \
                     file://include/valgrind.h;beginline=1;endline=56;md5=13a71cedba99112334d8596162aec37e \
                     file://COPYING.DOCS;md5=8fdeb5abdb235a08e76835f8f3260215"
 DEPENDS = "virtual/libx11"
-PR = "r1"
+PR = "r2"
 
 SRC_URI = "http://www.valgrind.org/downloads/valgrind-${PV}.tar.bz2 \
 	   file://fix_issue_caused_by_ccache.patch \
@@ -17,7 +17,7 @@  SRC_URI = "http://www.valgrind.org/downloads/valgrind-${PV}.tar.bz2 \
 SRC_URI[md5sum] = "2c3aa122498baecc9d69194057ca88f5"
 SRC_URI[sha256sum] = "49bdcc4fbcf060049b5f0dcfd8a187a6e90e0b0e57309f633b64e44430726a0e"
 
-COMPATIBLE_HOST = '(i.86|x86_64).*-linux'
+COMPATIBLE_HOST = '(i.86|x86_64|powerpc|powerpc64|ppc|ppc64).*-linux'
 
 inherit autotools