Patchwork [meta-oe,meta-efl,4/6] mplayer2: drop FULL_OPTIMIZATION_armv7a and add -fno-tree-vectorize

login
register
mail settings
Submitter Martin Jansa
Date Dec. 15, 2011, 1:31 p.m.
Message ID <1323955898-31477-1-git-send-email-Martin.Jansa@gmail.com>
Download mbox | patch
Permalink /patch/17033/
State Accepted
Commit c59fda28b29afcdcb245651cabbe08a76856d8ca
Headers show

Comments

Martin Jansa - Dec. 15, 2011, 1:31 p.m.
* we had -ftree-vectorize instead of -frename-registers here, but that's
  causing ICE with latest gcc-4.6 from meta-oe
* qemux86-64 was still failing without -fno-tree-vectorize
* similar to issue in libvpx
  http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-November/036001.html
  and lowering to -O3 is not enough in this case
  | libmpcodecs/ad_imaadpcm.c: In function 'qt_ima_adpcm_decode_block':
  | libmpcodecs/ad_imaadpcm.c:177:12: internal compiler error: Segmentation fault
  | Please submit a full bug report,
  | with preprocessed source if appropriate.
  | See <http://gcc.gnu.org/bugs.html> for instructions.
  | make: *** [libmpcodecs/ad_imaadpcm.o] Error 1

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)
Khem Raj - Dec. 16, 2011, 9:46 p.m.
On (15/12/11 14:31), Martin Jansa wrote:
> * we had -ftree-vectorize instead of -frename-registers here, but that's
>   causing ICE with latest gcc-4.6 from meta-oe
> * qemux86-64 was still failing without -fno-tree-vectorize
> * similar to issue in libvpx
>   http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-November/036001.html
>   and lowering to -O3 is not enough in this case
>   | libmpcodecs/ad_imaadpcm.c: In function 'qt_ima_adpcm_decode_block':
>   | libmpcodecs/ad_imaadpcm.c:177:12: internal compiler error: Segmentation fault
>   | Please submit a full bug report,
>   | with preprocessed source if appropriate.
>   | See <http://gcc.gnu.org/bugs.html> for instructions.
>   | make: *** [libmpcodecs/ad_imaadpcm.o] Error 1
> 

can you create a preprocessed file for this please so we can look at it


> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> index ee64ca8..72d5754 100644
> --- a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> +++ b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
> @@ -21,7 +21,7 @@ SRCREV = "e3f5043233336d8b4b0731c6a8b42a8fda5535ac"
>  ARM_INSTRUCTION_SET = "ARM"
>  
>  PV = "2.0+gitr${SRCPV}"
> -PR = "r3"
> +PR = "r4"
>  
>  PARALLEL_MAKE = ""
>  
> @@ -130,8 +130,7 @@ EXTRA_OECONF = " \
>  EXTRA_OECONF_append_armv6 = " --enable-armv6"
>  EXTRA_OECONF_append_armv7a = " --enable-armv6 --enable-neon"
>  
> -FULL_OPTIMIZATION = "-fexpensive-optimizations -fomit-frame-pointer -frename-registers -O4 -ffast-math"
> -FULL_OPTIMIZATION_armv7a = "-fexpensive-optimizations  -ftree-vectorize -fomit-frame-pointer -O4 -ffast-math"
> +FULL_OPTIMIZATION = "-fexpensive-optimizations -fomit-frame-pointer -frename-registers -O4 -ffast-math -fno-tree-vectorize"
>  BUILD_OPTIMIZATION = "${FULL_OPTIMIZATION}"
>  
>  CFLAGS_append = " -I${S}/libdvdread4 "
> -- 
> 1.7.8
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Patch

diff --git a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
index ee64ca8..72d5754 100644
--- a/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
+++ b/meta-oe/recipes-multimedia/mplayer/mplayer2_git.bb
@@ -21,7 +21,7 @@  SRCREV = "e3f5043233336d8b4b0731c6a8b42a8fda5535ac"
 ARM_INSTRUCTION_SET = "ARM"
 
 PV = "2.0+gitr${SRCPV}"
-PR = "r3"
+PR = "r4"
 
 PARALLEL_MAKE = ""
 
@@ -130,8 +130,7 @@  EXTRA_OECONF = " \
 EXTRA_OECONF_append_armv6 = " --enable-armv6"
 EXTRA_OECONF_append_armv7a = " --enable-armv6 --enable-neon"
 
-FULL_OPTIMIZATION = "-fexpensive-optimizations -fomit-frame-pointer -frename-registers -O4 -ffast-math"
-FULL_OPTIMIZATION_armv7a = "-fexpensive-optimizations  -ftree-vectorize -fomit-frame-pointer -O4 -ffast-math"
+FULL_OPTIMIZATION = "-fexpensive-optimizations -fomit-frame-pointer -frename-registers -O4 -ffast-math -fno-tree-vectorize"
 BUILD_OPTIMIZATION = "${FULL_OPTIMIZATION}"
 
 CFLAGS_append = " -I${S}/libdvdread4 "