Patchwork [7/7] perl: add .pl, pm, pod, sh files to SSTATE_SCANE_FILES

login
register
mail settings
Submitter Saul Wold
Date Dec. 15, 2011, 1:50 a.m.
Message ID <b52e93fb176d552e1334088af964dfbd38c0007d.1323911699.git.sgw@linux.intel.com>
Download mbox | patch
Permalink /patch/16967/
State Accepted
Commit 1e4466fc1ce32e5903ce0ed3f0ac80e3e93e1e24
Headers show

Comments

Saul Wold - Dec. 15, 2011, 1:50 a.m.
Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 meta/recipes-devtools/perl/perl_5.14.2.bb |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
Phil Blundell - Dec. 15, 2011, 10:26 a.m.
On Wed, 2011-12-14 at 17:50 -0800, Saul Wold wrote:
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
>  meta/recipes-devtools/perl/perl_5.14.2.bb |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)

This commit message is very terse.  What is SSTATE_SCAN[E]_FILES and why
do we want these things in it?

> +SSTATE_SCAN_FILES += "*.pm *.pod *.h *.pl *.sh"

p.
Richard Purdie - Dec. 15, 2011, 11:14 a.m.
On Thu, 2011-12-15 at 10:26 +0000, Phil Blundell wrote:
> On Wed, 2011-12-14 at 17:50 -0800, Saul Wold wrote:
> > Signed-off-by: Saul Wold <sgw@linux.intel.com>
> > ---
> >  meta/recipes-devtools/perl/perl_5.14.2.bb |    5 ++++-
> >  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> This commit message is very terse.  What is SSTATE_SCAN[E]_FILES and why
> do we want these things in it?

This is basically some hints to the sstate code about which files need
relocation mangling. We process all files for the native/cross cases but
in the target case it's only been .la and binconfig files we've
processed.

An earlier patch is adding in a mechanism to extend this list and this
is adding in some problematic files for the perl case. We've been seeing
sstate failures from issues like this.

I agree this probably needs a little more explanation in the commit
message.

Cheers,

Richard

Patch

diff --git a/meta/recipes-devtools/perl/perl_5.14.2.bb b/meta/recipes-devtools/perl/perl_5.14.2.bb
index 5efe249..0abefe4 100644
--- a/meta/recipes-devtools/perl/perl_5.14.2.bb
+++ b/meta/recipes-devtools/perl/perl_5.14.2.bb
@@ -7,7 +7,7 @@  LIC_FILES_CHKSUM = "file://Copying;md5=2b4c6ffbcfcbdee469f02565f253d81a \
 # We need gnugrep (for -I)
 DEPENDS = "virtual/db grep-native"
 DEPENDS += "gdbm zlib"
-PR = "r1"
+PR = "r2"
 
 # 5.10.1 has Module::Build built-in
 PROVIDES += "libmodule-build-perl"
@@ -302,3 +302,6 @@  RPROVIDES_perl-lib = "perl-lib"
 require perl-rdepends_${PV}.inc
 require perl-rprovides.inc
 require perl-rprovides_${PV}.inc
+
+SSTATE_SCAN_FILES += "*.pm *.pod *.h *.pl *.sh"
+