Patchwork [9/9] libatomic-ops: drop directory with documentation to remove QA warning

login
register
mail settings
Submitter lumag
Date Dec. 13, 2011, 4:19 p.m.
Message ID <1323793193-31090-9-git-send-email-dbaryshkov@gmail.com>
Download mbox | patch
Permalink /patch/16833/
State New
Headers show

Comments

lumag - Dec. 13, 2011, 4:19 p.m.
Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
---
 .../pulseaudio/libatomics-ops_1.2.bb               |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Richard Purdie - Dec. 13, 2011, 7:48 p.m.
On Tue, 2011-12-13 at 20:19 +0400, Dmitry Eremin-Solenikov wrote:
> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> ---
>  .../pulseaudio/libatomics-ops_1.2.bb               |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/recipes-multimedia/pulseaudio/libatomics-ops_1.2.bb b/meta/recipes-multimedia/pulseaudio/libatomics-ops_1.2.bb
> index 184c167..f81aeb6 100644
> --- a/meta/recipes-multimedia/pulseaudio/libatomics-ops_1.2.bb
> +++ b/meta/recipes-multimedia/pulseaudio/libatomics-ops_1.2.bb
> @@ -26,5 +26,6 @@ ARM_INSTRUCTION_SET = "arm"
>  inherit autotools pkgconfig
>  
>  do_install_append() {
> -	mv ${D}${datadir}/libatomic_ops ${D}${datadir}/libatomic-ops || true
> +	# those contain only docs, not necessary for now.
> +	rm -rf ${D}${datadir}/libatomic_ops || true
>  }

Shouldn't we move that to docdir/${PN}?

Cheers,

Richard
lumag - Dec. 13, 2011, 10:07 p.m.
On 12/13/2011 11:48 PM, Richard Purdie wrote:
> On Tue, 2011-12-13 at 20:19 +0400, Dmitry Eremin-Solenikov wrote:
>> Signed-off-by: Dmitry Eremin-Solenikov<dbaryshkov@gmail.com>
>> ---
>>   .../pulseaudio/libatomics-ops_1.2.bb               |    3 ++-
>>   1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta/recipes-multimedia/pulseaudio/libatomics-ops_1.2.bb b/meta/recipes-multimedia/pulseaudio/libatomics-ops_1.2.bb
>> index 184c167..f81aeb6 100644
>> --- a/meta/recipes-multimedia/pulseaudio/libatomics-ops_1.2.bb
>> +++ b/meta/recipes-multimedia/pulseaudio/libatomics-ops_1.2.bb
>> @@ -26,5 +26,6 @@ ARM_INSTRUCTION_SET = "arm"
>>   inherit autotools pkgconfig
>>
>>   do_install_append() {
>> -	mv ${D}${datadir}/libatomic_ops ${D}${datadir}/libatomic-ops || true
>> +	# those contain only docs, not necessary for now.
>> +	rm -rf ${D}${datadir}/libatomic_ops || true
>>   }
>
> Shouldn't we move that to docdir/${PN}?

I'm thinking another way: why is the recipe called libatomicS-ops (note 
the S) if the upstream source is named as libatomc_ops (so it should 
become libatomic-ops). Then documentation will land in the proper place 
after the mv command which is currently in place.
Richard Purdie - Dec. 15, 2011, 12:26 p.m.
On Wed, 2011-12-14 at 02:07 +0400, Dmitry Eremin-Solenikov wrote:
> On 12/13/2011 11:48 PM, Richard Purdie wrote:
> > On Tue, 2011-12-13 at 20:19 +0400, Dmitry Eremin-Solenikov wrote:
> >> Signed-off-by: Dmitry Eremin-Solenikov<dbaryshkov@gmail.com>
> >> ---
> >>   .../pulseaudio/libatomics-ops_1.2.bb               |    3 ++-
> >>   1 files changed, 2 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/meta/recipes-multimedia/pulseaudio/libatomics-ops_1.2.bb b/meta/recipes-multimedia/pulseaudio/libatomics-ops_1.2.bb
> >> index 184c167..f81aeb6 100644
> >> --- a/meta/recipes-multimedia/pulseaudio/libatomics-ops_1.2.bb
> >> +++ b/meta/recipes-multimedia/pulseaudio/libatomics-ops_1.2.bb
> >> @@ -26,5 +26,6 @@ ARM_INSTRUCTION_SET = "arm"
> >>   inherit autotools pkgconfig
> >>
> >>   do_install_append() {
> >> -	mv ${D}${datadir}/libatomic_ops ${D}${datadir}/libatomic-ops || true
> >> +	# those contain only docs, not necessary for now.
> >> +	rm -rf ${D}${datadir}/libatomic_ops || true
> >>   }
> >
> > Shouldn't we move that to docdir/${PN}?
> 
> I'm thinking another way: why is the recipe called libatomicS-ops (note 
> the S) if the upstream source is named as libatomc_ops (so it should 
> become libatomic-ops). Then documentation will land in the proper place 
> after the mv command which is currently in place.

I agree it should probably get renamed, I can't see a good reason for
that name. That will potentially cause some friction with other things
depending on it though :(

Cheers,

Richard

Patch

diff --git a/meta/recipes-multimedia/pulseaudio/libatomics-ops_1.2.bb b/meta/recipes-multimedia/pulseaudio/libatomics-ops_1.2.bb
index 184c167..f81aeb6 100644
--- a/meta/recipes-multimedia/pulseaudio/libatomics-ops_1.2.bb
+++ b/meta/recipes-multimedia/pulseaudio/libatomics-ops_1.2.bb
@@ -26,5 +26,6 @@  ARM_INSTRUCTION_SET = "arm"
 inherit autotools pkgconfig
 
 do_install_append() {
-	mv ${D}${datadir}/libatomic_ops ${D}${datadir}/libatomic-ops || true
+	# those contain only docs, not necessary for now.
+	rm -rf ${D}${datadir}/libatomic_ops || true
 }