Patchwork [1/1] connman: improve packaging

login
mail settings
Submitter Otavio Salvador
Date Dec. 13, 2011, 10:41 a.m.
Message ID <b2df27e3b60bc584dab08c25232f87b7f3a7e8db.1323772851.git.otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/16799/
State Accepted
Commit 6f9594cddefe74ce7381e4fa2a68cb8a542d6d2e
Headers show

Comments

Otavio Salvador - Dec. 13, 2011, 10:41 a.m.
The scripts being included on connman-scripts was the test utility and
thus we are moving them with the rest of test utilities in
'connman-tests'. A runtime dependency on python-dbus were missing as
well as those scripts uses it.

As no dhclient, resolvconf and udhcpc plugins are being generated the
respective dependency map entries were also removed.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 meta/recipes-connectivity/connman/connman.inc     |   14 ++++++--------
 meta/recipes-connectivity/connman/connman_0.78.bb |    2 +-
 2 files changed, 7 insertions(+), 9 deletions(-)

Patch

diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
index 503bf1c..bb1b279 100644
--- a/meta/recipes-connectivity/connman/connman.inc
+++ b/meta/recipes-connectivity/connman/connman.inc
@@ -68,16 +68,16 @@  do_install_append() {
 	install -d ${D}${bindir}
 	install -m 0755 ${S}/tools/*-test ${D}${bindir}
 	install -m 0755 ${S}/tools/wispr ${D}${bindir}
+
+	# We don't need to package an empty directory
+	rmdir ${D}${libdir}/connman/scripts
 }
 
 PACKAGES_DYNAMIC = "${PN}-plugin-*"
 
 python populate_packages_prepend() {
 	depmap = dict( pppd="ppp",
-	               udhcp="busybox connman-scripts",
-	               dhclient="dhcp-client",
 	               wifi="wpa-supplicant",
-	               resolvconf="resolvconf",
 	               bluetooth="bluez4",
 	               ofono="ofono" )
 	packages = []
@@ -94,14 +94,12 @@  python populate_packages_prepend() {
 			d.setVar("RDEPENDS_%s" % package, " ".join(rdepends))
 }
 
-PACKAGES =+ "${PN}-scripts ${PN}-tools ${PN}-tests"
+PACKAGES =+ "${PN}-tools ${PN}-tests"
 
 FILES_${PN}-tools = "${bindir}/wispr"
 
-FILES_${PN}-tests = "${bindir}/*-test"
-
-FILES_${PN}-scripts += "${libdir}/${PN}/test/* ${libdir}/connman/scripts"
-RDEPENDS_${PN}-scripts = "python"
+FILES_${PN}-tests = "${bindir}/*-test ${libdir}/${PN}/test/*"
+RDEPENDS_${PN}-tests = "python-dbus"
 
 FILES_${PN} = "${bindir}/* ${sbindir}/* ${libexecdir}/* ${libdir}/lib*.so.* \
             ${sysconfdir} ${sharedstatedir} ${localstatedir} \
diff --git a/meta/recipes-connectivity/connman/connman_0.78.bb b/meta/recipes-connectivity/connman/connman_0.78.bb
index f36f670..74c102b 100644
--- a/meta/recipes-connectivity/connman/connman_0.78.bb
+++ b/meta/recipes-connectivity/connman/connman_0.78.bb
@@ -1,6 +1,6 @@ 
 require connman.inc
 
-PR = "r4"
+PR = "r5"
 
 # 0.78 tag
 SRCREV = "02f5d5fe2d7c71514a6387ba2b772b42d8e8d297"