Patchwork [2/2] gvfs : Fix build failure due to introduction of host includes.

login
register
mail settings
Submitter Philip Balister
Date Dec. 12, 2011, 4:24 p.m.
Message ID <1323707082-9185-2-git-send-email-philip@balister.org>
Download mbox | patch
Permalink /patch/16755/
State Superseded, archived
Headers show

Comments

Philip Balister - Dec. 12, 2011, 4:24 p.m.
Tested with Angstrom on usrp-e1xx.

Signed-off-by: Philip Balister <philip@balister.org>
---
 meta-gnome/recipes-gnome/gvfs/gvfs_1.8.2.bb |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Khem Raj - Dec. 12, 2011, 5:35 p.m.
On Mon, Dec 12, 2011 at 8:24 AM, Philip Balister <philip@balister.org> wrote:
> Tested with Angstrom on usrp-e1xx.
>
> Signed-off-by: Philip Balister <philip@balister.org>
> ---
>  meta-gnome/recipes-gnome/gvfs/gvfs_1.8.2.bb |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/meta-gnome/recipes-gnome/gvfs/gvfs_1.8.2.bb b/meta-gnome/recipes-gnome/gvfs/gvfs_1.8.2.bb
> index 5a230eb..fd4a089 100644
> --- a/meta-gnome/recipes-gnome/gvfs/gvfs_1.8.2.bb
> +++ b/meta-gnome/recipes-gnome/gvfs/gvfs_1.8.2.bb
> @@ -14,6 +14,7 @@ SRC_URI[archive.md5sum] = "402f94b187b197b403d25c85caeb9562"
>  SRC_URI[archive.sha256sum] = "0895ac8f6d416e1b15433b6b6b68eb119c6e8b04fdb66db665d684355ef89345"
>
>  EXTRA_OECONF = "--disable-samba \
> +                --disable-archive \

You are disabling archive backend explicitly. It might be that someone is using
it successfully. Why does it not work ?

>                 --with-samba-includes=${STAGING_INCDIR} \
>                 --with-samba-libs=${STAGING_LIBDIR} \
>                 --with-archive-includes=${STAGING_INCDIR} \

the above option is not needed when you are disabling libarchive anyway

> --
> 1.7.3.4
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Philip Balister - Dec. 12, 2011, 6:34 p.m.
On 12/12/2011 12:35 PM, Khem Raj wrote:
> On Mon, Dec 12, 2011 at 8:24 AM, Philip Balister <philip@balister.org> wrote:
>> Tested with Angstrom on usrp-e1xx.
>>
>> Signed-off-by: Philip Balister <philip@balister.org>
>> ---
>>  meta-gnome/recipes-gnome/gvfs/gvfs_1.8.2.bb |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/meta-gnome/recipes-gnome/gvfs/gvfs_1.8.2.bb b/meta-gnome/recipes-gnome/gvfs/gvfs_1.8.2.bb
>> index 5a230eb..fd4a089 100644
>> --- a/meta-gnome/recipes-gnome/gvfs/gvfs_1.8.2.bb
>> +++ b/meta-gnome/recipes-gnome/gvfs/gvfs_1.8.2.bb
>> @@ -14,6 +14,7 @@ SRC_URI[archive.md5sum] = "402f94b187b197b403d25c85caeb9562"
>>  SRC_URI[archive.sha256sum] = "0895ac8f6d416e1b15433b6b6b68eb119c6e8b04fdb66db665d684355ef89345"
>>
>>  EXTRA_OECONF = "--disable-samba \
>> +                --disable-archive \
> 
> You are disabling archive backend explicitly. It might be that someone is using
> it successfully. Why does it not work ?

With it enabled, the build fails because it looks at host includes. Long
term someone will likely fix this, be in the short term, I need this to
work so I can move forward with oe-core based stuff.

Philip

> 
>>                 --with-samba-includes=${STAGING_INCDIR} \
>>                 --with-samba-libs=${STAGING_LIBDIR} \
>>                 --with-archive-includes=${STAGING_INCDIR} \
> 
> the above option is not needed when you are disabling libarchive anyway
> 
>> --
>> 1.7.3.4
>>
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Khem Raj - Dec. 12, 2011, 9:45 p.m.
On Mon, Dec 12, 2011 at 10:34 AM, Philip Balister <philip@balister.org> wrote:
>>>
>>>  EXTRA_OECONF = "--disable-samba \
>>> +                --disable-archive \
>>
>> You are disabling archive backend explicitly. It might be that someone is using
>> it successfully. Why does it not work ?
>
> With it enabled, the build fails because it looks at host includes. Long
> term someone will likely fix this, be in the short term, I need this to
> work so I can move forward with oe-core based stuff.

OK. I see that we do not list libarchive in DEPENDS if we did then it
would build I suppose. Can you try that please ?

so I think at present what you get is that if libarchive is built and
staged before you build
gvfs then you get the support compiled in if not then you don't. So
your patch at least makes
it consistent by disabling it.

Problem only happens if you have libarchive-dev installed on your
build host which I think
you do have and hence you see the problem.

I have no strong feeling on enabling or disabling it but I would
prefer consistency

-Khem
Philip Balister - Dec. 13, 2011, 3:21 p.m.
On 12/12/2011 04:45 PM, Khem Raj wrote:
> On Mon, Dec 12, 2011 at 10:34 AM, Philip Balister <philip@balister.org> wrote:
>>>>
>>>>  EXTRA_OECONF = "--disable-samba \
>>>> +                --disable-archive \
>>>
>>> You are disabling archive backend explicitly. It might be that someone is using
>>> it successfully. Why does it not work ?
>>
>> With it enabled, the build fails because it looks at host includes. Long
>> term someone will likely fix this, be in the short term, I need this to
>> work so I can move forward with oe-core based stuff.
> 
> OK. I see that we do not list libarchive in DEPENDS if we did then it
> would build I suppose. Can you try that please ?
> 
> so I think at present what you get is that if libarchive is built and
> staged before you build
> gvfs then you get the support compiled in if not then you don't. So
> your patch at least makes
> it consistent by disabling it.

Still fails if you DEPEND on libarchive.

Philip

> 
> Problem only happens if you have libarchive-dev installed on your
> build host which I think
> you do have and hence you see the problem.
> 
> I have no strong feeling on enabling or disabling it but I would
> prefer consistency
> 
> -Khem
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Patch

diff --git a/meta-gnome/recipes-gnome/gvfs/gvfs_1.8.2.bb b/meta-gnome/recipes-gnome/gvfs/gvfs_1.8.2.bb
index 5a230eb..fd4a089 100644
--- a/meta-gnome/recipes-gnome/gvfs/gvfs_1.8.2.bb
+++ b/meta-gnome/recipes-gnome/gvfs/gvfs_1.8.2.bb
@@ -14,6 +14,7 @@  SRC_URI[archive.md5sum] = "402f94b187b197b403d25c85caeb9562"
 SRC_URI[archive.sha256sum] = "0895ac8f6d416e1b15433b6b6b68eb119c6e8b04fdb66db665d684355ef89345"
 
 EXTRA_OECONF = "--disable-samba \
+                --disable-archive \
                 --with-samba-includes=${STAGING_INCDIR} \
                 --with-samba-libs=${STAGING_LIBDIR} \
                 --with-archive-includes=${STAGING_INCDIR} \