| Submitter | Saul Wold |
|---|---|
| Date | Dec. 10, 2011, 10:01 p.m. |
| Message ID | <2fd890beaefd817feed03ef17b630a9af8aa465c.1323554268.git.sgw@linux.intel.com> |
| Download | mbox | patch |
| Permalink | /patch/16659/ |
| State | New |
| Headers | show |
Comments
Op 10 dec. 2011, om 23:01 heeft Saul Wold het volgende geschreven: > Signed-off-by: Saul Wold <sgw@linux.intel.com> > --- > meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.0.bb | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > +RDEPENDS = "hicolor-icon-theme" Are you sure this is the right place? gdk-pixbuf are just the image loaders, they shouldn't have a hard dependency on a bunch of icons... As for the apps, gtk-icon-cache.bbclass should be adding the hicolor dep automatically. regards, Koen
On 12/11/2011 12:52 AM, Koen Kooi wrote: > > Op 10 dec. 2011, om 23:01 heeft Saul Wold het volgende geschreven: > >> Signed-off-by: Saul Wold<sgw@linux.intel.com> >> --- >> meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.0.bb | 4 ++++ >> 1 files changed, 4 insertions(+), 0 deletions(-) >> >> +RDEPENDS = "hicolor-icon-theme" > > Are you sure this is the right place? gdk-pixbuf are just the image loaders, they shouldn't have a hard dependency on a bunch of icons... As for the apps, gtk-icon-cache.bbclass should be adding the hicolor dep automatically. > Your right, I did not look in the bbclass, I was trying to resolve this issue: Configuring gdk-pixbuf-loader-png. gtk-update-icon-cache: No theme index file. Configuring gdk-pixbuf-loader-jpeg. gtk-update-icon-cache: No theme index file. Configuring liberation-fonts. Configuring gdk-pixbuf-loader-xpm. gtk-update-icon-cache: No theme index file. Configuring gdk-pixbuf-loader-gif. gtk-update-icon-cache: No theme index file. Which seems to stem from gdk-pixbuf-loader-xpm's postinstall trying to cache the hicolor icons. I can see the dependency, but they did not seem to be installed, more digging is required. I withdraw this patch. Sau! > regards, > > Koen > > > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Patch
diff --git a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.0.bb b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.0.bb index b33eca9..7955e3b 100644 --- a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.0.bb +++ b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.0.bb @@ -10,6 +10,8 @@ SECTION = "libs" DEPENDS = "libpng glib-2.0 jpeg" +PR = "r1" + SRC_URI = "http://ftp.acc.umu.se/pub/GNOME/sources/gdk-pixbuf/2.24/gdk-pixbuf-${PV}.tar.bz2 \ file://hardcoded_libtool.patch \ file://configure_fix.patch \ @@ -20,6 +22,8 @@ SRC_URI[sha256sum] = "38d2630314e6d91976bffd833236f84fefa440a9038f86dc422820a39f inherit autotools pkgconfig gettext +RDEPENDS = "hicolor-icon-theme" + LIBV = "2.10.0" EXTRA_OECONF = "\
Signed-off-by: Saul Wold <sgw@linux.intel.com> --- meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.0.bb | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)