Patchwork [3/5] self-hosted: Add ext2 utilites and perl-pod for building

login
register
mail settings
Submitter Saul Wold
Date Dec. 10, 2011, 10:01 p.m.
Message ID <71f6cb63e711721a1a03cfc1c0f1d054472241fe.1323554268.git.sgw@linux.intel.com>
Download mbox | patch
Permalink /patch/16657/
State New
Headers show

Comments

Saul Wold - Dec. 10, 2011, 10:01 p.m.
Add self-hosted-host-tools for non-build related tools

Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 meta/recipes-core/tasks/task-self-hosted.bb |   54 +++++++++++++++-----------
 1 files changed, 31 insertions(+), 23 deletions(-)
Wolfgang Denk - Dec. 10, 2011, 11:24 p.m.
Dear Saul Wold,

In message <71f6cb63e711721a1a03cfc1c0f1d054472241fe.1323554268.git.sgw@linux.intel.com> you wrote:
> Add self-hosted-host-tools for non-build related tools
...
> +    e2fsprogs \
...
> +    genext2fs \

It's certainly nice to have the ext2 tools then, but would it not also
make a lot of sense to include mtd-utils (so we can erase flash and
create UBI volumes / UBIFS file system images) and eventually even
dosfstools?

Most embedded systems come with NAND these days, and a lot of them use
UBI/UBIFS...

Best regards,

Wolfgang Denk
Saul Wold - Dec. 11, 2011, 12:47 a.m.
On 12/10/2011 03:24 PM, Wolfgang Denk wrote:
> Dear Saul Wold,
>
> In message<71f6cb63e711721a1a03cfc1c0f1d054472241fe.1323554268.git.sgw@linux.intel.com>  you wrote:
>> Add self-hosted-host-tools for non-build related tools
> ...
>> +    e2fsprogs \
> ...
>> +    genext2fs \
>
> It's certainly nice to have the ext2 tools then, but would it not also
> make a lot of sense to include mtd-utils (so we can erase flash and
> create UBI volumes / UBIFS file system images) and eventually even
> dosfstools?
>
> Most embedded systems come with NAND these days, and a lot of them use
> UBI/UBIFS...
>
Great point Wolfgang, this is an evolving item, please feel free to 
submit the appropriate patches!

Sau!

> Best regards,
>
> Wolfgang Denk
>
Paul Menzel - Dec. 11, 2011, 7:05 a.m.
Dear Saul,


Am Samstag, den 10.12.2011, 14:01 -0800 schrieb Saul Wold:
> Add self-hosted-host-tools for non-build related tools
> 
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
>  meta/recipes-core/tasks/task-self-hosted.bb |   54 +++++++++++++++-----------
>  1 files changed, 31 insertions(+), 23 deletions(-)
> 
> diff --git a/meta/recipes-core/tasks/task-self-hosted.bb b/meta/recipes-core/tasks/task-self-hosted.bb
> index b3a68b4..b9bdd21 100644
> --- a/meta/recipes-core/tasks/task-self-hosted.bb
> +++ b/meta/recipes-core/tasks/task-self-hosted.bb
> @@ -3,7 +3,7 @@
>  #
>  
>  DESCRIPTION = "Create Basic Image Tasks"
> -PR = "r1"
> +PR = "r2"
>  LICENSE = "MIT"
>  LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
>                      file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
> @@ -14,6 +14,7 @@ PACKAGES = "\
>      task-self-hosted-sdk \
>      task-self-hosted-extended \
>      task-self-hosted-graphics \
> +    task-self-hosted-host-tools \
>      "
>  
>  ALLOW_EMPTY = "1"
> @@ -23,13 +24,26 @@ RDEPENDS_task-self-hosted = "\
>      task-self-hosted-sdk \
>      task-self-hosted-extended \
>      task-self-hosted-graphics \
> +    task-self-hosted-host-tools \
> +    "
> +
> +RDEPENDS_task-self-hosted-host-tools = "\
> +    e2fsprogs \
> +    dhcp-client \
> +    genext2fs \
> +    hdparm \
> +    iptables \
> +    kernel-module-tun \
> +    kernel-module-iptable-raw \
> +    kernel-module-iptable-nat \
> +    kernel-module-iptable-mangle \
> +    kernel-module-iptable-filter \
> +    mc \
> +    screen \
>      "

[…]

I find this patch quite hard to review, since it reorders the
variables(?). Is there a trick to review this or are two separate
patches better.

Could you also please check your pull request script to send

    <openembedded-core@lists.openembedded.org>

instead of

    <openembedded-core@openembedded.org>

and therefore answering to all messages are sent twice to the list.


Thanks,

Paul
Saul Wold - Dec. 11, 2011, 8:17 p.m.
On 12/10/2011 11:05 PM, Paul Menzel wrote:
> Dear Saul,
>
>
> Am Samstag, den 10.12.2011, 14:01 -0800 schrieb Saul Wold:
>> Add self-hosted-host-tools for non-build related tools
>>
>> Signed-off-by: Saul Wold<sgw@linux.intel.com>
>> ---
>>   meta/recipes-core/tasks/task-self-hosted.bb |   54 +++++++++++++++-----------
>>   1 files changed, 31 insertions(+), 23 deletions(-)
>>
>> diff --git a/meta/recipes-core/tasks/task-self-hosted.bb b/meta/recipes-core/tasks/task-self-hosted.bb
>> index b3a68b4..b9bdd21 100644
>> --- a/meta/recipes-core/tasks/task-self-hosted.bb
>> +++ b/meta/recipes-core/tasks/task-self-hosted.bb
>> @@ -3,7 +3,7 @@
>>   #
>>
>>   DESCRIPTION = "Create Basic Image Tasks"
>> -PR = "r1"
>> +PR = "r2"
>>   LICENSE = "MIT"
>>   LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
>>                       file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
>> @@ -14,6 +14,7 @@ PACKAGES = "\
>>       task-self-hosted-sdk \
>>       task-self-hosted-extended \
>>       task-self-hosted-graphics \
>> +    task-self-hosted-host-tools \
>>       "
>>
>>   ALLOW_EMPTY = "1"
>> @@ -23,13 +24,26 @@ RDEPENDS_task-self-hosted = "\
>>       task-self-hosted-sdk \
>>       task-self-hosted-extended \
>>       task-self-hosted-graphics \
>> +    task-self-hosted-host-tools \
>> +    "
>> +
>> +RDEPENDS_task-self-hosted-host-tools = "\
>> +    e2fsprogs \
>> +    dhcp-client \
>> +    genext2fs \
>> +    hdparm \
>> +    iptables \
>> +    kernel-module-tun \
>> +    kernel-module-iptable-raw \
>> +    kernel-module-iptable-nat \
>> +    kernel-module-iptable-mangle \
>> +    kernel-module-iptable-filter \
>> +    mc \
>> +    screen \
>>       "
>
> […]
>
> I find this patch quite hard to review, since it reorders the
> variables(?). Is there a trick to review this or are two separate
> patches better.
>
No trick, just moved a couple of items that where in the wrong place 
from one task to the host-tools task.

> Could you also please check your pull request script to send
>
>      <openembedded-core@lists.openembedded.org>
>
> instead of
>
>      <openembedded-core@openembedded.org>
>
> and therefore answering to all messages are sent twice to the list.
>
Sure, not sure why that would be happening.

Sau!

>
> Thanks,
>
> Paul
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-core/tasks/task-self-hosted.bb b/meta/recipes-core/tasks/task-self-hosted.bb
index b3a68b4..b9bdd21 100644
--- a/meta/recipes-core/tasks/task-self-hosted.bb
+++ b/meta/recipes-core/tasks/task-self-hosted.bb
@@ -3,7 +3,7 @@ 
 #
 
 DESCRIPTION = "Create Basic Image Tasks"
-PR = "r1"
+PR = "r2"
 LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
                     file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
@@ -14,6 +14,7 @@  PACKAGES = "\
     task-self-hosted-sdk \
     task-self-hosted-extended \
     task-self-hosted-graphics \
+    task-self-hosted-host-tools \
     "
 
 ALLOW_EMPTY = "1"
@@ -23,13 +24,26 @@  RDEPENDS_task-self-hosted = "\
     task-self-hosted-sdk \
     task-self-hosted-extended \
     task-self-hosted-graphics \
+    task-self-hosted-host-tools \
+    "
+
+RDEPENDS_task-self-hosted-host-tools = "\
+    e2fsprogs \
+    dhcp-client \
+    genext2fs \
+    hdparm \
+    iptables \
+    kernel-module-tun \
+    kernel-module-iptable-raw \
+    kernel-module-iptable-nat \
+    kernel-module-iptable-mangle \
+    kernel-module-iptable-filter \
+    mc \
+    screen \
     "
 
 # eglibc-utils: for rpcgen
 RDEPENDS_task-self-hosted-sdk = "\
-    sed \
-    mktemp \
-    eglibc-utils \
     autoconf \
     automake \
     binutils-symlinks \
@@ -37,27 +51,30 @@  RDEPENDS_task-self-hosted-sdk = "\
     cpp \
     cpp-symlinks \
     ccache \
+    coreutils \
+    diffutils \
+    distcc \
+    eglibc-utils \
+    file \
+    findutils \
     gcc \
     gcc-symlinks \
     g++ \
     g++-symlinks \
     gettext \
-    make \
     intltool \
+    ldd \
+    less \
     libstdc++ \
     libstdc++-dev \
     libtool \
+    make \
+    mktemp \
     perl-module-re \
     perl-module-text-wrap \
-    coreutils \
-    diffutils \
     pkgconfig \
-    findutils \
     quilt \
-    less \
-    distcc \
-    ldd \
-    file \
+    sed \
     tcl \
     "
 
@@ -74,8 +91,8 @@  RDEPENDS_task-self-hosted-extended = "\
     bzip2 \
     chkconfig \
     chrpath \
+    cpio \
     curl \
-    dhcp-client \
     diffstat \
     diffutils \
     elfutils \
@@ -88,7 +105,6 @@  RDEPENDS_task-self-hosted-extended = "\
     grep \
     groff \
     gawk \
-    hdparm \
     libaio \
     libxml2 \
     libusb1 \
@@ -97,7 +113,6 @@  RDEPENDS_task-self-hosted-extended = "\
     lzo \
     man \
     man-pages \
-    mc \
     mdadm \
     minicom \
     mtools \
@@ -111,6 +126,7 @@  RDEPENDS_task-self-hosted-extended = "\
     perl \
     perl-modules \
     perl-dev \
+    perl-pod \
     pth \
     python \
     python-compile \
@@ -140,7 +156,6 @@  RDEPENDS_task-self-hosted-extended = "\
     quota \
     readline \
     rpm \
-    screen \
     setserial \
     subversion \
     sudo \
@@ -158,13 +173,6 @@  RDEPENDS_task-self-hosted-extended = "\
     xinetd \
     zip \
     zlib \
-    cpio \
-    iptables \
-    kernel-module-tun \
-    kernel-module-iptable-raw \
-    kernel-module-iptable-nat \
-    kernel-module-iptable-mangle \
-    kernel-module-iptable-filter \
     "