Patchwork ftplib: add initial version of recipe

login
register
mail settings
Submitter Vitaly Perov
Date Dec. 10, 2011, 8:10 p.m.
Message ID <1323547821-19780-1-git-send-email-vitperov@gmail.com>
Download mbox | patch
Permalink /patch/16647/
State Superseded
Headers show

Comments

Vitaly Perov - Dec. 10, 2011, 8:10 p.m.
From: Vitaly Perov <vit@vt-tech.eu>

---
 recipes/ftplib/ftplib_3.1.bb |   38 ++++++++++++++++++++++++++++++++++++++
 1 files changed, 38 insertions(+), 0 deletions(-)
 create mode 100644 recipes/ftplib/ftplib_3.1.bb
Paul Menzel - Dec. 10, 2011, 9:22 p.m.
Dear Vitaly,


thank you for your patch.

Am Sonntag, den 11.12.2011, 00:10 +0400 schrieb Vitaly Perov:
> From: Vitaly Perov <vit@vt-tech.eu>

Please add the recipe version to the commit summary (subject) and follow
our commit policy [1][2][3].

Especially your Signed-off-by line is missing. Please also add
information how you tested that recipe.

> ---
>  recipes/ftplib/ftplib_3.1.bb |   38 ++++++++++++++++++++++++++++++++++++++
>  1 files changed, 38 insertions(+), 0 deletions(-)
>  create mode 100644 recipes/ftplib/ftplib_3.1.bb
> 
> diff --git a/recipes/ftplib/ftplib_3.1.bb b/recipes/ftplib/ftplib_3.1.bb
> new file mode 100644
> index 0000000..1dcdb3d
> --- /dev/null
> +++ b/recipes/ftplib/ftplib_3.1.bb
> @@ -0,0 +1,38 @@
> +#! /bin/sh
> +

The shebang is not needed.

> +DESCRIPTION = "A set of routines that implement the FTP protocol"
> +HOMEPAGE = "http://nbpfaus.net/~pfau/ftplib/"
> +LICENSE = "LGPLv2"
> +
> +PR = "r1"

Please start with `r0` when submitting.

> +
> +######################################################################################

Please remove these “style” lines. They are not common. [4]

> +
> +TARGET_CC_ARCH += "${LDFLAGS}"

Why is that needed. Please add a comment and explain it in the commit
message.

> +
> +SRC_URI = "http://nbpfaus.net/~pfau/ftplib/ftplib-${PV}-src.tar.gz"

Can you talk with upstream, that they release versioned tarballs
otherwise that will become a mess when upgraded.

> +
> +S = "${WORKDIR}/ftplib-${PV}"
> +
> +######################################################################################
> +
> +SRC_URI[md5sum] = "c6af758ccbf806b28f022a587a41d9c5"
> +SRC_URI[sha256sum] = "be524e1086cfe9d86afa832e1413dde79a4e88ee8ea5325a87ffaaf6620a0a2b"
> +
> +######################################################################################
> +do_compile() {
> +    cd linux && make

Are you sure that works? At least `oe-runmake` should be used. This way
you should get not the correct target architecture since the build host
make is used. (I could be mistaken and maybe the Makefile figures it out
nevertheless.)

> +}
> +
> +do_install() {
> +    install -d ${D}/${libdir}
> +    install -d ${D}/${includedir}
> +    install -d ${D}/${bindir}
> +    install -m 755 ${S}/linux/libftp.so.3.1 ${D}/${libdir}
> +    install -m 755 ${S}/linux/libftp.a ${D}/${libdir}
> +    install -m 644 ${S}/linux/ftplib.h ${D}/${includedir}
> +    install -m 755 ${S}/linux/qftp ${D}/${bindir}
> +    (cd ${D}/${libdir} && \
> +     ln -sf libftp.so.3.1 libftp.so.3 && \
> +     ln -sf libftp.so.3 libftp.so)
> +}

I do not know if the last three lines are common. But if it works,
great!


Thanks,

Paul


[1] http://www.openembedded.org/wiki/Category:Policy
[2] http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
[3] http://www.openembedded.org/wiki/Commit_Policy
[4] http://www.openembedded.org/wiki/Styleguide
Vitaly Perov - Dec. 11, 2011, 4:50 a.m.
Dear Paul,

Thank you very much for your comments.


On Sun, Dec 11, 2011 at 1:22 AM, Paul Menzel
<paulepanter@users.sourceforge.net> wrote:
> Dear Vitaly,
>
>
> thank you for your patch.
>
> Am Sonntag, den 11.12.2011, 00:10 +0400 schrieb Vitaly Perov:
>> From: Vitaly Perov <vit@vt-tech.eu>
>
> Please add the recipe version to the commit summary (subject) and follow
> our commit policy [1][2][3].
>
> Especially your Signed-off-by line is missing. Please also add
> information how you tested that recipe.
>
>> ---
>>  recipes/ftplib/ftplib_3.1.bb |   38 ++++++++++++++++++++++++++++++++++++++
>>  1 files changed, 38 insertions(+), 0 deletions(-)
>>  create mode 100644 recipes/ftplib/ftplib_3.1.bb
>>
>> diff --git a/recipes/ftplib/ftplib_3.1.bb b/recipes/ftplib/ftplib_3.1.bb
>> new file mode 100644
>> index 0000000..1dcdb3d
>> --- /dev/null
>> +++ b/recipes/ftplib/ftplib_3.1.bb
>> @@ -0,0 +1,38 @@
>> +#! /bin/sh
>> +
>
> The shebang is not needed.
>
>> +DESCRIPTION = "A set of routines that implement the FTP protocol"
>> +HOMEPAGE = "http://nbpfaus.net/~pfau/ftplib/"
>> +LICENSE = "LGPLv2"
>> +
>> +PR = "r1"
>
> Please start with `r0` when submitting.
>
>> +
>> +######################################################################################
>
> Please remove these “style” lines. They are not common. [4]
>
>> +
>> +TARGET_CC_ARCH += "${LDFLAGS}"
>
> Why is that needed. Please add a comment and explain it in the commit
> message.
>
>> +
>> +SRC_URI = "http://nbpfaus.net/~pfau/ftplib/ftplib-${PV}-src.tar.gz"
>
> Can you talk with upstream, that they release versioned tarballs
> otherwise that will become a mess when upgraded.
>
>> +
>> +S = "${WORKDIR}/ftplib-${PV}"
>> +
>> +######################################################################################
>> +
>> +SRC_URI[md5sum] = "c6af758ccbf806b28f022a587a41d9c5"
>> +SRC_URI[sha256sum] = "be524e1086cfe9d86afa832e1413dde79a4e88ee8ea5325a87ffaaf6620a0a2b"
>> +
>> +######################################################################################
>> +do_compile() {
>> +    cd linux && make
>
> Are you sure that works? At least `oe-runmake` should be used. This way
> you should get not the correct target architecture since the build host
> make is used. (I could be mistaken and maybe the Makefile figures it out
> nevertheless.)
>
>> +}
>> +
>> +do_install() {
>> +    install -d ${D}/${libdir}
>> +    install -d ${D}/${includedir}
>> +    install -d ${D}/${bindir}
>> +    install -m 755 ${S}/linux/libftp.so.3.1 ${D}/${libdir}
>> +    install -m 755 ${S}/linux/libftp.a ${D}/${libdir}
>> +    install -m 644 ${S}/linux/ftplib.h ${D}/${includedir}
>> +    install -m 755 ${S}/linux/qftp ${D}/${bindir}
>> +    (cd ${D}/${libdir} && \
>> +     ln -sf libftp.so.3.1 libftp.so.3 && \
>> +     ln -sf libftp.so.3 libftp.so)
>> +}
>
> I do not know if the last three lines are common. But if it works,
> great!
>
>
> Thanks,
>
> Paul
>
>
> [1] http://www.openembedded.org/wiki/Category:Policy
> [2] http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
> [3] http://www.openembedded.org/wiki/Commit_Policy
> [4] http://www.openembedded.org/wiki/Styleguide
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Patch

diff --git a/recipes/ftplib/ftplib_3.1.bb b/recipes/ftplib/ftplib_3.1.bb
new file mode 100644
index 0000000..1dcdb3d
--- /dev/null
+++ b/recipes/ftplib/ftplib_3.1.bb
@@ -0,0 +1,38 @@ 
+#! /bin/sh
+
+DESCRIPTION = "A set of routines that implement the FTP protocol"
+HOMEPAGE = "http://nbpfaus.net/~pfau/ftplib/"
+LICENSE = "LGPLv2"
+
+PR = "r1"
+
+######################################################################################
+
+TARGET_CC_ARCH += "${LDFLAGS}"
+
+SRC_URI = "http://nbpfaus.net/~pfau/ftplib/ftplib-${PV}-src.tar.gz"
+
+S = "${WORKDIR}/ftplib-${PV}"
+
+######################################################################################
+
+SRC_URI[md5sum] = "c6af758ccbf806b28f022a587a41d9c5"
+SRC_URI[sha256sum] = "be524e1086cfe9d86afa832e1413dde79a4e88ee8ea5325a87ffaaf6620a0a2b"
+
+######################################################################################
+do_compile() {
+    cd linux && make
+}
+
+do_install() {
+    install -d ${D}/${libdir}
+    install -d ${D}/${includedir}
+    install -d ${D}/${bindir}
+    install -m 755 ${S}/linux/libftp.so.3.1 ${D}/${libdir}
+    install -m 755 ${S}/linux/libftp.a ${D}/${libdir}
+    install -m 644 ${S}/linux/ftplib.h ${D}/${includedir}
+    install -m 755 ${S}/linux/qftp ${D}/${bindir}
+    (cd ${D}/${libdir} && \
+     ln -sf libftp.so.3.1 libftp.so.3 && \
+     ln -sf libftp.so.3 libftp.so)
+}