| Submitter | Khem Raj |
|---|---|
| Date | March 21, 2011, 6:34 p.m. |
| Message ID | <2a46643e032d11e07f6dfec471cadea8e9dba827.1300732395.git.raj.khem@gmail.com> |
| Download | mbox | patch |
| Permalink | /patch/1661/ |
| State | New, archived |
| Headers | show |
Comments
On Mon, 2011-03-21 at 11:34 -0700, Khem Raj wrote: > When qemu is booted into console with -nographics > then after exiting the terminal line settings are messed > up. This patch calls stty sane to restore the terminal > settings to default. > > stty is part of coreutils which is installed on all > host distros hence there is no need to warn about it > being available or not > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > --- > scripts/poky-qemu-internal | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/scripts/poky-qemu-internal b/scripts/poky-qemu-internal > index 8fd1834..556ce69 100755 > --- a/scripts/poky-qemu-internal > +++ b/scripts/poky-qemu-internal > @@ -189,6 +189,7 @@ cleanup() { > echo "poky-export-rootfs stop $ROOTFS" > poky-export-rootfs stop $ROOTFS > fi > + stty sane > } > > n1=$[ (`echo $TAP | sed 's/tap//'` * 2) + 1 ] With the recent change to the script to run: $QEMUBIN -kernel $KERNEL $QEMUOPTIONS $SERIALOPTS -no-reboot $SCRIPT_QEMU_OPT $SCRIPT_QEMU_EXTRA_OPT --append "$KERNCMDLINE $SCRIPT_KERNEL_OPT" || stty sane is the above change still needed? Cheers, Richard
On Wed, Mar 23, 2011 at 9:53 AM, Richard Purdie <richard.purdie@linuxfoundation.org> wrote: > On Mon, 2011-03-21 at 11:34 -0700, Khem Raj wrote: >> When qemu is booted into console with -nographics >> then after exiting the terminal line settings are messed >> up. This patch calls stty sane to restore the terminal >> settings to default. >> >> stty is part of coreutils which is installed on all >> host distros hence there is no need to warn about it >> being available or not >> >> Signed-off-by: Khem Raj <raj.khem@gmail.com> >> --- >> scripts/poky-qemu-internal | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/scripts/poky-qemu-internal b/scripts/poky-qemu-internal >> index 8fd1834..556ce69 100755 >> --- a/scripts/poky-qemu-internal >> +++ b/scripts/poky-qemu-internal >> @@ -189,6 +189,7 @@ cleanup() { >> echo "poky-export-rootfs stop $ROOTFS" >> poky-export-rootfs stop $ROOTFS >> fi >> + stty sane >> } >> >> n1=$[ (`echo $TAP | sed 's/tap//'` * 2) + 1 ] > > With the recent change to the script to run: > > $QEMUBIN -kernel $KERNEL $QEMUOPTIONS $SERIALOPTS -no-reboot $SCRIPT_QEMU_OPT $SCRIPT_QEMU_EXTRA_OPT --append "$KERNCMDLINE $SCRIPT_KERNEL_OPT" || stty sane > > is the above change still needed? this will only execute if the command fails I guess. But the problem happens even if qemu ran well. > > Cheers, > > Richard > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >
On Wed, 2011-03-23 at 11:13 -0700, Khem Raj wrote: > On Wed, Mar 23, 2011 at 9:53 AM, Richard Purdie > <richard.purdie@linuxfoundation.org> wrote: > > On Mon, 2011-03-21 at 11:34 -0700, Khem Raj wrote: > >> When qemu is booted into console with -nographics > >> then after exiting the terminal line settings are messed > >> up. This patch calls stty sane to restore the terminal > >> settings to default. > >> > >> stty is part of coreutils which is installed on all > >> host distros hence there is no need to warn about it > >> being available or not > >> > >> Signed-off-by: Khem Raj <raj.khem@gmail.com> > >> --- > >> scripts/poky-qemu-internal | 1 + > >> 1 files changed, 1 insertions(+), 0 deletions(-) > >> > >> diff --git a/scripts/poky-qemu-internal b/scripts/poky-qemu-internal > >> index 8fd1834..556ce69 100755 > >> --- a/scripts/poky-qemu-internal > >> +++ b/scripts/poky-qemu-internal > >> @@ -189,6 +189,7 @@ cleanup() { > >> echo "poky-export-rootfs stop $ROOTFS" > >> poky-export-rootfs stop $ROOTFS > >> fi > >> + stty sane > >> } > >> > >> n1=$[ (`echo $TAP | sed 's/tap//'` * 2) + 1 ] > > > > With the recent change to the script to run: > > > > $QEMUBIN -kernel $KERNEL $QEMUOPTIONS $SERIALOPTS -no-reboot $SCRIPT_QEMU_OPT $SCRIPT_QEMU_EXTRA_OPT --append "$KERNCMDLINE $SCRIPT_KERNEL_OPT" || stty sane > > > > is the above change still needed? > > this will only execute if the command fails I guess. But the problem > happens even if qemu ran well. Ok, I'll take your version but can you update it to remove this other stty call please? :) Cheers, Richard
Patch
diff --git a/scripts/poky-qemu-internal b/scripts/poky-qemu-internal index 8fd1834..556ce69 100755 --- a/scripts/poky-qemu-internal +++ b/scripts/poky-qemu-internal @@ -189,6 +189,7 @@ cleanup() { echo "poky-export-rootfs stop $ROOTFS" poky-export-rootfs stop $ROOTFS fi + stty sane } n1=$[ (`echo $TAP | sed 's/tap//'` * 2) + 1 ]
When qemu is booted into console with -nographics then after exiting the terminal line settings are messed up. This patch calls stty sane to restore the terminal settings to default. stty is part of coreutils which is installed on all host distros hence there is no need to warn about it being available or not Signed-off-by: Khem Raj <raj.khem@gmail.com> --- scripts/poky-qemu-internal | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)