Patchwork [01/11] gst-fluendo.inc: remove unneccessary hack

login
register
mail settings
Submitter Nitin A Kamble
Date Dec. 8, 2011, 5:48 a.m.
Message ID <664f652792df901dbc42d813b299093fa719a66a.1323323130.git.nitin.a.kamble@intel.com>
Download mbox | patch
Permalink /patch/16461/
State Accepted
Commit 81cbedaaddd589e03fe2f6cb789907b1e555a9d6
Headers show

Comments

Nitin A Kamble - Dec. 8, 2011, 5:48 a.m.
From: Nitin A Kamble <nitin.a.kamble@intel.com>

This fixes bug: [YOCTO #1403]

the custom definition of CC was causing build isuses with x32 toolchain.
And also I found out that the hack is not neccessary anymore. the
affected gst-fluendo-mpegdemux recipe builds fine without the CC hack.

Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
---
 meta/recipes-multimedia/gstreamer/gst-fluendo.inc |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
Khem Raj - Dec. 8, 2011, 7:36 a.m.
On Wed, Dec 7, 2011 at 9:48 PM,  <nitin.a.kamble@intel.com> wrote:
> From: Nitin A Kamble <nitin.a.kamble@intel.com>
>
> This fixes bug: [YOCTO #1403]
>
> the custom definition of CC was causing build isuses with x32 toolchain.
> And also I found out that the hack is not neccessary anymore. the
> affected gst-fluendo-mpegdemux recipe builds fine without the CC hack.
>
> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> ---
>  meta/recipes-multimedia/gstreamer/gst-fluendo.inc |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/meta/recipes-multimedia/gstreamer/gst-fluendo.inc b/meta/recipes-multimedia/gstreamer/gst-fluendo.inc
> index 203bdba..8b24cf7 100644
> --- a/meta/recipes-multimedia/gstreamer/gst-fluendo.inc
> +++ b/meta/recipes-multimedia/gstreamer/gst-fluendo.inc
> @@ -12,7 +12,3 @@ FILES_${PN}-dbg += "${libdir}/gstreamer-0.10/.debug"
>  FILES_${PN}-dev += "${libdir}/gstreamer-0.10/*.la ${libdir}/gstreamer-0.10/*.a"
>
>  EXTRA_OECONF = "--disable-debug --disable-valgrind"
> -
> -# Hack to get STAGING_LIBDIR into the linker path when building
> -CC = "${CCACHE} ${HOST_PREFIX}gcc -L${STAGING_LIBDIR}"
> -

this needs a PR bump
Nitin A Kamble - Dec. 8, 2011, 4:49 p.m.
> -----Original Message-----

> From: openembedded-core-bounces@lists.openembedded.org

> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of

> Khem Raj

> Sent: Wednesday, December 07, 2011 11:37 PM

> To: Patches and discussions about the oe-core layer

> Cc: hjl.tools@gmail.com

> Subject: Re: [OE-core] [PATCH 01/11] gst-fluendo.inc: remove

> unneccessary hack

> 

> On Wed, Dec 7, 2011 at 9:48 PM,  <nitin.a.kamble@intel.com> wrote:

> > From: Nitin A Kamble <nitin.a.kamble@intel.com>

> >

> > This fixes bug: [YOCTO #1403]

> >

> > the custom definition of CC was causing build isuses with x32

> toolchain.

> > And also I found out that the hack is not neccessary anymore. the

> > affected gst-fluendo-mpegdemux recipe builds fine without the CC

> hack.

> >

> > Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>

> > ---

> >  meta/recipes-multimedia/gstreamer/gst-fluendo.inc |    4 ----

> >  1 files changed, 0 insertions(+), 4 deletions(-)

> >

> > diff --git a/meta/recipes-multimedia/gstreamer/gst-fluendo.inc

> b/meta/recipes-multimedia/gstreamer/gst-fluendo.inc

> > index 203bdba..8b24cf7 100644

> > --- a/meta/recipes-multimedia/gstreamer/gst-fluendo.inc

> > +++ b/meta/recipes-multimedia/gstreamer/gst-fluendo.inc

> > @@ -12,7 +12,3 @@ FILES_${PN}-dbg += "${libdir}/gstreamer-

> 0.10/.debug"

> >  FILES_${PN}-dev += "${libdir}/gstreamer-0.10/*.la

> ${libdir}/gstreamer-0.10/*.a"

> >

> >  EXTRA_OECONF = "--disable-debug --disable-valgrind"

> > -

> > -# Hack to get STAGING_LIBDIR into the linker path when building

> > -CC = "${CCACHE} ${HOST_PREFIX}gcc -L${STAGING_LIBDIR}"

> > -

> 

> this needs a PR bump


I purposely did not bump PR here, because it does not change output of the recipe.

Nitin
> 

> _______________________________________________

> Openembedded-core mailing list

> Openembedded-core@lists.openembedded.org

> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Khem Raj - Dec. 8, 2011, 5:24 p.m.
On Thu, Dec 8, 2011 at 8:49 AM, Kamble, Nitin A
<nitin.a.kamble@intel.com> wrote:
>
>
>> -----Original Message-----
>> From: openembedded-core-bounces@lists.openembedded.org
>> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
>> Khem Raj
>> Sent: Wednesday, December 07, 2011 11:37 PM
>> To: Patches and discussions about the oe-core layer
>> Cc: hjl.tools@gmail.com
>> Subject: Re: [OE-core] [PATCH 01/11] gst-fluendo.inc: remove
>> unneccessary hack
>>
>> On Wed, Dec 7, 2011 at 9:48 PM,  <nitin.a.kamble@intel.com> wrote:
>> > From: Nitin A Kamble <nitin.a.kamble@intel.com>
>> >
>> > This fixes bug: [YOCTO #1403]
>> >
>> > the custom definition of CC was causing build isuses with x32
>> toolchain.
>> > And also I found out that the hack is not neccessary anymore. the
>> > affected gst-fluendo-mpegdemux recipe builds fine without the CC
>> hack.
>> >
>> > Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
>> > ---
>> >  meta/recipes-multimedia/gstreamer/gst-fluendo.inc |    4 ----
>> >  1 files changed, 0 insertions(+), 4 deletions(-)
>> >
>> > diff --git a/meta/recipes-multimedia/gstreamer/gst-fluendo.inc
>> b/meta/recipes-multimedia/gstreamer/gst-fluendo.inc
>> > index 203bdba..8b24cf7 100644
>> > --- a/meta/recipes-multimedia/gstreamer/gst-fluendo.inc
>> > +++ b/meta/recipes-multimedia/gstreamer/gst-fluendo.inc
>> > @@ -12,7 +12,3 @@ FILES_${PN}-dbg += "${libdir}/gstreamer-
>> 0.10/.debug"
>> >  FILES_${PN}-dev += "${libdir}/gstreamer-0.10/*.la
>> ${libdir}/gstreamer-0.10/*.a"
>> >
>> >  EXTRA_OECONF = "--disable-debug --disable-valgrind"
>> > -
>> > -# Hack to get STAGING_LIBDIR into the linker path when building
>> > -CC = "${CCACHE} ${HOST_PREFIX}gcc -L${STAGING_LIBDIR}"
>> > -
>>
>> this needs a PR bump
>
> I purposely did not bump PR here, because it does not change output of the recipe.
>

hmmm whole CC is changed if that was used before then package will
compile with different flags
wont that change the content?

Patch

diff --git a/meta/recipes-multimedia/gstreamer/gst-fluendo.inc b/meta/recipes-multimedia/gstreamer/gst-fluendo.inc
index 203bdba..8b24cf7 100644
--- a/meta/recipes-multimedia/gstreamer/gst-fluendo.inc
+++ b/meta/recipes-multimedia/gstreamer/gst-fluendo.inc
@@ -12,7 +12,3 @@  FILES_${PN}-dbg += "${libdir}/gstreamer-0.10/.debug"
 FILES_${PN}-dev += "${libdir}/gstreamer-0.10/*.la ${libdir}/gstreamer-0.10/*.a"
 
 EXTRA_OECONF = "--disable-debug --disable-valgrind"
-
-# Hack to get STAGING_LIBDIR into the linker path when building
-CC = "${CCACHE} ${HOST_PREFIX}gcc -L${STAGING_LIBDIR}"
-