Patchwork [1/2] boost : Add icu to DEPENDS to fix a build failure.

login
register
mail settings
Submitter Philip Balister
Date Dec. 7, 2011, 3:59 p.m.
Message ID <1323273568-31152-1-git-send-email-philip@balister.org>
Download mbox | patch
Permalink /patch/16399/
State New
Headers show

Comments

Philip Balister - Dec. 7, 2011, 3:59 p.m.
Part of boost needs libraries from icu. Without this, either the build or
image construction fails. (I forget exactly which)

Signed-off-by: Philip Balister <philip@balister.org>
---
 meta/recipes-support/boost/boost.inc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Richard Purdie - Dec. 7, 2011, 4:40 p.m.
On Wed, 2011-12-07 at 10:59 -0500, Philip Balister wrote:
> Part of boost needs libraries from icu. Without this, either the build or
> image construction fails. (I forget exactly which)

That is a fairly heavy dependency to add and we're not seeing builds or
images fail due to this being missing as far as I can tell. Do you have
any further information on this?

Cheers,

Richard

> Signed-off-by: Philip Balister <philip@balister.org>
> ---
>  meta/recipes-support/boost/boost.inc |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/recipes-support/boost/boost.inc b/meta/recipes-support/boost/boost.inc
> index fecdb97..a1499f6 100644
> --- a/meta/recipes-support/boost/boost.inc
> +++ b/meta/recipes-support/boost/boost.inc
> @@ -6,7 +6,7 @@
>  DESCRIPTION = "Free peer-reviewed portable C++ source libraries"
>  HOMEPAGE = "http://www.boost.org/"
>  SECTION = "libs"
> -DEPENDS = "boost-native zlib"
> +DEPENDS = "boost-native zlib icu"
>  DEPENDS_virtclass-native = ""
>  LICENSE = "Boost"
>
Philip Balister - Dec. 7, 2011, 4:49 p.m.
On 12/07/2011 11:40 AM, Richard Purdie wrote:
> On Wed, 2011-12-07 at 10:59 -0500, Philip Balister wrote:
>> Part of boost needs libraries from icu. Without this, either the build or
>> image construction fails. (I forget exactly which)
> 
> That is a fairly heavy dependency to add and we're not seeing builds or
> images fail due to this being missing as far as I can tell. Do you have
> any further information on this?

Googling gets me this page:

http://www.boost.org/doc/libs/1_41_0/libs/regex/doc/html/boost_regex/ref/non_std_strings/icu/intro.html

I'm no expert at this unicode stuff, maybe we need to nuild boost
without unicode?

Philip


> 
> Cheers,
> 
> Richard
> 
>> Signed-off-by: Philip Balister <philip@balister.org>
>> ---
>>  meta/recipes-support/boost/boost.inc |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta/recipes-support/boost/boost.inc b/meta/recipes-support/boost/boost.inc
>> index fecdb97..a1499f6 100644
>> --- a/meta/recipes-support/boost/boost.inc
>> +++ b/meta/recipes-support/boost/boost.inc
>> @@ -6,7 +6,7 @@
>>  DESCRIPTION = "Free peer-reviewed portable C++ source libraries"
>>  HOMEPAGE = "http://www.boost.org/"
>>  SECTION = "libs"
>> -DEPENDS = "boost-native zlib"
>> +DEPENDS = "boost-native zlib icu"
>>  DEPENDS_virtclass-native = ""
>>  LICENSE = "Boost"
>>  
> 
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
Richard Purdie - Dec. 7, 2011, 6:23 p.m.
On Wed, 2011-12-07 at 11:49 -0500, Philip Balister wrote:
> On 12/07/2011 11:40 AM, Richard Purdie wrote:
> > On Wed, 2011-12-07 at 10:59 -0500, Philip Balister wrote:
> >> Part of boost needs libraries from icu. Without this, either the build or
> >> image construction fails. (I forget exactly which)
> > 
> > That is a fairly heavy dependency to add and we're not seeing builds or
> > images fail due to this being missing as far as I can tell. Do you have
> > any further information on this?
> 
> Googling gets me this page:
> 
> http://www.boost.org/doc/libs/1_41_0/libs/regex/doc/html/boost_regex/ref/non_std_strings/icu/intro.html
> 
> I'm no expert at this unicode stuff, maybe we need to nuild boost
> without unicode?

That sounds preferable since I can't see how we can be using it at
present anyway. I'm hoping we can just disable that bit of boost until
somebody needs it...

Cheers,

Richard

Patch

diff --git a/meta/recipes-support/boost/boost.inc b/meta/recipes-support/boost/boost.inc
index fecdb97..a1499f6 100644
--- a/meta/recipes-support/boost/boost.inc
+++ b/meta/recipes-support/boost/boost.inc
@@ -6,7 +6,7 @@ 
 DESCRIPTION = "Free peer-reviewed portable C++ source libraries"
 HOMEPAGE = "http://www.boost.org/"
 SECTION = "libs"
-DEPENDS = "boost-native zlib"
+DEPENDS = "boost-native zlib icu"
 DEPENDS_virtclass-native = ""
 LICENSE = "Boost"