Patchwork ppl: fix libgmp paths

login
register
mail settings
Submitter Martin Jansa
Date Dec. 6, 2011, 12:27 p.m.
Message ID <1323174430-24886-1-git-send-email-Martin.Jansa@gmail.com>
Download mbox | patch
Permalink /patch/16301/
State Under Review, archived
Delegated to: Khem Raj
Headers show

Comments

Martin Jansa - Dec. 6, 2011, 12:27 p.m.
* before this patch:
configure:10139: checking how to link with libgmp
configure:10612: result: /usr/lib/libgmp.so
configure:10654: checking how to link with libgmpxx
configure:11127: result: /usr/lib/libgmpxx.so /usr/lib/libgmp.so
...
ac_cv_libgmp_cppflags=
ac_cv_libgmp_libs=/usr/lib/libgmp.so
ac_cv_libgmp_ltlibs='-L/usr/lib -lgmp'
ac_cv_libgmp_prefix=/usr
ac_cv_libgmpxx_cppflags=
ac_cv_libgmpxx_libs='/usr/lib/libgmpxx.so /usr/lib/libgmp.so'
ac_cv_libgmpxx_ltlibs='-L/usr/lib -lgmpxx -L/usr/lib -lgmp'
ac_cv_libgmpxx_prefix=/usr

* after this patch
configure:10139: checking how to link with libgmp
configure:10612: result: -lgmp
configure:10654: checking how to link with libgmpxx
configure:11127: result: -lgmpxx -lgmp
...
ac_cv_libgmp_cppflags=
ac_cv_libgmp_libs=-lgmp
ac_cv_libgmp_ltlibs=-lgmp
ac_cv_libgmp_prefix=
ac_cv_libgmpxx_cppflags=
ac_cv_libgmpxx_libs='-lgmpxx -lgmp'
ac_cv_libgmpxx_ltlibs='-lgmpxx -lgmp'
ac_cv_libgmpxx_prefix=

* but for ppl-native it worked before as well as after this patch like this:
configure:10139: checking how to link with libgmp
configure:10612: result: /OE/shr-core/tmp-eglibc/sysroots/x86_64-linux/usr/lib/libgmp.so -Wl,-rpath -Wl,/OE/shr-core/tmp-eglibc/sysroots/x86_64-linux/usr/lib
configure:10654: checking how to link with libgmpxx
configure:11127: result: /OE/shr-core/tmp-eglibc/sysroots/x86_64-linux/usr/lib/libgmpxx.so /OE/shr-core/tmp-eglibc/sysroots/x86_64-linux/usr/lib/libgmp.so -Wl,-rpath -Wl,/OE/shr-core/tmp-eglibc/sysroots/x86_64-linux/usr/lib -Wl,-rpath -Wl,/OE/shr-core/tmp-eglibc/sysroots/x86_64-linux/usr/lib

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta/recipes-support/ppl/ppl_0.11.2.bb |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
Koen Kooi - Dec. 6, 2011, 12:49 p.m.
Op 6 dec. 2011, om 13:27 heeft Martin Jansa het volgende geschreven:

[..]

> 
> ---
> meta/recipes-support/ppl/ppl_0.11.2.bb |    6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/recipes-support/ppl/ppl_0.11.2.bb b/meta/recipes-support/ppl/ppl_0.11.2.bb
> index 7536364..b31fc4d 100644
> --- a/meta/recipes-support/ppl/ppl_0.11.2.bb
> +++ b/meta/recipes-support/ppl/ppl_0.11.2.bb
> @@ -11,6 +11,10 @@ SRC_URI[sha256sum] = "e3fbd1c19ef44c6f020951807cdb6fc6a8153cd3a5c53b0ab9cf4c4f6e
> S = "${WORKDIR}/ppl-${PV}"
> BBCLASSEXTEND = "native nativesdk"
> 
> -EXTRA_OECONF = "--enable-watchdog --disable-debugging --disable-assertions --disable-ppl_lcdd --disable-ppl_lpsol --disable-ppl_pips --enable-interfaces='c cxx'"
> +# do we have something shorter then this? or can native.bbclass overwrite STAGING_DIR_HOST like nativesdk does?
> +GMP_PREFIX = "${STAGING_DIR_HOST}"
> +GMP_PREFIX_virtclass-native = "${STAGING_DIR_NATIVE}"
> +
> +EXTRA_OECONF = "--with-gmp-prefix=${GMP_PREFIX} --enable-watchdog --disable-debugging --disable-assertions --disable-ppl_lcdd --disable-ppl_lpsol --disable-ppl_pips --enable-interfaces='c cxx'"
> 
> acpaths = "-I m4"
> -- 

That is missing a PR bump :)

regards,

Koen
Khem Raj - Dec. 7, 2011, 9:19 p.m.
On (06/12/11 13:27), Martin Jansa wrote:
> configure:10654: checking how to link with libgmpxx
> configure:11127: result: /OE/shr-core/tmp-eglibc/sysroots/x86_64-linux/usr/lib/libgmpxx.so /OE/shr-core/tmp-eglibc/sysroots/x86_64-linux/usr/lib/libgmp.so -Wl,-rpath -Wl,/OE/shr-core/tmp-eglibc/sysroots/x86_64-linux/usr/lib -Wl,-rpath -Wl,/OE/shr-core/tmp-eglibc/sysroots/x86_64-linux/usr/lib
> 
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  meta/recipes-support/ppl/ppl_0.11.2.bb |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/recipes-support/ppl/ppl_0.11.2.bb b/meta/recipes-support/ppl/ppl_0.11.2.bb
> index 7536364..b31fc4d 100644
> --- a/meta/recipes-support/ppl/ppl_0.11.2.bb
> +++ b/meta/recipes-support/ppl/ppl_0.11.2.bb
> @@ -11,6 +11,10 @@ SRC_URI[sha256sum] = "e3fbd1c19ef44c6f020951807cdb6fc6a8153cd3a5c53b0ab9cf4c4f6e
>  S = "${WORKDIR}/ppl-${PV}"
>  BBCLASSEXTEND = "native nativesdk"
>  
> -EXTRA_OECONF = "--enable-watchdog --disable-debugging --disable-assertions --disable-ppl_lcdd --disable-ppl_lpsol --disable-ppl_pips --enable-interfaces='c cxx'"
> +# do we have something shorter then this? or can native.bbclass overwrite STAGING_DIR_HOST like nativesdk does?
> +GMP_PREFIX = "${STAGING_DIR_HOST}"
> +GMP_PREFIX_virtclass-native = "${STAGING_DIR_NATIVE}"
> +

I think we should override STAGING_DIR_HOST in native class as well.
Since we do install native packages into local sysroot before populating
the global native sysroot. The comment in class code seems that since
we installed the native packages in position it was needed to be unset
that may not be the case now.

RP thoughts ?
Richard Purdie - Dec. 8, 2011, 12:12 a.m.
On Wed, 2011-12-07 at 13:19 -0800, Khem Raj wrote:
> On (06/12/11 13:27), Martin Jansa wrote:
> > configure:10654: checking how to link with libgmpxx
> > configure:11127: result: /OE/shr-core/tmp-eglibc/sysroots/x86_64-linux/usr/lib/libgmpxx.so /OE/shr-core/tmp-eglibc/sysroots/x86_64-linux/usr/lib/libgmp.so -Wl,-rpath -Wl,/OE/shr-core/tmp-eglibc/sysroots/x86_64-linux/usr/lib -Wl,-rpath -Wl,/OE/shr-core/tmp-eglibc/sysroots/x86_64-linux/usr/lib
> > 
> > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > ---
> >  meta/recipes-support/ppl/ppl_0.11.2.bb |    6 +++++-
> >  1 files changed, 5 insertions(+), 1 deletions(-)
> > 
> > diff --git a/meta/recipes-support/ppl/ppl_0.11.2.bb b/meta/recipes-support/ppl/ppl_0.11.2.bb
> > index 7536364..b31fc4d 100644
> > --- a/meta/recipes-support/ppl/ppl_0.11.2.bb
> > +++ b/meta/recipes-support/ppl/ppl_0.11.2.bb
> > @@ -11,6 +11,10 @@ SRC_URI[sha256sum] = "e3fbd1c19ef44c6f020951807cdb6fc6a8153cd3a5c53b0ab9cf4c4f6e
> >  S = "${WORKDIR}/ppl-${PV}"
> >  BBCLASSEXTEND = "native nativesdk"
> >  
> > -EXTRA_OECONF = "--enable-watchdog --disable-debugging --disable-assertions --disable-ppl_lcdd --disable-ppl_lpsol --disable-ppl_pips --enable-interfaces='c cxx'"
> > +# do we have something shorter then this? or can native.bbclass overwrite STAGING_DIR_HOST like nativesdk does?
> > +GMP_PREFIX = "${STAGING_DIR_HOST}"
> > +GMP_PREFIX_virtclass-native = "${STAGING_DIR_NATIVE}"
> > +
> 
> I think we should override STAGING_DIR_HOST in native class as well.
> Since we do install native packages into local sysroot before populating
> the global native sysroot. The comment in class code seems that since
> we installed the native packages in position it was needed to be unset
> that may not be the case now.
> 
> RP thoughts ?

native.bbclass already sets STAGING_DIR_HOST correctly to be empty. It
looks wrong but its correct when you think about it since the installed
binaries are at their final location where we intent to execute them (in
${prefix}).

Cheers,

Richard
Khem Raj - Dec. 8, 2011, 8:02 a.m.
>> RP thoughts ?
>
> native.bbclass already sets STAGING_DIR_HOST correctly to be empty. It
> looks wrong but its correct when you think about it since the installed
> binaries are at their final location where we intent to execute them (in
> ${prefix}).
>

OK in this case then I think we are better of using
--with-gmp-prefix=${STAGING_EXECPREFIXDIR} here which should work for
target/native/nativesdk
variants


> Cheers,
>
> Richard
>
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-support/ppl/ppl_0.11.2.bb b/meta/recipes-support/ppl/ppl_0.11.2.bb
index 7536364..b31fc4d 100644
--- a/meta/recipes-support/ppl/ppl_0.11.2.bb
+++ b/meta/recipes-support/ppl/ppl_0.11.2.bb
@@ -11,6 +11,10 @@  SRC_URI[sha256sum] = "e3fbd1c19ef44c6f020951807cdb6fc6a8153cd3a5c53b0ab9cf4c4f6e
 S = "${WORKDIR}/ppl-${PV}"
 BBCLASSEXTEND = "native nativesdk"
 
-EXTRA_OECONF = "--enable-watchdog --disable-debugging --disable-assertions --disable-ppl_lcdd --disable-ppl_lpsol --disable-ppl_pips --enable-interfaces='c cxx'"
+# do we have something shorter then this? or can native.bbclass overwrite STAGING_DIR_HOST like nativesdk does?
+GMP_PREFIX = "${STAGING_DIR_HOST}"
+GMP_PREFIX_virtclass-native = "${STAGING_DIR_NATIVE}"
+
+EXTRA_OECONF = "--with-gmp-prefix=${GMP_PREFIX} --enable-watchdog --disable-debugging --disable-assertions --disable-ppl_lcdd --disable-ppl_lpsol --disable-ppl_pips --enable-interfaces='c cxx'"
 
 acpaths = "-I m4"