Patchwork [meta-java] openjdk-6-common: move java2-vm to RRECOMMENDS

login
register
mail settings
Submitter Koen Kooi
Date Dec. 5, 2011, 12:31 p.m.
Message ID <1323088316-20564-1-git-send-email-koen@dominion.thruhere.net>
Download mbox | patch
Permalink /patch/16163/
State New, archived
Headers show

Comments

Koen Kooi - Dec. 5, 2011, 12:31 p.m.
Even though a vm is a hard dependency it is set as RRECOMMENDS so a single vm can get uninstalled:

   root@beaglebone:~/java# opkg remove openjdk-6-vm-shark
   No packages removed.
   Collected errors:
    * print_dependents_warning: Package openjdk-6-vm-shark is depended upon by packages:
    * print_dependents_warning:         openjdk-6-java
    * print_dependents_warning: These might cease to work if package openjdk-6-vm-shark is removed.

In the above situation all vms (cacao, zero and shark) were installed, but due to llvm problems[1] shark is currently broken. To fix the java install shark needs to get uninstalled.

In theory this change allows people to break the java installation, but in practice it's already broken due to [1].

[1] http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-December/036595.html

Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
---
 recipes-core/openjdk/openjdk-6-common.inc |   11 +++++++++--
 1 files changed, 9 insertions(+), 2 deletions(-)
Koen Kooi - Dec. 7, 2011, 7:57 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

ping

Op 05-12-11 13:31, Koen Kooi schreef:
> Even though a vm is a hard dependency it is set as RRECOMMENDS so a
> single vm can get uninstalled:
> 
> root@beaglebone:~/java# opkg remove openjdk-6-vm-shark No packages
> removed. Collected errors: * print_dependents_warning: Package
> openjdk-6-vm-shark is depended upon by packages: *
> print_dependents_warning:         openjdk-6-java *
> print_dependents_warning: These might cease to work if package
> openjdk-6-vm-shark is removed.
> 
> In the above situation all vms (cacao, zero and shark) were installed,
> but due to llvm problems[1] shark is currently broken. To fix the java
> install shark needs to get uninstalled.
> 
> In theory this change allows people to break the java installation, but
> in practice it's already broken due to [1].
> 
> [1]
> http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-December/036595.html
>
>  Signed-off-by: Koen Kooi <koen@dominion.thruhere.net> --- 
> recipes-core/openjdk/openjdk-6-common.inc |   11 +++++++++-- 1 files
> changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/recipes-core/openjdk/openjdk-6-common.inc
> b/recipes-core/openjdk/openjdk-6-common.inc index ef1c41d..257fe56
> 100644 --- a/recipes-core/openjdk/openjdk-6-common.inc +++
> b/recipes-core/openjdk/openjdk-6-common.inc @@ -10,7 +10,7 @@ ICEDTEA =
> "NEEDS TO BE SET" S = "${WORKDIR}/${ICEDTEA}" B = "${S}/build"
> 
> -INC_PR = "r11" +INC_PR = "r12"
> 
> SRC_URI = "\ ${ICEDTEA_URI} \ @@ -426,7 +426,14 @@
> RPROVIDES_${JDKPN}-vm-shark = "java2-vm" RPROVIDES_${JDKPN}-vm-zero =
> "java2-vm" RPROVIDES_${JDKPN}-vm-cacao = "java2-vm"
> 
> -RDEPENDS_${JDKPN}-java = "java2-vm" +# Even though a vm is a hard
> dependency it is set as RRECOMMENDS so a single vm can get uninstalled: 
> +# root@beaglebone:~/java# opkg remove openjdk-6-vm-shark +# No packages
> removed. +# Collected errors: +#  * print_dependents_warning: Package
> openjdk-6-vm-shark is depended upon by packages: +#  *
> print_dependents_warning: 	openjdk-6-java +#  * print_dependents_warning:
> These might cease to work if package openjdk-6-vm-shark is removed. 
> +RRECOMMENDS_${JDKPN}-java = "java2-vm"
> 
> # For some reason shark and cacao do not automatically depends on
> -common. # So we add that manually.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (Darwin)
Comment: GPGTools - http://gpgtools.org

iEYEARECAAYFAk7fHF0ACgkQMkyGM64RGpF3FgCfRixFz4cNEI7OdLfkulNHjp/U
Zi4An0KRfx/jCebXGK67GpFziay5CMHp
=Xnc1
-----END PGP SIGNATURE-----
Henning Heinold - Dec. 21, 2011, 5:59 p.m.
On Wed, Dec 07, 2011 at 08:57:17AM +0100, Koen Kooi wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> ping

Thanks for the patch, its pushed.
> 
> Op 05-12-11 13:31, Koen Kooi schreef:
> > Even though a vm is a hard dependency it is set as RRECOMMENDS so a
> > single vm can get uninstalled:
> > 
> > root@beaglebone:~/java# opkg remove openjdk-6-vm-shark No packages
> > removed. Collected errors: * print_dependents_warning: Package
> > openjdk-6-vm-shark is depended upon by packages: *
> > print_dependents_warning:         openjdk-6-java *
> > print_dependents_warning: These might cease to work if package
> > openjdk-6-vm-shark is removed.
> > 
> > In the above situation all vms (cacao, zero and shark) were installed,
> > but due to llvm problems[1] shark is currently broken. To fix the java
> > install shark needs to get uninstalled.
> > 
> > In theory this change allows people to break the java installation, but
> > in practice it's already broken due to [1].
> > 
> > [1]
> > http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-December/036595.html
> >
> >  Signed-off-by: Koen Kooi <koen@dominion.thruhere.net> --- 
> > recipes-core/openjdk/openjdk-6-common.inc |   11 +++++++++-- 1 files
> > changed, 9 insertions(+), 2 deletions(-)
> > 
> > diff --git a/recipes-core/openjdk/openjdk-6-common.inc
> > b/recipes-core/openjdk/openjdk-6-common.inc index ef1c41d..257fe56
> > 100644 --- a/recipes-core/openjdk/openjdk-6-common.inc +++
> > b/recipes-core/openjdk/openjdk-6-common.inc @@ -10,7 +10,7 @@ ICEDTEA =
> > "NEEDS TO BE SET" S = "${WORKDIR}/${ICEDTEA}" B = "${S}/build"
> > 
> > -INC_PR = "r11" +INC_PR = "r12"
> > 
> > SRC_URI = "\ ${ICEDTEA_URI} \ @@ -426,7 +426,14 @@
> > RPROVIDES_${JDKPN}-vm-shark = "java2-vm" RPROVIDES_${JDKPN}-vm-zero =
> > "java2-vm" RPROVIDES_${JDKPN}-vm-cacao = "java2-vm"
> > 
> > -RDEPENDS_${JDKPN}-java = "java2-vm" +# Even though a vm is a hard
> > dependency it is set as RRECOMMENDS so a single vm can get uninstalled: 
> > +# root@beaglebone:~/java# opkg remove openjdk-6-vm-shark +# No packages
> > removed. +# Collected errors: +#  * print_dependents_warning: Package
> > openjdk-6-vm-shark is depended upon by packages: +#  *
> > print_dependents_warning: 	openjdk-6-java +#  * print_dependents_warning:
> > These might cease to work if package openjdk-6-vm-shark is removed. 
> > +RRECOMMENDS_${JDKPN}-java = "java2-vm"
> > 
> > # For some reason shark and cacao do not automatically depends on
> > -common. # So we add that manually.
> 
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (Darwin)
> Comment: GPGTools - http://gpgtools.org
> 
> iEYEARECAAYFAk7fHF0ACgkQMkyGM64RGpF3FgCfRixFz4cNEI7OdLfkulNHjp/U
> Zi4An0KRfx/jCebXGK67GpFziay5CMHp
> =Xnc1
> -----END PGP SIGNATURE-----
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Patch

diff --git a/recipes-core/openjdk/openjdk-6-common.inc b/recipes-core/openjdk/openjdk-6-common.inc
index ef1c41d..257fe56 100644
--- a/recipes-core/openjdk/openjdk-6-common.inc
+++ b/recipes-core/openjdk/openjdk-6-common.inc
@@ -10,7 +10,7 @@  ICEDTEA = "NEEDS TO BE SET"
 S = "${WORKDIR}/${ICEDTEA}"
 B = "${S}/build"
 
-INC_PR = "r11"
+INC_PR = "r12"
 
 SRC_URI = "\
   ${ICEDTEA_URI} \
@@ -426,7 +426,14 @@  RPROVIDES_${JDKPN}-vm-shark = "java2-vm"
 RPROVIDES_${JDKPN}-vm-zero = "java2-vm"
 RPROVIDES_${JDKPN}-vm-cacao = "java2-vm"
 
-RDEPENDS_${JDKPN}-java = "java2-vm"
+# Even though a vm is a hard dependency it is set as RRECOMMENDS so a single vm can get uninstalled:
+# root@beaglebone:~/java# opkg remove openjdk-6-vm-shark 
+# No packages removed.
+# Collected errors:
+#  * print_dependents_warning: Package openjdk-6-vm-shark is depended upon by packages:
+#  * print_dependents_warning: 	openjdk-6-java
+#  * print_dependents_warning: These might cease to work if package openjdk-6-vm-shark is removed.
+RRECOMMENDS_${JDKPN}-java = "java2-vm"
 
 # For some reason shark and cacao do not automatically depends on -common.
 # So we add that manually.