Patchwork [01/11] gst-fluendo-mpegdemux: rework the CC hack

login
register
mail settings
Submitter Nitin A Kamble
Date Dec. 2, 2011, 8:19 p.m.
Message ID <a92d45d71d2d4aec2774e8feb23fcfdffaa8b2bc.1322856805.git.nitin.a.kamble@intel.com>
Download mbox | patch
Permalink /patch/16123/
State New
Headers show

Comments

Nitin A Kamble - Dec. 2, 2011, 8:19 p.m.
From: Nitin A Kamble <nitin.a.kamble@intel.com>

This fixes bug: [YOCTO #1403]

Earlier hack was breaking compiler parameters set by tune settings. And that caused x32
build failure. Now previous CC parameters are kept intact while adding new -L parameter.

Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
---
 meta/recipes-multimedia/gstreamer/gst-fluendo.inc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Khem Raj - Dec. 3, 2011, 5:53 p.m.
On Fri, Dec 2, 2011 at 12:19 PM,  <nitin.a.kamble@intel.com> wrote:
> From: Nitin A Kamble <nitin.a.kamble@intel.com>
>
> This fixes bug: [YOCTO #1403]
>
> Earlier hack was breaking compiler parameters set by tune settings. And that caused x32
> build failure. Now previous CC parameters are kept intact while adding new -L parameter.
>
> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> ---
>  meta/recipes-multimedia/gstreamer/gst-fluendo.inc |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-multimedia/gstreamer/gst-fluendo.inc b/meta/recipes-multimedia/gstreamer/gst-fluendo.inc
> index 203bdba..9615454 100644
> --- a/meta/recipes-multimedia/gstreamer/gst-fluendo.inc
> +++ b/meta/recipes-multimedia/gstreamer/gst-fluendo.inc
> @@ -14,5 +14,5 @@ FILES_${PN}-dev += "${libdir}/gstreamer-0.10/*.la ${libdir}/gstreamer-0.10/*.a"
>  EXTRA_OECONF = "--disable-debug --disable-valgrind"
>
>  # Hack to get STAGING_LIBDIR into the linker path when building
> -CC = "${CCACHE} ${HOST_PREFIX}gcc -L${STAGING_LIBDIR}"
> +CC += "-L${STAGING_LIBDIR}"

This looks like part of LDFLAGS more than CC to me.
Nitin A Kamble - Dec. 5, 2011, 4:59 p.m.
Hi Khem,
  Makes sense. Will try to change the fix accordingly.
Thanks,
Nitin


> -----Original Message-----

> From: openembedded-core-bounces@lists.openembedded.org

> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of

> Khem Raj

> Sent: Saturday, December 03, 2011 9:53 AM

> To: Patches and discussions about the oe-core layer

> Cc: hjl.tools@gmail.com

> Subject: Re: [OE-core] [PATCH 01/11] gst-fluendo-mpegdemux: rework the

> CC hack

> 

> On Fri, Dec 2, 2011 at 12:19 PM,  <nitin.a.kamble@intel.com> wrote:

> > From: Nitin A Kamble <nitin.a.kamble@intel.com>

> >

> > This fixes bug: [YOCTO #1403]

> >

> > Earlier hack was breaking compiler parameters set by tune settings.

> And that caused x32

> > build failure. Now previous CC parameters are kept intact while

> adding new -L parameter.

> >

> > Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>

> > ---

> >  meta/recipes-multimedia/gstreamer/gst-fluendo.inc |    2 +-

> >  1 files changed, 1 insertions(+), 1 deletions(-)

> >

> > diff --git a/meta/recipes-multimedia/gstreamer/gst-fluendo.inc

> b/meta/recipes-multimedia/gstreamer/gst-fluendo.inc

> > index 203bdba..9615454 100644

> > --- a/meta/recipes-multimedia/gstreamer/gst-fluendo.inc

> > +++ b/meta/recipes-multimedia/gstreamer/gst-fluendo.inc

> > @@ -14,5 +14,5 @@ FILES_${PN}-dev += "${libdir}/gstreamer-0.10/*.la

> ${libdir}/gstreamer-0.10/*.a"

> >  EXTRA_OECONF = "--disable-debug --disable-valgrind"

> >

> >  # Hack to get STAGING_LIBDIR into the linker path when building

> > -CC = "${CCACHE} ${HOST_PREFIX}gcc -L${STAGING_LIBDIR}"

> > +CC += "-L${STAGING_LIBDIR}"

> 

> This looks like part of LDFLAGS more than CC to me.

> 

> _______________________________________________

> Openembedded-core mailing list

> Openembedded-core@lists.openembedded.org

> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-multimedia/gstreamer/gst-fluendo.inc b/meta/recipes-multimedia/gstreamer/gst-fluendo.inc
index 203bdba..9615454 100644
--- a/meta/recipes-multimedia/gstreamer/gst-fluendo.inc
+++ b/meta/recipes-multimedia/gstreamer/gst-fluendo.inc
@@ -14,5 +14,5 @@  FILES_${PN}-dev += "${libdir}/gstreamer-0.10/*.la ${libdir}/gstreamer-0.10/*.a"
 EXTRA_OECONF = "--disable-debug --disable-valgrind"
 
 # Hack to get STAGING_LIBDIR into the linker path when building
-CC = "${CCACHE} ${HOST_PREFIX}gcc -L${STAGING_LIBDIR}"
+CC += "-L${STAGING_LIBDIR}"