Patchwork [0/1] Make missing checksums an error

login
register
mail settings
Submitter Joshua Lock
Date Dec. 2, 2011, 7:20 p.m.
Message ID <cover.1322853315.git.josh@linux.intel.com>
Download mbox
Permalink /patch/16119/
State New
Headers show

Pull-request

git://git.openembedded.org/openembedded-core-contrib josh/checksums

Comments

Joshua Lock - Dec. 2, 2011, 7:20 p.m.
NOTE: this requires a patch I sent to the BitBake list[1] to error cleanly,
otherwise you'll see a Python backtrace and the build fail...

Per some discussion on the list recently this patch sets BB_STRICT_CHECKSUM
in the default-distrovars.inc so that missing checksums in recipes raises an
error.

Cheers,
Joshua

1. lists.linuxtogo.org/pipermail/bitbake-devel/2011-December/thread.html 

The following changes since commit 044324465bd54d53ae768f3c1e7468ae0e0c6200:

  dpkg-native: Fix perl path (2011-12-02 15:31:03 +0000)

are available in the git repository at:
  git://git.openembedded.org/openembedded-core-contrib josh/checksums
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=josh/checksums

Joshua Lock (1):
  default-distrovars: missing checksums should raise an error

 meta/conf/distro/include/default-distrovars.inc |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
Joshua Lock - Dec. 5, 2011, 9:50 p.m.
On 02/12/11 11:20, Joshua Lock wrote:
> NOTE: this requires a patch I sent to the BitBake list[1] to error cleanly,
> otherwise you'll see a Python backtrace and the build fail...

This patch has now been merged into BitBake master.

Cheers,
Joshua
Richard Purdie - Dec. 5, 2011, 10:50 p.m.
On Fri, 2011-12-02 at 11:20 -0800, Joshua Lock wrote:
> NOTE: this requires a patch I sent to the BitBake list[1] to error cleanly,
> otherwise you'll see a Python backtrace and the build fail...
> 
> Per some discussion on the list recently this patch sets BB_STRICT_CHECKSUM
> in the default-distrovars.inc so that missing checksums in recipes raises an
> error.
> 
> Cheers,
> Joshua

What's the state of master? If I merge this, how badly do things
explode?

Cheers,

Richard
Joshua Lock - Dec. 5, 2011, 10:55 p.m.
On 05/12/11 14:50, Richard Purdie wrote:
> On Fri, 2011-12-02 at 11:20 -0800, Joshua Lock wrote:
>> NOTE: this requires a patch I sent to the BitBake list[1] to error cleanly,
>> otherwise you'll see a Python backtrace and the build fail...
>>
>> Per some discussion on the list recently this patch sets BB_STRICT_CHECKSUM
>> in the default-distrovars.inc so that missing checksums in recipes raises an
>> error.
>>
>> Cheers,
>> Joshua
> 
> What's the state of master? If I merge this, how badly do things
> explode?

Let me run a universe fetchall and get back to you...

Joshua
Joshua Lock - Dec. 6, 2011, 2:13 a.m.
On 05/12/11 14:55, Joshua Lock wrote:
> On 05/12/11 14:50, Richard Purdie wrote:
>> On Fri, 2011-12-02 at 11:20 -0800, Joshua Lock wrote:
>>> NOTE: this requires a patch I sent to the BitBake list[1] to error cleanly,
>>> otherwise you'll see a Python backtrace and the build fail...
>>>
>>> Per some discussion on the list recently this patch sets BB_STRICT_CHECKSUM
>>> in the default-distrovars.inc so that missing checksums in recipes raises an
>>> error.
>>>
>>> Cheers,
>>> Joshua
>>
>> What's the state of master? If I merge this, how badly do things
>> explode?
> 
> Let me run a universe fetchall and get back to you...

Two recipes in oe-core require checksums adding, puzzles and
omap3-sgx-modules - a v2 of this request with those patches is incoming.

Joshua
Koen Kooi - Dec. 6, 2011, 7:18 a.m.
Op 6 dec. 2011, om 03:13 heeft Joshua Lock het volgende geschreven:

> 
> 
> On 05/12/11 14:55, Joshua Lock wrote:
>> On 05/12/11 14:50, Richard Purdie wrote:
>>> On Fri, 2011-12-02 at 11:20 -0800, Joshua Lock wrote:
>>>> NOTE: this requires a patch I sent to the BitBake list[1] to error cleanly,
>>>> otherwise you'll see a Python backtrace and the build fail...
>>>> 
>>>> Per some discussion on the list recently this patch sets BB_STRICT_CHECKSUM
>>>> in the default-distrovars.inc so that missing checksums in recipes raises an
>>>> error.
>>>> 
>>>> Cheers,
>>>> Joshua
>>> 
>>> What's the state of master? If I merge this, how badly do things
>>> explode?
>> 
>> Let me run a universe fetchall and get back to you...
> 
> Two recipes in oe-core require checksums adding, puzzles and
> omap3-sgx-modules - a v2 of this request with those patches is incoming.

Omap3-sgx-modules has no place in OE-core, so it should get deleted.

regards,

KOen
Paul Eggleton - Dec. 6, 2011, 10:33 a.m.
On Tuesday 06 December 2011 08:18:30 Koen Kooi wrote:
> Omap3-sgx-modules has no place in OE-core, so it should get deleted.

Sounds good, would you mind sending a patch that does that?

Cheers,
Paul