Patchwork [RFC,0/2] introduce buildhistory.bbclass

login
register
mail settings
Submitter Paul Eggleton
Date Dec. 1, 2011, 11:56 p.m.
Message ID <cover.1322782677.git.paul.eggleton@linux.intel.com>
Download mbox
Permalink /patch/16019/
State Superseded
Headers show

Pull-request

git://git.openembedded.org/openembedded-core-contrib paule/buildhistory

Comments

Paul Eggleton - Dec. 1, 2011, 11:56 p.m.
Here is the initial version of buildhistory.bbclass. It provides (most
of) the functionality of testlab.bbclass and all functionality of
packagehistory.bbclass.

Changes/improvements over testlab:
* Supports both rpm and ipk-based images
* Works even if packaging data is removed in the final image
* File listing is tidier and excludes date/time info so changes are more
  obvious
* Produces a separate package list with just the package names (i.e. not
  the full file name).
* Optional git commit occurs at the end of the build and is done outside
  of fakeroot
* Can optionally push git commit to a remote repository

Todo items:
* There is no recording of licenses into the build history, in favour of
  Beth Flanagan's upcoming work on license.bbclass. I appreciate some may
  want this tracked in buildhistory - please comment. Could be something
  to add afterwards when Beth's work is integrated.
* Deb-based packaging is not supported because I am unable to test it
  (see Yocto bug #1802).

Note that an earlier version of this was merged accidentally to OE-core;
this was subsequently reverted to allow proper review.


Please review the following changes for suitability for inclusion. If you have
any objections or suggestions for improvement, please respond to the patches. If
you agree with the changes, please provide your Acked-by.

The following changes since commit e57935dc18d576feb1003b48e7cdc72a444131b8:

  Revert "classes/buildhistory: add new output history collection class" (2011-12-01 23:00:52 +0000)

are available in the git repository at:
  git://git.openembedded.org/openembedded-core-contrib paule/buildhistory
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/buildhistory

Paul Eggleton (2):
  classes/buildhistory: add new output history collection class
  classes/buildhistory: merge in package history functionality

 meta/classes/buildhistory.bbclass |  359 +++++++++++++++++++++++++++++++++++++
 meta/classes/rootfs_ipk.bbclass   |   27 +++-
 meta/classes/rootfs_rpm.bbclass   |   41 ++++-
 3 files changed, 421 insertions(+), 6 deletions(-)
 create mode 100644 meta/classes/buildhistory.bbclass
Richard Purdie - Dec. 5, 2011, 4:24 p.m.
On Thu, 2011-12-01 at 23:56 +0000, Paul Eggleton wrote:
> Here is the initial version of buildhistory.bbclass. It provides (most
> of) the functionality of testlab.bbclass and all functionality of
> packagehistory.bbclass.
> 
> Changes/improvements over testlab:
> * Supports both rpm and ipk-based images
> * Works even if packaging data is removed in the final image
> * File listing is tidier and excludes date/time info so changes are more
>   obvious
> * Produces a separate package list with just the package names (i.e. not
>   the full file name).
> * Optional git commit occurs at the end of the build and is done outside
>   of fakeroot
> * Can optionally push git commit to a remote repository
> 
> Todo items:
> * There is no recording of licenses into the build history, in favour of
>   Beth Flanagan's upcoming work on license.bbclass. I appreciate some may
>   want this tracked in buildhistory - please comment. Could be something
>   to add afterwards when Beth's work is integrated.
> * Deb-based packaging is not supported because I am unable to test it
>   (see Yocto bug #1802).
> 
> Note that an earlier version of this was merged accidentally to OE-core;
> this was subsequently reverted to allow proper review.
> 
> 
> Please review the following changes for suitability for inclusion. If you have
> any objections or suggestions for improvement, please respond to the patches. If
> you agree with the changes, please provide your Acked-by.
> 
> The following changes since commit e57935dc18d576feb1003b48e7cdc72a444131b8:
> 
>   Revert "classes/buildhistory: add new output history collection class" (2011-12-01 23:00:52 +0000)
> 
> are available in the git repository at:
>   git://git.openembedded.org/openembedded-core-contrib paule/buildhistory
>   http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/buildhistory
> 
> Paul Eggleton (2):
>   classes/buildhistory: add new output history collection class
>   classes/buildhistory: merge in package history functionality

I've merged this. I don't think its perfect and I know Koen has found
one potential issue but it provides a base people can send patches
against :)

Cheers,

Richard
Koen Kooi - Dec. 5, 2011, 4:51 p.m.
Op 5 dec. 2011, om 17:24 heeft Richard Purdie het volgende geschreven:

> On Thu, 2011-12-01 at 23:56 +0000, Paul Eggleton wrote:
>> 
>> Paul Eggleton (2):
>>  classes/buildhistory: add new output history collection class
>>  classes/buildhistory: merge in package history functionality
> 
> I've merged this. I don't think its perfect and I know Koen has found
> one potential issue but it provides a base people can send patches
> against :)

Awesome! 2 less patches for me to carry locally :)

regards,

Koen