Patchwork xfce_session_4.6.{1, 2}: explicitly pass the path of `iceauth`

login
register
mail settings
Submitter Paul Menzel
Date March 18, 2011, noon
Message ID <1300449625.3830.47.camel@mattotaupa>
Download mbox | patch
Permalink /patch/1595/
State Accepted
Commit 7aeb138d8c113e6c8da7d3c6804520251cd4b8ba
Headers show

Comments

Paul Menzel - March 18, 2011, noon
Date: Fri, 18 Mar 2011 12:03:43 +0100

Xfce Session build depends on the executable `iceauth`, which fails when cross compiling for a different architecture.

        checking if the linker (arm-oe-linux-gnueabi-ld --sysroot=/oe/build-minimal-eglibc/minimal-dev/sysroots/armv5te-oe-linux-gnueabi) is GNU ld... (cached) yes
        checking whether to build with profiling support... no
        checking whether to compile with coverage profiling instrumentation... no
        checking whether to disable assertions... no
        checking whether to build final version... yes
        checking whether arm-oe-linux-gnueabi-ld --sysroot=/oe/build-minimal-eglibc/minimal-dev/sysroots/armv5te-oe-linux-gnueabi accepts -O1... yes
        checking for iceauth... no
        configure: error: iceauth missing, please check your X11 installation

As suggested by Khem Raj [1] pass the value – `/usr/bin/iceauth` is taken – to the configure script so that the test is avoided.

Therefore `iceauth` is removed from `DEPENDS` and the `PR` variable is incremented.

This issue has been reported upstream as ticket #7420 [2].

[1] http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-March/031115.html
[2] http://bugzilla.xfce.org/show_bug.cgi?id=7420

Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
---
 recipes/xfce-base/xfce4-session_4.6.1.bb |    6 ++++--
 recipes/xfce-base/xfce4-session_4.6.2.bb |    6 ++++--
 2 files changed, 8 insertions(+), 4 deletions(-)
Khem Raj - March 19, 2011, 6:33 p.m.
On (18/03/11 13:00), Paul Menzel wrote:
> Date: Fri, 18 Mar 2011 12:03:43 +0100
> 
> Xfce Session build depends on the executable `iceauth`, which fails when cross compiling for a different architecture.
> 
>         checking if the linker (arm-oe-linux-gnueabi-ld --sysroot=/oe/build-minimal-eglibc/minimal-dev/sysroots/armv5te-oe-linux-gnueabi) is GNU ld... (cached) yes
>         checking whether to build with profiling support... no
>         checking whether to compile with coverage profiling instrumentation... no
>         checking whether to disable assertions... no
>         checking whether to build final version... yes
>         checking whether arm-oe-linux-gnueabi-ld --sysroot=/oe/build-minimal-eglibc/minimal-dev/sysroots/armv5te-oe-linux-gnueabi accepts -O1... yes
>         checking for iceauth... no
>         configure: error: iceauth missing, please check your X11 installation
> 
> As suggested by Khem Raj [1] pass the value – `/usr/bin/iceauth` is taken – to the configure script so that the test is avoided.
> 
> Therefore `iceauth` is removed from `DEPENDS` and the `PR` variable is incremented.
> 
> This issue has been reported upstream as ticket #7420 [2].
> 
> [1] http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-March/031115.html
> [2] http://bugzilla.xfce.org/show_bug.cgi?id=7420
> 
> Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
> ---
>  recipes/xfce-base/xfce4-session_4.6.1.bb |    6 ++++--
>  recipes/xfce-base/xfce4-session_4.6.2.bb |    6 ++++--
>  2 files changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/recipes/xfce-base/xfce4-session_4.6.1.bb b/recipes/xfce-base/xfce4-session_4.6.1.bb
> index ba66ac1..5029b21 100644
> --- a/recipes/xfce-base/xfce4-session_4.6.1.bb
> +++ b/recipes/xfce-base/xfce4-session_4.6.1.bb
> @@ -1,13 +1,15 @@
>  DESCRIPTION = "xfce4-session is a session manager for Xfce 4 Desktop Environment"
> -DEPENDS = "lbwnck libxfcegui4 libxfce4util dbus iceauth xfce-utils"
> +DEPENDS = "lbwnck libxfcegui4 libxfce4util dbus xfce-utils"
>  SECTION = "x11"
>  
> -PR = "r4"
> +PR = "r5"
>  
>  inherit xfce46
>  
>  RDEPENDS_${PN} = "iceauth xfce-utils xinit dbus-x11"
>  
> +EXTRA_OECONF += "ac_cv_path_ICEAUTH=/usr/bin/iceauth"

Would it make sense to have iceauth-native instead ?
> +
>  FILES_${PN} += "${libdir}/xfce4/splash/engines/*.so"
>  FILES_${PN} += "${datadir}/xfce4/tips/*"
>  FILES_${PN} += "${datadir}/themes/Default/balou/*"
> diff --git a/recipes/xfce-base/xfce4-session_4.6.2.bb b/recipes/xfce-base/xfce4-session_4.6.2.bb
> index d7f768a..c937775 100644
> --- a/recipes/xfce-base/xfce4-session_4.6.2.bb
> +++ b/recipes/xfce-base/xfce4-session_4.6.2.bb
> @@ -1,13 +1,15 @@
>  DESCRIPTION = "xfce4-session is a session manager for Xfce 4 Desktop Environment"
> -DEPENDS = "libwnck libxfcegui4 libxfce4util dbus iceauth xfce-utils"
> +DEPENDS = "libwnck libxfcegui4 libxfce4util dbus xfce-utils"
>  SECTION = "x11"
>  
> -PR = "r0"
> +PR = "r1"
>  
>  inherit xfce46
>  
>  RDEPENDS_${PN} = "iceauth xfce-utils xinit dbus-x11"
>  
> +EXTRA_OECONF += "ac_cv_path_ICEAUTH=/usr/bin/iceauth"
> +
>  FILES_${PN} += "${libdir}/xfce4/splash/engines/*.so"
>  FILES_${PN} += "${datadir}/xfce4/tips/*"
>  FILES_${PN} += "${datadir}/themes/Default/balou/*"
> -- 
> 1.7.4.1



> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Paul Menzel - March 20, 2011, 1:10 a.m.
Am Samstag, den 19.03.2011, 11:33 -0700 schrieb Khem Raj:
> On (18/03/11 13:00), Paul Menzel wrote:
> > Date: Fri, 18 Mar 2011 12:03:43 +0100
> > 
> > Xfce Session build depends on the executable `iceauth`, which fails when cross compiling for a different architecture.
> > 
> >         checking if the linker (arm-oe-linux-gnueabi-ld --sysroot=/oe/build-minimal-eglibc/minimal-dev/sysroots/armv5te-oe-linux-gnueabi) is GNU ld... (cached) yes
> >         checking whether to build with profiling support... no
> >         checking whether to compile with coverage profiling instrumentation... no
> >         checking whether to disable assertions... no
> >         checking whether to build final version... yes
> >         checking whether arm-oe-linux-gnueabi-ld --sysroot=/oe/build-minimal-eglibc/minimal-dev/sysroots/armv5te-oe-linux-gnueabi accepts -O1... yes
> >         checking for iceauth... no
> >         configure: error: iceauth missing, please check your X11 installation
> > 
> > As suggested by Khem Raj [1] pass the value – `/usr/bin/iceauth` is taken – to the configure script so that the test is avoided.
> > 
> > Therefore `iceauth` is removed from `DEPENDS` and the `PR` variable is incremented.
> > 
> > This issue has been reported upstream as ticket #7420 [2].
> > 
> > [1] http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-March/031115.html
> > [2] http://bugzilla.xfce.org/show_bug.cgi?id=7420
> > 
> > Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
> > ---
> >  recipes/xfce-base/xfce4-session_4.6.1.bb |    6 ++++--
> >  recipes/xfce-base/xfce4-session_4.6.2.bb |    6 ++++--
> >  2 files changed, 8 insertions(+), 4 deletions(-)
> > 
> > diff --git a/recipes/xfce-base/xfce4-session_4.6.1.bb b/recipes/xfce-base/xfce4-session_4.6.1.bb
> > index ba66ac1..5029b21 100644
> > --- a/recipes/xfce-base/xfce4-session_4.6.1.bb
> > +++ b/recipes/xfce-base/xfce4-session_4.6.1.bb
> > @@ -1,13 +1,15 @@
> >  DESCRIPTION = "xfce4-session is a session manager for Xfce 4 Desktop Environment"
> > -DEPENDS = "lbwnck libxfcegui4 libxfce4util dbus iceauth xfce-utils"
> > +DEPENDS = "lbwnck libxfcegui4 libxfce4util dbus xfce-utils"
> >  SECTION = "x11"
> >  
> > -PR = "r4"
> > +PR = "r5"
> >  
> >  inherit xfce46
> >  
> >  RDEPENDS_${PN} = "iceauth xfce-utils xinit dbus-x11"
> >  
> > +EXTRA_OECONF += "ac_cv_path_ICEAUTH=/usr/bin/iceauth"
> 
> Would it make sense to have iceauth-native instead ?

It never really executes `iceauth` during compile time but just during
configure to determine the runtime path. So `iceauth-native` is not
needed and would be even result in the wrong path, I think.

> >  FILES_${PN} += "${libdir}/xfce4/splash/engines/*.so"
> >  FILES_${PN} += "${datadir}/xfce4/tips/*"
> >  FILES_${PN} += "${datadir}/themes/Default/balou/*"
> > diff --git a/recipes/xfce-base/xfce4-session_4.6.2.bb b/recipes/xfce-base/xfce4-session_4.6.2.bb
> > index d7f768a..c937775 100644
> > --- a/recipes/xfce-base/xfce4-session_4.6.2.bb
> > +++ b/recipes/xfce-base/xfce4-session_4.6.2.bb
> > @@ -1,13 +1,15 @@
> >  DESCRIPTION = "xfce4-session is a session manager for Xfce 4 Desktop Environment"
> > -DEPENDS = "libwnck libxfcegui4 libxfce4util dbus iceauth xfce-utils"
> > +DEPENDS = "libwnck libxfcegui4 libxfce4util dbus xfce-utils"
> >  SECTION = "x11"
> >  
> > -PR = "r0"
> > +PR = "r1"
> >  
> >  inherit xfce46
> >  
> >  RDEPENDS_${PN} = "iceauth xfce-utils xinit dbus-x11"
> >  
> > +EXTRA_OECONF += "ac_cv_path_ICEAUTH=/usr/bin/iceauth"
> > +
> >  FILES_${PN} += "${libdir}/xfce4/splash/engines/*.so"
> >  FILES_${PN} += "${datadir}/xfce4/tips/*"
> >  FILES_${PN} += "${datadir}/themes/Default/balou/*"
> > -- 
> > 1.7.4.1
Khem Raj - March 20, 2011, 4:32 a.m.
On 3/19/2011 6:10 PM, Paul Menzel wrote:
> Am Samstag, den 19.03.2011, 11:33 -0700 schrieb Khem Raj:
>> On (18/03/11 13:00), Paul Menzel wrote:
>>> Date: Fri, 18 Mar 2011 12:03:43 +0100
>>>
>>> Xfce Session build depends on the executable `iceauth`, which fails when cross compiling for a different architecture.
>>>
>>>          checking if the linker (arm-oe-linux-gnueabi-ld --sysroot=/oe/build-minimal-eglibc/minimal-dev/sysroots/armv5te-oe-linux-gnueabi) is GNU ld... (cached) yes
>>>          checking whether to build with profiling support... no
>>>          checking whether to compile with coverage profiling instrumentation... no
>>>          checking whether to disable assertions... no
>>>          checking whether to build final version... yes
>>>          checking whether arm-oe-linux-gnueabi-ld --sysroot=/oe/build-minimal-eglibc/minimal-dev/sysroots/armv5te-oe-linux-gnueabi accepts -O1... yes
>>>          checking for iceauth... no
>>>          configure: error: iceauth missing, please check your X11 installation
>>>
>>> As suggested by Khem Raj [1] pass the value – `/usr/bin/iceauth` is taken – to the configure script so that the test is avoided.
>>>
>>> Therefore `iceauth` is removed from `DEPENDS` and the `PR` variable is incremented.
>>>
>>> This issue has been reported upstream as ticket #7420 [2].
>>>
>>> [1] http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-March/031115.html
>>> [2] http://bugzilla.xfce.org/show_bug.cgi?id=7420
>>>
>>> Signed-off-by: Paul Menzel<paulepanter@users.sourceforge.net>
>>> ---
>>>   recipes/xfce-base/xfce4-session_4.6.1.bb |    6 ++++--
>>>   recipes/xfce-base/xfce4-session_4.6.2.bb |    6 ++++--
>>>   2 files changed, 8 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/recipes/xfce-base/xfce4-session_4.6.1.bb b/recipes/xfce-base/xfce4-session_4.6.1.bb
>>> index ba66ac1..5029b21 100644
>>> --- a/recipes/xfce-base/xfce4-session_4.6.1.bb
>>> +++ b/recipes/xfce-base/xfce4-session_4.6.1.bb
>>> @@ -1,13 +1,15 @@
>>>   DESCRIPTION = "xfce4-session is a session manager for Xfce 4 Desktop Environment"
>>> -DEPENDS = "lbwnck libxfcegui4 libxfce4util dbus iceauth xfce-utils"
>>> +DEPENDS = "lbwnck libxfcegui4 libxfce4util dbus xfce-utils"
>>>   SECTION = "x11"
>>>
>>> -PR = "r4"
>>> +PR = "r5"
>>>
>>>   inherit xfce46
>>>
>>>   RDEPENDS_${PN} = "iceauth xfce-utils xinit dbus-x11"
>>>
>>> +EXTRA_OECONF += "ac_cv_path_ICEAUTH=/usr/bin/iceauth"
>>
>> Would it make sense to have iceauth-native instead ?
>
> It never really executes `iceauth` during compile time but just during
> configure to determine the runtime path. So `iceauth-native` is not
> needed and would be even result in the wrong path, I think.

weather it executes is during configure or during compile how does it 
matter ? in the end it needs iceauth and it will mean that you will ask
folks to have iceauth on their build host which is what I am asking to 
avoid. Either cache the variable or use iceauth-native so this dep is 
removed from build host packages.

>
>>>   FILES_${PN} += "${libdir}/xfce4/splash/engines/*.so"
>>>   FILES_${PN} += "${datadir}/xfce4/tips/*"
>>>   FILES_${PN} += "${datadir}/themes/Default/balou/*"
>>> diff --git a/recipes/xfce-base/xfce4-session_4.6.2.bb b/recipes/xfce-base/xfce4-session_4.6.2.bb
>>> index d7f768a..c937775 100644
>>> --- a/recipes/xfce-base/xfce4-session_4.6.2.bb
>>> +++ b/recipes/xfce-base/xfce4-session_4.6.2.bb
>>> @@ -1,13 +1,15 @@
>>>   DESCRIPTION = "xfce4-session is a session manager for Xfce 4 Desktop Environment"
>>> -DEPENDS = "libwnck libxfcegui4 libxfce4util dbus iceauth xfce-utils"
>>> +DEPENDS = "libwnck libxfcegui4 libxfce4util dbus xfce-utils"
>>>   SECTION = "x11"
>>>
>>> -PR = "r0"
>>> +PR = "r1"
>>>
>>>   inherit xfce46
>>>
>>>   RDEPENDS_${PN} = "iceauth xfce-utils xinit dbus-x11"
>>>
>>> +EXTRA_OECONF += "ac_cv_path_ICEAUTH=/usr/bin/iceauth"
>>> +
>>>   FILES_${PN} += "${libdir}/xfce4/splash/engines/*.so"
>>>   FILES_${PN} += "${datadir}/xfce4/tips/*"
>>>   FILES_${PN} += "${datadir}/themes/Default/balou/*"
>>> --
>>> 1.7.4.1
>>>
>>>
>>> _______________________________________________
>>> Openembedded-devel mailing list
>>> Openembedded-devel@lists.openembedded.org
>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Paul Menzel - March 20, 2011, 10:16 a.m.
Am Samstag, den 19.03.2011, 21:32 -0700 schrieb Khem Raj:
> On 3/19/2011 6:10 PM, Paul Menzel wrote:
> > Am Samstag, den 19.03.2011, 11:33 -0700 schrieb Khem Raj:
> >> On (18/03/11 13:00), Paul Menzel wrote:
> >>> Date: Fri, 18 Mar 2011 12:03:43 +0100
> >>>
> >>> Xfce Session build depends on the executable `iceauth`, which fails when cross compiling for a different architecture.
> >>>
> >>>          checking if the linker (arm-oe-linux-gnueabi-ld --sysroot=/oe/build-minimal-eglibc/minimal-dev/sysroots/armv5te-oe-linux-gnueabi) is GNU ld... (cached) yes
> >>>          checking whether to build with profiling support... no
> >>>          checking whether to compile with coverage profiling instrumentation... no
> >>>          checking whether to disable assertions... no
> >>>          checking whether to build final version... yes
> >>>          checking whether arm-oe-linux-gnueabi-ld --sysroot=/oe/build-minimal-eglibc/minimal-dev/sysroots/armv5te-oe-linux-gnueabi accepts -O1... yes
> >>>          checking for iceauth... no
> >>>          configure: error: iceauth missing, please check your X11 installation
> >>>
> >>> As suggested by Khem Raj [1] pass the value – `/usr/bin/iceauth` is taken – to the configure script so that the test is avoided.
> >>>
> >>> Therefore `iceauth` is removed from `DEPENDS` and the `PR` variable is incremented.
> >>>
> >>> This issue has been reported upstream as ticket #7420 [2].
> >>>
> >>> [1] http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-March/031115.html
> >>> [2] http://bugzilla.xfce.org/show_bug.cgi?id=7420
> >>>
> >>> Signed-off-by: Paul Menzel<paulepanter@users.sourceforge.net>
> >>> ---
> >>>   recipes/xfce-base/xfce4-session_4.6.1.bb |    6 ++++--
> >>>   recipes/xfce-base/xfce4-session_4.6.2.bb |    6 ++++--
> >>>   2 files changed, 8 insertions(+), 4 deletions(-)
> >>>
> >>> diff --git a/recipes/xfce-base/xfce4-session_4.6.1.bb b/recipes/xfce-base/xfce4-session_4.6.1.bb
> >>> index ba66ac1..5029b21 100644
> >>> --- a/recipes/xfce-base/xfce4-session_4.6.1.bb
> >>> +++ b/recipes/xfce-base/xfce4-session_4.6.1.bb
> >>> @@ -1,13 +1,15 @@
> >>>   DESCRIPTION = "xfce4-session is a session manager for Xfce 4 Desktop Environment"
> >>> -DEPENDS = "lbwnck libxfcegui4 libxfce4util dbus iceauth xfce-utils"
> >>> +DEPENDS = "lbwnck libxfcegui4 libxfce4util dbus xfce-utils"
> >>>   SECTION = "x11"
> >>>
> >>> -PR = "r4"
> >>> +PR = "r5"
> >>>
> >>>   inherit xfce46
> >>>
> >>>   RDEPENDS_${PN} = "iceauth xfce-utils xinit dbus-x11"
> >>>
> >>> +EXTRA_OECONF += "ac_cv_path_ICEAUTH=/usr/bin/iceauth"
> >>
> >> Would it make sense to have iceauth-native instead ?
> >
> > It never really executes `iceauth` during compile time but just during
> > configure to determine the runtime path. So `iceauth-native` is not
> > needed and would be even result in the wrong path, I think.
> 
> weather it executes is during configure or during compile how does it 
> matter ?

That it is not a build time dependency and therefore only needed during
runtime. I thought the pathes of programs during compile time do not
matter since the build host and the host where it gets installed differ
when cross compiling.

> in the end it needs iceauth and it will mean that you will ask
> folks to have iceauth on their build host

No, they implemented it this way but it is wrong in my opinion.

> which is what I am asking to avoid.

I tried to do that.

> Either cache the variable

Is not my patch doing that?

> or use iceauth-native so this dep is removed from build host packages.
>
> >>>   FILES_${PN} += "${libdir}/xfce4/splash/engines/*.so"
> >>>   FILES_${PN} += "${datadir}/xfce4/tips/*"
> >>>   FILES_${PN} += "${datadir}/themes/Default/balou/*"
> >>> diff --git a/recipes/xfce-base/xfce4-session_4.6.2.bb b/recipes/xfce-base/xfce4-session_4.6.2.bb
> >>> index d7f768a..c937775 100644
> >>> --- a/recipes/xfce-base/xfce4-session_4.6.2.bb
> >>> +++ b/recipes/xfce-base/xfce4-session_4.6.2.bb
> >>> @@ -1,13 +1,15 @@
> >>>   DESCRIPTION = "xfce4-session is a session manager for Xfce 4 Desktop Environment"
> >>> -DEPENDS = "libwnck libxfcegui4 libxfce4util dbus iceauth xfce-utils"
> >>> +DEPENDS = "libwnck libxfcegui4 libxfce4util dbus xfce-utils"
> >>>   SECTION = "x11"
> >>>
> >>> -PR = "r0"
> >>> +PR = "r1"
> >>>
> >>>   inherit xfce46
> >>>
> >>>   RDEPENDS_${PN} = "iceauth xfce-utils xinit dbus-x11"
> >>>
> >>> +EXTRA_OECONF += "ac_cv_path_ICEAUTH=/usr/bin/iceauth"
> >>> +
> >>>   FILES_${PN} += "${libdir}/xfce4/splash/engines/*.so"
> >>>   FILES_${PN} += "${datadir}/xfce4/tips/*"
> >>>   FILES_${PN} += "${datadir}/themes/Default/balou/*"
> >>> --
> >>> 1.7.4.1
Koen Kooi - March 20, 2011, 1:03 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 18-03-11 13:00, Paul Menzel wrote:
> Date: Fri, 18 Mar 2011 12:03:43 +0100
> 
> Xfce Session build depends on the executable `iceauth`, which fails when cross compiling for a different architecture.

[..]

> --- a/recipes/xfce-base/xfce4-session_4.6.1.bb

[..]

>  
> +EXTRA_OECONF += "ac_cv_path_ICEAUTH=/usr/bin/iceauth"

Minor nit: ${bindir}/iceauth

If that's fixed:

Acked-by: Koen Kooi <koen@dominion.thruhere.net>

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFNhfsfMkyGM64RGpERAhutAKC9N26qpImGg+Fs8T4EHIZqDe0TnQCcCZgw
SkK1VWwgUwtM2oGG28zZPF0=
=/nQQ
-----END PGP SIGNATURE-----
Khem Raj - March 20, 2011, 6:01 p.m.
> That it is not a build time dependency and therefore only needed during
> runtime. I thought the pathes of programs during compile time do not
> matter since the build host and the host where it gets installed differ
> when cross compiling.

OK I see its a runtime dependency( not compile time/configure time) then 
its ok but I think we need to have iceauth in RDEPENDS too I think.
Paul Menzel - March 20, 2011, 9:05 p.m.
Am Sonntag, den 20.03.2011, 11:01 -0700 schrieb Khem Raj:
> > That it is not a build time dependency and therefore only needed during
> > runtime. I thought the pathes of programs during compile time do not
> > matter since the build host and the host where it gets installed differ
> > when cross compiling.
> 
> OK I see its a runtime dependency( not compile time/configure time) then 
> its ok but I think we need to have iceauth in RDEPENDS too I think.

Yes, `iceauth` is already included into `RDEPENDS` and I left it there.


Thanks,

Paul
Andreas Müller - March 23, 2011, 12:33 a.m.
On Sunday 20 March 2011 14:03:27 Koen Kooi wrote:
> On 18-03-11 13:00, Paul Menzel wrote:
> > Date: Fri, 18 Mar 2011 12:03:43 +0100
> > 
> > Xfce Session build depends on the executable `iceauth`, which fails when
> > cross compiling for a different architecture.
> 
> [..]
> 
> > --- a/recipes/xfce-base/xfce4-session_4.6.1.bb
> 
> [..]
> 
> > +EXTRA_OECONF += "ac_cv_path_ICEAUTH=/usr/bin/iceauth"
> 
> Minor nit: ${bindir}/iceauth
> 
> If that's fixed:
> 
> Acked-by: Koen Kooi <koen@dominion.thruhere.net>
> 
> regards,
> 
> Koen

During preparing xfce 4.8  recipes I stumbled over 'iceauth' too: 

It is missing on the target image although 'xfce4-session' has it in DEPENDS & 
RDEPENDS_${PN} (this patch does not change missing 'iceauth' in image - so I 
would NAK if I could) 

Anyway: In 'xfce4-session' / config.log I found:

| configure:15972: checking for iceauth
| configure:15990: found */usr/bin/iceauth*
| configure:16002: result: /usr/bin/iceauth

So - as Khem suggested - and with xfce4-session: RDEPENDS_${PN}="iceauth" I:
  - changed iceauth to extent to iceauth-native.
  - changed xfce4-session: DEPENDS = "iceauth-native ..."
  - build an image

Results:
- config.log says: configure:15990: found /home/Superandi/tmp/sysroots/i686-
linux/usr/bin/iceauth
- In installed-packages.txt now 'iceauth_1:1.0.4-r5.1.9_armv7a.ipk' is found!

Since xfce4.6 means huge rebuild for me (and I did only pick up what Khem 
suggested): Can anybody test this for xfce_session_4.6.{1, 2} and create the 
patches?

Andreas
Paul Menzel - March 23, 2011, 12:51 a.m.
Am Mittwoch, den 23.03.2011, 01:33 +0100 schrieb Andreas Mueller:
> On Sunday 20 March 2011 14:03:27 Koen Kooi wrote:
> > On 18-03-11 13:00, Paul Menzel wrote:
> > > Date: Fri, 18 Mar 2011 12:03:43 +0100
> > > 
> > > Xfce Session build depends on the executable `iceauth`, which fails when
> > > cross compiling for a different architecture.
> > 
> > [..]
> > 
> > > --- a/recipes/xfce-base/xfce4-session_4.6.1.bb
> > 
> > [..]
> > 
> > > +EXTRA_OECONF += "ac_cv_path_ICEAUTH=/usr/bin/iceauth"
> > 
> > Minor nit: ${bindir}/iceauth
> > 
> > If that's fixed:
> > 
> > Acked-by: Koen Kooi <koen@dominion.thruhere.net>
> > 
> > regards,
> > 
> > Koen
> 
> During preparing xfce 4.8  recipes I stumbled over 'iceauth' too: 
> 
> It is missing on the target image although 'xfce4-session' has it in DEPENDS & 
> RDEPENDS_${PN} (this patch does not change missing 'iceauth' in image - so I 
> would NAK if I could)

I did not check that. But why does not `RDEPENDS` pull that in? And you
can always NAK. ;-) Hopefully not too often on my patches.

> Anyway: In 'xfce4-session' / config.log I found:
> 
> | configure:15972: checking for iceauth
> | configure:15990: found */usr/bin/iceauth*
> | configure:16002: result: /usr/bin/iceauth
> 
> So - as Khem suggested - and with xfce4-session: RDEPENDS_${PN}="iceauth" I:
>   - changed iceauth to extent to iceauth-native.
>   - changed xfce4-session: DEPENDS = "iceauth-native ..."
>   - build an image
> 
> Results:
> - config.log says: configure:15990: found /home/Superandi/tmp/sysroots/i686-
> linux/usr/bin/iceauth
> - In installed-packages.txt now 'iceauth_1:1.0.4-r5.1.9_armv7a.ipk' is found!

Have you run tested that? As far as I understood that path is put into
the resulting binary and, if I am not mistaken, the path will be
`/usr/bin/iceauth` on the target system.

> Since xfce4.6 means huge rebuild for me (and I did only pick up what Khem 
> suggested): Can anybody test this for xfce_session_4.6.{1, 2} and create the 
> patches?

Could you send me the patch to get the native recipe for Xfce 4.8? I can
adapt it then. I am sure it will work, but please explain to me the
issue raised above.


Thanks,

Paul
Koen Kooi - March 23, 2011, 7:14 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 23-03-11 01:33, Andreas Mueller wrote:

> Anyway: In 'xfce4-session' / config.log I found:
> 
> | configure:15972: checking for iceauth
> | configure:15990: found */usr/bin/iceauth*
> | configure:16002: result: /usr/bin/iceauth
> 
> So - as Khem suggested - and with xfce4-session: RDEPENDS_${PN}="iceauth" I:
>   - changed iceauth to extent to iceauth-native.
>   - changed xfce4-session: DEPENDS = "iceauth-native ..."

No, it only wants to probe for the PATH of the binary to encode into the
result. We do NOT want target binaries to point to your builddir instead
of ${bindir}.

As I said before, Pauls patch does the right thing.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFNiZ3OMkyGM64RGpERAhGkAJ9DcOr2vrAnAEkR8YmsNYSIJokHeACeLMiv
s5rQTqwrhSBj+oyZCHdRM6w=
=Fjad
-----END PGP SIGNATURE-----
Andreas Müller - March 23, 2011, 8:35 a.m.
On Wednesday 23 March 2011 08:14:22 Koen Kooi wrote:
> On 23-03-11 01:33, Andreas Mueller wrote:
> > Anyway: In 'xfce4-session' / config.log I found:
> > | configure:15972: checking for iceauth
> > | configure:15990: found */usr/bin/iceauth*
> > | configure:16002: result: /usr/bin/iceauth
> > 
> > So - as Khem suggested - and with xfce4-session: RDEPENDS_${PN}="iceauth" I:
> >   - changed iceauth to extent to iceauth-native.
> >   - changed xfce4-session: DEPENDS = "iceauth-native ..."
> 
> No, it only wants to probe for the PATH of the binary to encode into the
> result. We do NOT want target binaries to point to your builddir instead
> of ${bindir}.
> 
> As I said before, Pauls patch does the right thing.
Got it - sorry for the noise - have an ACK on Paul's patch :-)


On Wednesday 23 March 2011 01:51:38 Paul Menzel wrote:
> I did not check that. But why does not `RDEPENDS` pull that in?
If I would understand that... But I think that is what happened to you in 
http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-March/030721.html
xfce4-settings has iceauth in DEPENDS & RDEPENDS since long time..

> Have you run tested that? As far as I understood that path is put into
> the resulting binary and, if I am not mistaken, the path will be
> `/usr/bin/iceauth` on the target system.
now yes - it failed - see above..
> 
> > Since xfce4.6 means huge rebuild for me (and I did only pick up what Khem
> > suggested): Can anybody test this for xfce_session_4.6.{1, 2} and create
> > the patches?
> 
> Could you send me the patch to get the native recipe for Xfce 4.8?
Sorry - but what do you mean with *native* recipe for Xfce 4.8?

Andreas
Paul Menzel - March 23, 2011, 9:51 a.m.
Am Mittwoch, den 23.03.2011, 09:35 +0100 schrieb Andreas Mueller:
> On Wednesday 23 March 2011 08:14:22 Koen Kooi wrote:
> > On 23-03-11 01:33, Andreas Mueller wrote:

[…]

> > > Since xfce4.6 means huge rebuild for me (and I did only pick up what Khem
> > > suggested): Can anybody test this for xfce_session_4.6.{1, 2} and create
> > > the patches?
> > 
> > Could you send me the patch to get the native recipe for Xfce 4.8?
> Sorry - but what do you mean with *native* recipe for Xfce 4.8?

You wrote that you had adapted/extended(?) `xfce-session_4.8.*.bb` to
build a native package(?) (sorry). So I wanted to just see your
`xfce-session_.4.8.*.bb` to know what to do.


Thanks,

Paul
Andreas Müller - March 23, 2011, 10:19 a.m.
On Wednesday 23 March 2011 10:51:58 Paul Menzel wrote:
> Am Mittwoch, den 23.03.2011, 09:35 +0100 schrieb Andreas Mueller:
> > On Wednesday 23 March 2011 08:14:22 Koen Kooi wrote:
> > > On 23-03-11 01:33, Andreas Mueller wrote:
> […]
> 
> > > > Since xfce4.6 means huge rebuild for me (and I did only pick up what
> > > > Khem suggested): Can anybody test this for xfce_session_4.6.{1, 2}
> > > > and create the patches?
> > > 
> > > Could you send me the patch to get the native recipe for Xfce 4.8?
> > 
> > Sorry - but what do you mean with *native* recipe for Xfce 4.8?
> 
> You wrote that you had adapted/extended(?) `xfce-session_4.8.*.bb` to
> build a native package(?) (sorry). So I wanted to just see your
> `xfce-session_.4.8.*.bb` to know what to do.
Oh I see - sorry for causing confusion: I added native support for iceauth.

With the recipes attached I get 
- iceauth installed on target image 
- xfce4-session not complaining about missing iceauth

Still have no idea why iceauth was not found in target image...

Andreas
require xorg-app-common.inc
DESCRIPTION = "a tool for manipulating ICE protocol authorization records"
DEPENDS += " libice"
PE = "1"
PR = "${INC_PR}.1"

BBCLASSEXTEND="native"

SRC_URI[archive.md5sum] = "bb2e4d2611047f7c5a1a82ec956a9de4"
SRC_URI[archive.sha256sum] = "0ee6fd4554f0131b1ed526ee00b9cf643e7dc97eb70fb51448848ef2f349938d"
DESCRIPTION = "xfce4-session is a session manager for Xfce 4 Desktop Environment"
DEPENDS = "libwnck libxfce4ui libxfce4util dbus iceauth-native xfce-utils"
RDEPENDS_${PN} = "iceauth xinit dbus-x11"
SECTION = "x11"

PR = "r0"

inherit xfce46

EXTRA_OECONF += "ac_cv_path_ICEAUTH=${bindir}/iceauth"

FILES_${PN} += "${libdir}/xfce4/*/*"
FILES_${PN} += "${datadir}/xfce4/*/*"
FILES_${PN} += "${datadir}/themes/Default/balou/*"

FILES_${PN}-dbg += "${libdir}/xfce4/*/*/.debug"

SRC_URI[md5sum] = "478080ff666fdd36786a243829663efd"
SRC_URI[sha256sum] = "1df52a77d87ed4d27b4f40a2f03a0b6334422d64bdc4e31b9aac22e25e68b829"

Patch

diff --git a/recipes/xfce-base/xfce4-session_4.6.1.bb b/recipes/xfce-base/xfce4-session_4.6.1.bb
index ba66ac1..5029b21 100644
--- a/recipes/xfce-base/xfce4-session_4.6.1.bb
+++ b/recipes/xfce-base/xfce4-session_4.6.1.bb
@@ -1,13 +1,15 @@ 
 DESCRIPTION = "xfce4-session is a session manager for Xfce 4 Desktop Environment"
-DEPENDS = "lbwnck libxfcegui4 libxfce4util dbus iceauth xfce-utils"
+DEPENDS = "lbwnck libxfcegui4 libxfce4util dbus xfce-utils"
 SECTION = "x11"
 
-PR = "r4"
+PR = "r5"
 
 inherit xfce46
 
 RDEPENDS_${PN} = "iceauth xfce-utils xinit dbus-x11"
 
+EXTRA_OECONF += "ac_cv_path_ICEAUTH=/usr/bin/iceauth"
+
 FILES_${PN} += "${libdir}/xfce4/splash/engines/*.so"
 FILES_${PN} += "${datadir}/xfce4/tips/*"
 FILES_${PN} += "${datadir}/themes/Default/balou/*"
diff --git a/recipes/xfce-base/xfce4-session_4.6.2.bb b/recipes/xfce-base/xfce4-session_4.6.2.bb
index d7f768a..c937775 100644
--- a/recipes/xfce-base/xfce4-session_4.6.2.bb
+++ b/recipes/xfce-base/xfce4-session_4.6.2.bb
@@ -1,13 +1,15 @@ 
 DESCRIPTION = "xfce4-session is a session manager for Xfce 4 Desktop Environment"
-DEPENDS = "libwnck libxfcegui4 libxfce4util dbus iceauth xfce-utils"
+DEPENDS = "libwnck libxfcegui4 libxfce4util dbus xfce-utils"
 SECTION = "x11"
 
-PR = "r0"
+PR = "r1"
 
 inherit xfce46
 
 RDEPENDS_${PN} = "iceauth xfce-utils xinit dbus-x11"
 
+EXTRA_OECONF += "ac_cv_path_ICEAUTH=/usr/bin/iceauth"
+
 FILES_${PN} += "${libdir}/xfce4/splash/engines/*.so"
 FILES_${PN} += "${datadir}/xfce4/tips/*"
 FILES_${PN} += "${datadir}/themes/Default/balou/*"