Patchwork Alter order of file systems tried by mount

login
register
mail settings
Submitter Gary Thomas
Date Nov. 30, 2011, 12:19 p.m.
Message ID <4ED61F56.8050409@mlbassoc.com>
Download mbox | patch
Permalink /patch/15839/
State New
Headers show

Comments

Gary Thomas - Nov. 30, 2011, 12:19 p.m.
The file /etc/filesystems is used by busybox 'mount' when
  attempting to mount a file system when the type is not
  specified.  This change alters the order so that more
  capable systems are tried first.  Without this change, an
  EXT3 system will mount as EXT2 which disables many of the
  EXT3 features.  With the change, EXT3 systems are mounted
  properly.

Signed-off-by: Gary Thomas <gary@mlbassoc.com>
---
  .../recipes-core/base-files/base-files/filesystems |    8 ++++----
  meta/recipes-core/base-files/base-files_3.0.14.bb  |    2 +-
  2 files changed, 5 insertions(+), 5 deletions(-)
Stefan Schmidt - Nov. 30, 2011, 12:37 p.m.
Hello.

On Wed, 2011-11-30 at 05:19, Gary Thomas wrote:
>  The file /etc/filesystems is used by busybox 'mount' when
>  attempting to mount a file system when the type is not
>  specified.  This change alters the order so that more
>  capable systems are tried first.  Without this change, an
>  EXT3 system will mount as EXT2 which disables many of the
>  EXT3 features.  With the change, EXT3 systems are mounted
>  properly.
> 
> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
> ---
>  .../recipes-core/base-files/base-files/filesystems |    8 ++++----
>  meta/recipes-core/base-files/base-files_3.0.14.bb  |    2 +-
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/meta/recipes-core/base-files/base-files/filesystems b/meta/recipes-core/base-files/base-files/filesystems
> index 2af6a7e..14f5abb 100644
> --- a/meta/recipes-core/base-files/base-files/filesystems
> +++ b/meta/recipes-core/base-files/base-files/filesystems
> @@ -1,7 +1,7 @@
> -minix
> -fat
> -vfat
> -ext2
>  ext3
> +ext2
> +vfat
> +fat
>  btrfs
> +minix

In the commit message you explain the problem with ext2/3. And I agree
that it makes sense to start with ext3. Actually, adding ext4 would
make sense, too.

What is the deal with the re-ordering of fat/vfat/minix though? Looks
unrelated to me.

regards
Stefan Schmidt
Gary Thomas - Nov. 30, 2011, 12:42 p.m.
On 2011-11-30 05:37, Stefan Schmidt wrote:
> Hello.
>
> On Wed, 2011-11-30 at 05:19, Gary Thomas wrote:
>>   The file /etc/filesystems is used by busybox 'mount' when
>>   attempting to mount a file system when the type is not
>>   specified.  This change alters the order so that more
>>   capable systems are tried first.  Without this change, an
>>   EXT3 system will mount as EXT2 which disables many of the
>>   EXT3 features.  With the change, EXT3 systems are mounted
>>   properly.
>>
>> Signed-off-by: Gary Thomas<gary@mlbassoc.com>
>> ---
>>   .../recipes-core/base-files/base-files/filesystems |    8 ++++----
>>   meta/recipes-core/base-files/base-files_3.0.14.bb  |    2 +-
>>   2 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/meta/recipes-core/base-files/base-files/filesystems b/meta/recipes-core/base-files/base-files/filesystems
>> index 2af6a7e..14f5abb 100644
>> --- a/meta/recipes-core/base-files/base-files/filesystems
>> +++ b/meta/recipes-core/base-files/base-files/filesystems
>> @@ -1,7 +1,7 @@
>> -minix
>> -fat
>> -vfat
>> -ext2
>>   ext3
>> +ext2
>> +vfat
>> +fat
>>   btrfs
>> +minix
>
> In the commit message you explain the problem with ext2/3. And I agree
> that it makes sense to start with ext3. Actually, adding ext4 would
> make sense, too.

Agreed.

>
> What is the deal with the re-ordering of fat/vfat/minix though? Looks
> unrelated to me.

Same argument as above - try more capable file systems first.
I also moved minix to the end as it is rarely, if ever, used.
Stefan Schmidt - Nov. 30, 2011, 12:53 p.m.
Hello.

On Wed, 2011-11-30 at 05:42, Gary Thomas wrote:
> On 2011-11-30 05:37, Stefan Schmidt wrote:
> >On Wed, 2011-11-30 at 05:19, Gary Thomas wrote:
> >>  The file /etc/filesystems is used by busybox 'mount' when
> >>  attempting to mount a file system when the type is not
> >>  specified.  This change alters the order so that more
> >>  capable systems are tried first.  Without this change, an
> >>  EXT3 system will mount as EXT2 which disables many of the
> >>  EXT3 features.  With the change, EXT3 systems are mounted
> >>  properly.
> >>
> >>Signed-off-by: Gary Thomas<gary@mlbassoc.com>
> >>---
> >>  .../recipes-core/base-files/base-files/filesystems |    8 ++++----
> >>  meta/recipes-core/base-files/base-files_3.0.14.bb  |    2 +-
> >>  2 files changed, 5 insertions(+), 5 deletions(-)
> >>
> >>diff --git a/meta/recipes-core/base-files/base-files/filesystems b/meta/recipes-core/base-files/base-files/filesystems
> >>index 2af6a7e..14f5abb 100644
> >>--- a/meta/recipes-core/base-files/base-files/filesystems
> >>+++ b/meta/recipes-core/base-files/base-files/filesystems
> >>@@ -1,7 +1,7 @@
> >>-minix
> >>-fat
> >>-vfat
> >>-ext2
> >>  ext3
> >>+ext2
> >>+vfat
> >>+fat
> >>  btrfs
> >>+minix
> >
> >In the commit message you explain the problem with ext2/3. And I agree
> >that it makes sense to start with ext3. Actually, adding ext4 would
> >make sense, too.
> 
> Agreed.

In the mood to add it and send an updated version of this patch? :)

> >What is the deal with the re-ordering of fat/vfat/minix though? Looks
> >unrelated to me.
> 
> Same argument as above - try more capable file systems first.
> I also moved minix to the end as it is rarely, if ever, used.

Ah, now I see that you also moved vfat before fat. Missed that before.

Acked-by: Stefan Schmidt <stefan@datenfreihafen.org>

regards
Stefan Schmidt
Gary Thomas - Jan. 3, 2012, 4:13 p.m.
On 2011-11-30 05:19, Gary Thomas wrote:
> The file /etc/filesystems is used by busybox 'mount' when
> attempting to mount a file system when the type is not
> specified. This change alters the order so that more
> capable systems are tried first. Without this change, an
> EXT3 system will mount as EXT2 which disables many of the
> EXT3 features. With the change, EXT3 systems are mounted
> properly.
>
> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
> ---
> .../recipes-core/base-files/base-files/filesystems | 8 ++++----
> meta/recipes-core/base-files/base-files_3.0.14.bb | 2 +-
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/meta/recipes-core/base-files/base-files/filesystems b/meta/recipes-core/base-files/base-files/filesystems
> index 2af6a7e..14f5abb 100644
> --- a/meta/recipes-core/base-files/base-files/filesystems
> +++ b/meta/recipes-core/base-files/base-files/filesystems
> @@ -1,7 +1,7 @@
> -minix
> -fat
> -vfat
> -ext2
> ext3
> +ext2
> +vfat
> +fat
> btrfs
> +minix
> *
> diff --git a/meta/recipes-core/base-files/base-files_3.0.14.bb b/meta/recipes-core/base-files/base-files_3.0.14.bb
> index 8f5313b..c860d70 100644
> --- a/meta/recipes-core/base-files/base-files_3.0.14.bb
> +++ b/meta/recipes-core/base-files/base-files_3.0.14.bb
> @@ -1,7 +1,7 @@
> SUMMARY = "Miscellaneous files for the base system."
> DESCRIPTION = "The base-files package creates the basic system directory structure and provides a small set of key configuration files for the system."
> SECTION = "base"
> -PR = "r69"
> +PR = "r70"
> LICENSE = "GPLv2"
> LIC_FILES_CHKSUM = "file://licenses/GPL-2;md5=94d55d512a9ba36caa9b7df079bae19f"
> SRC_URI = "file://rotation \

What about this patch (now 1 month old, with no action or discussion)?

Thanks
Saul Wold - Jan. 3, 2012, 6 p.m.
On 01/03/2012 08:13 AM, Gary Thomas wrote:
> On 2011-11-30 05:19, Gary Thomas wrote:
>> The file /etc/filesystems is used by busybox 'mount' when
>> attempting to mount a file system when the type is not
>> specified. This change alters the order so that more
>> capable systems are tried first. Without this change, an
>> EXT3 system will mount as EXT2 which disables many of the
>> EXT3 features. With the change, EXT3 systems are mounted
>> properly.
>>
>> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
>> ---
>> .../recipes-core/base-files/base-files/filesystems | 8 ++++----
>> meta/recipes-core/base-files/base-files_3.0.14.bb | 2 +-
>> 2 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/meta/recipes-core/base-files/base-files/filesystems
>> b/meta/recipes-core/base-files/base-files/filesystems
>> index 2af6a7e..14f5abb 100644
>> --- a/meta/recipes-core/base-files/base-files/filesystems
>> +++ b/meta/recipes-core/base-files/base-files/filesystems
>> @@ -1,7 +1,7 @@
>> -minix
>> -fat
>> -vfat
>> -ext2
>> ext3
>> +ext2
>> +vfat
>> +fat
>> btrfs
>> +minix
>> *
>> diff --git a/meta/recipes-core/base-files/base-files_3.0.14.bb
>> b/meta/recipes-core/base-files/base-files_3.0.14.bb
>> index 8f5313b..c860d70 100644
>> --- a/meta/recipes-core/base-files/base-files_3.0.14.bb
>> +++ b/meta/recipes-core/base-files/base-files_3.0.14.bb
>> @@ -1,7 +1,7 @@
>> SUMMARY = "Miscellaneous files for the base system."
>> DESCRIPTION = "The base-files package creates the basic system
>> directory structure and provides a small set of key configuration
>> files for the system."
>> SECTION = "base"
>> -PR = "r69"
>> +PR = "r70"
>> LICENSE = "GPLv2"
>> LIC_FILES_CHKSUM =
>> "file://licenses/GPL-2;md5=94d55d512a9ba36caa9b7df079bae19f"
>> SRC_URI = "file://rotation \
>
> What about this patch (now 1 month old, with no action or discussion)?
>
Looks like there were some comments between you and Stefan about adding 
ext4, so I was waiting for an updated version.

Sau!

> Thanks
>
Gary Thomas - Jan. 3, 2012, 6:06 p.m.
On 2012-01-03 11:00, Saul Wold wrote:
> On 01/03/2012 08:13 AM, Gary Thomas wrote:
>> On 2011-11-30 05:19, Gary Thomas wrote:
>>> The file /etc/filesystems is used by busybox 'mount' when
>>> attempting to mount a file system when the type is not
>>> specified. This change alters the order so that more
>>> capable systems are tried first. Without this change, an
>>> EXT3 system will mount as EXT2 which disables many of the
>>> EXT3 features. With the change, EXT3 systems are mounted
>>> properly.
>>>
>>> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
>>> ---
>>> .../recipes-core/base-files/base-files/filesystems | 8 ++++----
>>> meta/recipes-core/base-files/base-files_3.0.14.bb | 2 +-
>>> 2 files changed, 5 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/meta/recipes-core/base-files/base-files/filesystems
>>> b/meta/recipes-core/base-files/base-files/filesystems
>>> index 2af6a7e..14f5abb 100644
>>> --- a/meta/recipes-core/base-files/base-files/filesystems
>>> +++ b/meta/recipes-core/base-files/base-files/filesystems
>>> @@ -1,7 +1,7 @@
>>> -minix
>>> -fat
>>> -vfat
>>> -ext2
>>> ext3
>>> +ext2
>>> +vfat
>>> +fat
>>> btrfs
>>> +minix
>>> *
>>> diff --git a/meta/recipes-core/base-files/base-files_3.0.14.bb
>>> b/meta/recipes-core/base-files/base-files_3.0.14.bb
>>> index 8f5313b..c860d70 100644
>>> --- a/meta/recipes-core/base-files/base-files_3.0.14.bb
>>> +++ b/meta/recipes-core/base-files/base-files_3.0.14.bb
>>> @@ -1,7 +1,7 @@
>>> SUMMARY = "Miscellaneous files for the base system."
>>> DESCRIPTION = "The base-files package creates the basic system
>>> directory structure and provides a small set of key configuration
>>> files for the system."
>>> SECTION = "base"
>>> -PR = "r69"
>>> +PR = "r70"
>>> LICENSE = "GPLv2"
>>> LIC_FILES_CHKSUM =
>>> "file://licenses/GPL-2;md5=94d55d512a9ba36caa9b7df079bae19f"
>>> SRC_URI = "file://rotation \
>>
>> What about this patch (now 1 month old, with no action or discussion)?
>>
> Looks like there were some comments between you and Stefan about adding ext4, so I was waiting for an updated version.

OK, I'll add that and send a new patch once I can test it.

Patch

diff --git a/meta/recipes-core/base-files/base-files/filesystems b/meta/recipes-core/base-files/base-files/filesystems
index 2af6a7e..14f5abb 100644
--- a/meta/recipes-core/base-files/base-files/filesystems
+++ b/meta/recipes-core/base-files/base-files/filesystems
@@ -1,7 +1,7 @@ 
-minix
-fat
-vfat
-ext2
  ext3
+ext2
+vfat
+fat
  btrfs
+minix
  *
diff --git a/meta/recipes-core/base-files/base-files_3.0.14.bb b/meta/recipes-core/base-files/base-files_3.0.14.bb
index 8f5313b..c860d70 100644
--- a/meta/recipes-core/base-files/base-files_3.0.14.bb
+++ b/meta/recipes-core/base-files/base-files_3.0.14.bb
@@ -1,7 +1,7 @@ 
  SUMMARY = "Miscellaneous files for the base system."
  DESCRIPTION = "The base-files package creates the basic system directory structure and provides a small set of key configuration files for the system."
  SECTION = "base"
-PR = "r69"
+PR = "r70"
  LICENSE = "GPLv2"
  LIC_FILES_CHKSUM = "file://licenses/GPL-2;md5=94d55d512a9ba36caa9b7df079bae19f"
  SRC_URI = "file://rotation \