| Submitter | Grahame Jordan |
|---|---|
| Date | 2010-02-11 12:46:28 |
| Message ID | <4B73FC24.9060807@theforce.com.au> |
| Download | mbox | patch |
| Permalink | /patch/1580/ |
| State | New |
| Headers | show |
Comments
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 11-02-10 13:46, Grahame Jordan wrote: > Hi, > > After git pull I could not build e17/news on Ubuntu 9.04 > Found this on: > http://old.nabble.com/omap3-desktop-image-fails-baking-'news'-td27323561.html > > applied changes and it now compiles OK. Since this is caused by skipping out autopoint, wouldn't it be better to run autopoint instead of patching stuff? regards, Koen -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Darwin) iD8DBQFLdA6ZMkyGM64RGpERArsbAKC6FLO2BAqnkANnZartRfw16WdIfACdHtLd 8K8BO//S/0bh2u4nJK8smbU= =WgPi -----END PGP SIGNATURE-----
Koen Kooi <k.kooi <at> student.utwente.nl> writes: > > > On 11-02-10 13:46, Grahame Jordan wrote: > > Hi, > > > > After git pull I could not build e17/news on Ubuntu 9.04 > > Found this on: > > http://old.nabble.com/omap3-desktop-image-fails-baking-'news'-td27323561.html > > > > applied changes and it now compiles OK. > > Since this is caused by skipping out autopoint, wouldn't it be better to > run autopoint instead of patching stuff? > > regards, > > Koen > I'm having the same issue building omap3-desktop-image and followed the same instructions that Grahame did, which did allow it to compile. It looks like you're saying there's a better way to solve this with autopoint, however, not being very familiar with the tools here I'm not sure what the right way to implement this is. Making a guess that the sed commands in the do_configure_prepend portion of the recipe were trying to work around the lack of autopoint, I pulled them out and replaced them with autopoint. do_configure_prepend() { autopoint } This seems to work as news now builds without error. However, I'm unsure if this was the right way to go about it and if there might be some unintended side effects. -Ben Udall
Patch
diff --git a/recipes/e17/news_svn.bb b/recipes/e17/news_svn.bb index c72fbb5..644d2e9 100644 --- a/recipes/e17/news_svn.bb +++ b/recipes/e17/news_svn.bb @@ -1,12 +1,13 @@ LICENSE = "MIT" PV = "0.1.0+svnr${SRCPV}" +PR = "r4" + require e-module.inc do_configure_prepend() { - sed -i -e /po/d configure.ac + sed -i -e /po/d -e /AM_GNU_GETTEXT/d configure.ac sed -i -e s:\ po::g Makefile.am + touch ${S}/config.rpath } - -