Patchwork [06/26] xinit: Update to 1.3.1

login
register
mail settings
Submitter Saul Wold
Date Nov. 29, 2011, 11 p.m.
Message ID <234071f22c2183ea28cda55bac8f68cb47e8f0e1.1322607016.git.sgw@linux.intel.com>
Download mbox | patch
Permalink /patch/15681/
State New
Headers show

Comments

Saul Wold - Nov. 29, 2011, 11 p.m.
Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 .../xorg-app/{xinit_1.3.0.bb => xinit_1.3.1.bb}    |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
 rename meta/recipes-graphics/xorg-app/{xinit_1.3.0.bb => xinit_1.3.1.bb} (80%)
Paul Menzel - Dec. 9, 2011, 6:42 p.m.
Dear Saul,


Am Dienstag, den 29.11.2011, 15:00 -0800 schrieb Saul Wold:
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
>  .../xorg-app/{xinit_1.3.0.bb => xinit_1.3.1.bb}    |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>  rename meta/recipes-graphics/xorg-app/{xinit_1.3.0.bb => xinit_1.3.1.bb} (80%)
> 
> diff --git a/meta/recipes-graphics/xorg-app/xinit_1.3.0.bb b/meta/recipes-graphics/xorg-app/xinit_1.3.1.bb
> similarity index 80%
> rename from meta/recipes-graphics/xorg-app/xinit_1.3.0.bb
> rename to meta/recipes-graphics/xorg-app/xinit_1.3.1.bb
> index 08dfe12..2ddebe6 100644
> --- a/meta/recipes-graphics/xorg-app/xinit_1.3.0.bb
> +++ b/meta/recipes-graphics/xorg-app/xinit_1.3.1.bb
> @@ -13,11 +13,11 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=0d4b5eef75f1584ccbdc5e4a34314407"
>  PR = "r2"

when upgrading recipes please remember to reset `PR` to 0. I just
spotted that now when looking through the “recent” changes [1].

>  PE = "1"
>  
> +SRC_URI[md5sum] = "ee234056d8a3dbf37b61b4bcb35b88e4"
> +SRC_URI[sha256sum] = "c7468dfae94bdb42785d79623c27156dc4bf379d8372992830482cb04d8439b0"
> +
>  EXTRA_OECONF = "ac_cv_path_MCOOKIE=${bindir}/mcookie"
>  
>  RDEPENDS_${PN} += "util-linux-mcookie"
>  
>  FILES_${PN} += "${libdir}X11/xinit"
> -
> -SRC_URI[md5sum] = "bc4e8b7d1919597cc37a0d24aa149dda"
> -SRC_URI[sha256sum] = "ba76e36e1a42a7cf76505b7e6fc4777f5d14f45ddff74341abfb7dd10d5fe04c"


Thanks,

Paul


[1] http://git.openembedded.org/openembedded-core/commit/?id=234071f22c2183ea28cda55bac8f68cb47e8f0e1
Mark Hatle - Dec. 9, 2011, 6:50 p.m.
On 12/9/11 12:42 PM, Paul Menzel wrote:
> Dear Saul,
>
>
> Am Dienstag, den 29.11.2011, 15:00 -0800 schrieb Saul Wold:
>> Signed-off-by: Saul Wold<sgw@linux.intel.com>
>> ---
>>   .../xorg-app/{xinit_1.3.0.bb =>  xinit_1.3.1.bb}    |    6 +++---
>>   1 files changed, 3 insertions(+), 3 deletions(-)
>>   rename meta/recipes-graphics/xorg-app/{xinit_1.3.0.bb =>  xinit_1.3.1.bb} (80%)
>>
>> diff --git a/meta/recipes-graphics/xorg-app/xinit_1.3.0.bb b/meta/recipes-graphics/xorg-app/xinit_1.3.1.bb
>> similarity index 80%
>> rename from meta/recipes-graphics/xorg-app/xinit_1.3.0.bb
>> rename to meta/recipes-graphics/xorg-app/xinit_1.3.1.bb
>> index 08dfe12..2ddebe6 100644
>> --- a/meta/recipes-graphics/xorg-app/xinit_1.3.0.bb
>> +++ b/meta/recipes-graphics/xorg-app/xinit_1.3.1.bb
>> @@ -13,11 +13,11 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=0d4b5eef75f1584ccbdc5e4a34314407"
>>   PR = "r2"
>
> when upgrading recipes please remember to reset `PR` to 0. I just
> spotted that now when looking through the “recent” changes [1].

I have not been doing that.  When I asked a while back the response I got was 
mixed and what I took from it is that PR (on a package upgrade) is up to the 
discretion of the person performing the upgrade.

If reseting to 0 is/should be the official policy, then we really need to 
document it as part of the patch/update guidelines..

--Mark

>>   PE = "1"
>>
>> +SRC_URI[md5sum] = "ee234056d8a3dbf37b61b4bcb35b88e4"
>> +SRC_URI[sha256sum] = "c7468dfae94bdb42785d79623c27156dc4bf379d8372992830482cb04d8439b0"
>> +
>>   EXTRA_OECONF = "ac_cv_path_MCOOKIE=${bindir}/mcookie"
>>
>>   RDEPENDS_${PN} += "util-linux-mcookie"
>>
>>   FILES_${PN} += "${libdir}X11/xinit"
>> -
>> -SRC_URI[md5sum] = "bc4e8b7d1919597cc37a0d24aa149dda"
>> -SRC_URI[sha256sum] = "ba76e36e1a42a7cf76505b7e6fc4777f5d14f45ddff74341abfb7dd10d5fe04c"
>
>
> Thanks,
>
> Paul
>
>
> [1] http://git.openembedded.org/openembedded-core/commit/?id=234071f22c2183ea28cda55bac8f68cb47e8f0e1
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Joshua Lock - Dec. 9, 2011, 7:01 p.m.
On 09/12/11 10:50, Mark Hatle wrote:
> On 12/9/11 12:42 PM, Paul Menzel wrote:
>> Dear Saul,
>>
>>
>> Am Dienstag, den 29.11.2011, 15:00 -0800 schrieb Saul Wold:
>>> Signed-off-by: Saul Wold<sgw@linux.intel.com>
>>> ---
>>>   .../xorg-app/{xinit_1.3.0.bb =>  xinit_1.3.1.bb}    |    6 +++---
>>>   1 files changed, 3 insertions(+), 3 deletions(-)
>>>   rename meta/recipes-graphics/xorg-app/{xinit_1.3.0.bb => 
>>> xinit_1.3.1.bb} (80%)
>>>
>>> diff --git a/meta/recipes-graphics/xorg-app/xinit_1.3.0.bb
>>> b/meta/recipes-graphics/xorg-app/xinit_1.3.1.bb
>>> similarity index 80%
>>> rename from meta/recipes-graphics/xorg-app/xinit_1.3.0.bb
>>> rename to meta/recipes-graphics/xorg-app/xinit_1.3.1.bb
>>> index 08dfe12..2ddebe6 100644
>>> --- a/meta/recipes-graphics/xorg-app/xinit_1.3.0.bb
>>> +++ b/meta/recipes-graphics/xorg-app/xinit_1.3.1.bb
>>> @@ -13,11 +13,11 @@ LIC_FILES_CHKSUM =
>>> "file://COPYING;md5=0d4b5eef75f1584ccbdc5e4a34314407"
>>>   PR = "r2"
>>
>> when upgrading recipes please remember to reset `PR` to 0. I just
>> spotted that now when looking through the “recent” changes [1].
> 
> I have not been doing that.  When I asked a while back the response I
> got was mixed and what I took from it is that PR (on a package upgrade)
> is up to the discretion of the person performing the upgrade.
> 
> If reseting to 0 is/should be the official policy, then we really need
> to document it as part of the patch/update guidelines..

My understanding is that the differing of opinion is between:
a) setting the PR = "0" in the recipe
b) deleting the PR entry from the recipe

Both of which set PR to 0, which I always understood to be 'policy'
unless there's a reason not to (usually meta-oe compatibility) but each
have their proponents for what makes most sense.

Regards,
Joshua
Khem Raj - Dec. 9, 2011, 7:46 p.m.
On Fri, Dec 9, 2011 at 11:01 AM, Joshua Lock <josh@linux.intel.com> wrote:
>
> Both of which set PR to 0, which I always understood to be 'policy'
> unless there's a reason not to (usually meta-oe compatibility) but each
> have their proponents for what makes most sense.

if PV is screwy i.e. not incremental then you might have to keep PR incrementing
but that should seldom be the case.

Patch

diff --git a/meta/recipes-graphics/xorg-app/xinit_1.3.0.bb b/meta/recipes-graphics/xorg-app/xinit_1.3.1.bb
similarity index 80%
rename from meta/recipes-graphics/xorg-app/xinit_1.3.0.bb
rename to meta/recipes-graphics/xorg-app/xinit_1.3.1.bb
index 08dfe12..2ddebe6 100644
--- a/meta/recipes-graphics/xorg-app/xinit_1.3.0.bb
+++ b/meta/recipes-graphics/xorg-app/xinit_1.3.1.bb
@@ -13,11 +13,11 @@  LIC_FILES_CHKSUM = "file://COPYING;md5=0d4b5eef75f1584ccbdc5e4a34314407"
 PR = "r2"
 PE = "1"
 
+SRC_URI[md5sum] = "ee234056d8a3dbf37b61b4bcb35b88e4"
+SRC_URI[sha256sum] = "c7468dfae94bdb42785d79623c27156dc4bf379d8372992830482cb04d8439b0"
+
 EXTRA_OECONF = "ac_cv_path_MCOOKIE=${bindir}/mcookie"
 
 RDEPENDS_${PN} += "util-linux-mcookie"
 
 FILES_${PN} += "${libdir}X11/xinit"
-
-SRC_URI[md5sum] = "bc4e8b7d1919597cc37a0d24aa149dda"
-SRC_URI[sha256sum] = "ba76e36e1a42a7cf76505b7e6fc4777f5d14f45ddff74341abfb7dd10d5fe04c"