Patchwork bitbake.conf: Ignore MACHINE as dep for MACHINEOVERRIDES

login
register
mail settings
Submitter Matthew McClintock
Date Nov. 29, 2011, 9:33 p.m.
Message ID <1322602415-24735-1-git-send-email-msm@freescale.com>
Download mbox | patch
Permalink /patch/15649/
State New
Headers show

Comments

Matthew McClintock - Nov. 29, 2011, 9:33 p.m.
This dependency causes binutils to get rebuilt for some of
our parts that are the same TARGET_ARCH but different
MACHINE.

Signed-off-by: Matthew McClintock <msm@freescale.com>
---
Comments on this? It seems like it might be better to some do this
in the actual recipes (binutils, gcc-cross, etc) and not globally.
However, I'm not really sure what goes in MACHINEOVERIDES in
general and if it could be something that would cause sstate-cache
to be invalid althogh I could image some scenarios.

 meta/conf/bitbake.conf |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Martin Jansa - Nov. 29, 2011, 9:40 p.m.
On Tue, Nov 29, 2011 at 03:33:35PM -0600, Matthew McClintock wrote:
> This dependency causes binutils to get rebuilt for some of
> our parts that are the same TARGET_ARCH but different
> MACHINE.
> 
> Signed-off-by: Matthew McClintock <msm@freescale.com>
> ---
> Comments on this? It seems like it might be better to some do this
> in the actual recipes (binutils, gcc-cross, etc) and not globally.
> However, I'm not really sure what goes in MACHINEOVERIDES in
> general and if it could be something that would cause sstate-cache
> to be invalid althogh I could image some scenarios.
> 
>  meta/conf/bitbake.conf |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index b4335c9..48ae458 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -659,6 +659,7 @@ AUTO_LIBNAME_PKGS = "${PACKAGES}"
>  OVERRIDES = "${TARGET_OS}:${TARGET_ARCH}:build-${BUILD_OS}:pn-${PN}:${MACHINEOVERRIDES}:${DISTROOVERRIDES}:forcevariable"
>  DISTROOVERRIDES ?= "${DISTRO}"
>  MACHINEOVERRIDES ?= "${MACHINE}"
> +MACHINEOVERRIDES[vardepsexclude] += "MACHINE"
>  
>  CPU_FEATURES ?= ""
>  CPU_FEATURES_arm ?= "vfp"
> -- 
> 1.7.6.1

is this of oe-core/master?

I see similar commit in 362512b83775ad7020e5870a594f0e7ca9ef83ba

Cheers,
McClintock Matthew-B29882 - Nov. 29, 2011, 9:49 p.m.
On Tue, Nov 29, 2011 at 3:40 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Tue, Nov 29, 2011 at 03:33:35PM -0600, Matthew McClintock wrote:
>> This dependency causes binutils to get rebuilt for some of
>> our parts that are the same TARGET_ARCH but different
>> MACHINE.
>>
>> Signed-off-by: Matthew McClintock <msm@freescale.com>
>> ---
>> Comments on this? It seems like it might be better to some do this
>> in the actual recipes (binutils, gcc-cross, etc) and not globally.
>> However, I'm not really sure what goes in MACHINEOVERIDES in
>> general and if it could be something that would cause sstate-cache
>> to be invalid althogh I could image some scenarios.
>>
>>  meta/conf/bitbake.conf |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
>> index b4335c9..48ae458 100644
>> --- a/meta/conf/bitbake.conf
>> +++ b/meta/conf/bitbake.conf
>> @@ -659,6 +659,7 @@ AUTO_LIBNAME_PKGS = "${PACKAGES}"
>>  OVERRIDES = "${TARGET_OS}:${TARGET_ARCH}:build-${BUILD_OS}:pn-${PN}:${MACHINEOVERRIDES}:${DISTROOVERRIDES}:forcevariable"
>>  DISTROOVERRIDES ?= "${DISTRO}"
>>  MACHINEOVERRIDES ?= "${MACHINE}"
>> +MACHINEOVERRIDES[vardepsexclude] += "MACHINE"
>>
>>  CPU_FEATURES ?= ""
>>  CPU_FEATURES_arm ?= "vfp"
>> --
>> 1.7.6.1
>
> is this of oe-core/master?
>
> I see similar commit in 362512b83775ad7020e5870a594f0e7ca9ef83ba

It appears this has already been fixed. I was working on edison 1.1. Thanks!

-M
McClintock Matthew-B29882 - Nov. 29, 2011, 9:52 p.m.
On Tue, Nov 29, 2011 at 3:48 PM, Matthew McClintock <msm@freescale.com> wrote:
>>> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
>>> index b4335c9..48ae458 100644
>>> --- a/meta/conf/bitbake.conf
>>> +++ b/meta/conf/bitbake.conf
>>> @@ -659,6 +659,7 @@ AUTO_LIBNAME_PKGS = "${PACKAGES}"
>>>  OVERRIDES = "${TARGET_OS}:${TARGET_ARCH}:build-${BUILD_OS}:pn-${PN}:${MACHINEOVERRIDES}:${DISTROOVERRIDES}:forcevariable"
>>>  DISTROOVERRIDES ?= "${DISTRO}"
>>>  MACHINEOVERRIDES ?= "${MACHINE}"
>>> +MACHINEOVERRIDES[vardepsexclude] += "MACHINE"
>>>
>>>  CPU_FEATURES ?= ""
>>>  CPU_FEATURES_arm ?= "vfp"
>>> --
>>> 1.7.6.1
>>
>> is this of oe-core/master?
>>
>> I see similar commit in 362512b83775ad7020e5870a594f0e7ca9ef83ba
>
> It appears this has already been fixed. I was working on edison 1.1. Thanks!

Richard,

Instead of possibly repeating this same exercise. Can you summarize
all the sstate-cache patches you have pushed into master last week?

(I could start cherry-picking and testing, but I hope it's not too
much to ask for a quick and dirty list...)

-M

Patch

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index b4335c9..48ae458 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -659,6 +659,7 @@  AUTO_LIBNAME_PKGS = "${PACKAGES}"
 OVERRIDES = "${TARGET_OS}:${TARGET_ARCH}:build-${BUILD_OS}:pn-${PN}:${MACHINEOVERRIDES}:${DISTROOVERRIDES}:forcevariable"
 DISTROOVERRIDES ?= "${DISTRO}"
 MACHINEOVERRIDES ?= "${MACHINE}"
+MACHINEOVERRIDES[vardepsexclude] += "MACHINE"
 
 CPU_FEATURES ?= ""
 CPU_FEATURES_arm ?= "vfp"