| Submitter | Petr Štetiar |
|---|---|
| Date | 2010-02-09 00:43:32 |
| Message ID | <1265676216-9722-3-git-send-email-ynezz@true.cz> |
| Download | mbox | patch |
| Permalink | /patch/1561/ |
| State | Superseded, archived |
| Headers | show |
Comments
Dnia wtorek, 9 lutego 2010 o 01:43:32 Petr Štetiar napisał(a): > Signed-off-by: Petr Štetiar <ynezz@true.cz> > --- > recipes/linux/linux_2.6.24.bb | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/recipes/linux/linux_2.6.24.bb b/recipes/linux/linux_2.6.24.bb > index 31a8a04..9aca4c7 100644 > --- a/recipes/linux/linux_2.6.24.bb > +++ b/recipes/linux/linux_2.6.24.bb > @@ -7,12 +7,12 @@ DEFAULT_PREFERENCE_mpc8313e-rdb = "1" > DEFAULT_PREFERENCE_simpad = "1" > DEFAULT_PREFERENCE_atngw100 = "1" > DEFAULT_PREFERENCE_at32stk1000 = "1" > -DEFAULT_PREFERENCE_ts72xx = "1" > +DEFAULT_PREFERENCE_ts72xx = "-1" Just drop DEF_PREF, do not set it to default value. > -PR = "r34" > +PR = "r35" Do not bump kernel PR if you do not use it anymore. This part should go to previous patch as it changes patches. Regards,
On Tue, 2010-02-09 at 01:43 +0100, Petr Štetiar wrote: > -DEFAULT_PREFERENCE_ts72xx = "1" > +DEFAULT_PREFERENCE_ts72xx = "-1" > DEFAULT_PREFERENCE_hipox = "1" > DEFAULT_PREFERENCE_cs-e9302 = "1" > DEFAULT_PREFERENCE_smartq5 = "1" > > -PR = "r34" > +PR = "r35" There's no need to increment PR if the only thing you are changing is DEFAULT_PREFERENCE. In general, you need to increment PR if (and only if) your change would cause the output from the recipe to be different from what it was before. Changes that just affect whether or not the recipe is built at all, and don't have any impact on the result of the build, do not require a new PR. Not that bumping PR unnecessarily is all that big a deal, of course, but it does cause a certain amount of avoidable churn and annoyance for other users of the recipe. It is best not to do it when you don't have to. p.
Marcin Juszkiewicz <marcin@juszkiewicz.com.pl> [2010-02-09 10:03:19]: > Dnia wtorek, 9 lutego 2010 o 01:43:32 Petr Štetiar napisał(a): > > recipes/linux/linux_2.6.24.bb | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > -DEFAULT_PREFERENCE_ts72xx = "1" > > +DEFAULT_PREFERENCE_ts72xx = "-1" > > Just drop DEF_PREF, do not set it to default value. > > > -PR = "r34" > > +PR = "r35" > > Do not bump kernel PR if you do not use it anymore. This part should go to > previous patch as it changes patches. Indeed, my mistake. I've sent updated patches already. -- ynezz
Marcin Juszkiewicz <marcin@juszkiewicz.com.pl> [2010-02-09 10:03:19]: > Dnia wtorek, 9 lutego 2010 o 01:43:32 Petr Štetiar napisał(a): > > -DEFAULT_PREFERENCE_ts72xx = "1" > > +DEFAULT_PREFERENCE_ts72xx = "-1" > > Just drop DEF_PREF, do not set it to default value. > > > -PR = "r34" > > +PR = "r35" > > Do not bump kernel PR if you do not use it anymore. This part should go to > previous patch as it changes patches. Hi, is second version ok for you? If so, would you mind to commit it pls? :-) Thanks. -- ynezz
Patch
diff --git a/recipes/linux/linux_2.6.24.bb b/recipes/linux/linux_2.6.24.bb index 31a8a04..9aca4c7 100644 --- a/recipes/linux/linux_2.6.24.bb +++ b/recipes/linux/linux_2.6.24.bb @@ -7,12 +7,12 @@ DEFAULT_PREFERENCE_mpc8313e-rdb = "1" DEFAULT_PREFERENCE_simpad = "1" DEFAULT_PREFERENCE_atngw100 = "1" DEFAULT_PREFERENCE_at32stk1000 = "1" -DEFAULT_PREFERENCE_ts72xx = "1" +DEFAULT_PREFERENCE_ts72xx = "-1" DEFAULT_PREFERENCE_hipox = "1" DEFAULT_PREFERENCE_cs-e9302 = "1" DEFAULT_PREFERENCE_smartq5 = "1" -PR = "r34" +PR = "r35" SRC_URI = "${KERNELORG_MIRROR}/pub/linux/kernel/v2.6/linux-2.6.24.tar.bz2 \ ${KERNELORG_MIRROR}/pub/linux/kernel/v2.6/patch-${PV}.7.bz2;patch=1 \
Signed-off-by: Petr Štetiar <ynezz@true.cz> --- recipes/linux/linux_2.6.24.bb | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)