Patchworkβ [oe,02/12] some more !getopt_long fixes

login
register
about
Submitter Bernhard Reutner-Fischer
Date 2010-02-08 21:14:23
Message ID <1265663673-16312-3-git-send-email-rep.dot.nop@gmail.com>
Download mbox | patch
Permalink /patch/1558/
State Changes Requested
Headers show

Comments

Bernhard Reutner-Fischer - 2010-02-08 21:14:23
Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
---
 recipes/busybox/files/hwclock.sh |   24 ++++++++++++------------
 1 files changed, 12 insertions(+), 12 deletions(-)
Jens Seidel - 2010-02-09 09:38:00
On Mon, Feb 08, 2010 at 10:14:23PM +0100, Bernhard Reutner-Fischer wrote:
> -                if [ "$VERBOSE" != no ]
> +                if [ "$VERBOSE" != "no" ]

I don't see any need for this change. Why doesn't the commit message does
not explain why it was done?

I assume it is a stylistic change only and should that's why committed
separately (with a different commit log), right?

Jens
Bernhard Reutner-Fischer - 2010-02-10 08:54:56
On Tue, Feb 09, 2010 at 10:38:00AM +0100, Jens Seidel wrote:
>On Mon, Feb 08, 2010 at 10:14:23PM +0100, Bernhard Reutner-Fischer wrote:
>> -                if [ "$VERBOSE" != no ]
>> +                if [ "$VERBOSE" != "no" ]
>
>I don't see any need for this change. Why doesn't the commit message does
>not explain why it was done?
>
>I assume it is a stylistic change only and should that's why committed
>separately (with a different commit log), right?

Yes, it is a stylistic change only and could be committed separately.
I'll factor them out and resend.

Patch

diff --git a/recipes/busybox/files/hwclock.sh b/recipes/busybox/files/hwclock.sh
index 6c0af34..57c9fc7 100644
--- a/recipes/busybox/files/hwclock.sh
+++ b/recipes/busybox/files/hwclock.sh
@@ -14,27 +14,27 @@ 
 
 . /etc/default/rcS
 
-[ "$UTC" = yes ] && UTC=--utc || UTC=--localtime
+[ "$UTC" = "yes" ] && UTC=-u || UTC=-l
 
 case "$1" in
         start)
-                if [ "$VERBOSE" != no ]
+                if [ "$VERBOSE" != "no" ]
                 then
                         echo "System time was `date`."
                         echo "Setting the System Clock using the Hardware Clock as reference..."
                 fi
 
-		if [ "$HWCLOCKACCESS" != no ]
+		if [ "$HWCLOCKACCESS" != "no" ]
 		then
 			if [ -z "$TZ" ]
 			then
-	                   hwclock -s $UTC;# --hctosys
+	                   hwclock -s $UTC
 			else
-			   TZ="$TZ" hwclock -s $UTC;# --hctosys
+			   TZ="$TZ" hwclock -s $UTC
 			fi
 		fi
 
-                if [ "$VERBOSE" != no ]
+                if [ "$VERBOSE" != "no" ]
                 then
                         echo "System Clock set. System local time is now `date`."
                 fi
@@ -47,24 +47,24 @@  case "$1" in
 		# WARNING: If you disable this, any changes to the system
 		#          clock will not be carried across reboots.
 		#
-		if [ "$VERBOSE" != no ]
+		if [ "$VERBOSE" != "no" ]
 		then
 			echo "Saving the System Clock time to the Hardware Clock..."
 		fi
-		if [ "$HWCLOCKACCESS" != no ]
+		if [ "$HWCLOCKACCESS" != "no" ]
 		then
-			hwclock -w $UTC;# --systohc
+			hwclock -w $UTC
 		fi
-		if [ "$VERBOSE" != no ]
+		if [ "$VERBOSE" != "no" ]
 		then
 			echo "Hardware Clock updated to `date`."
 		fi
                 exit 0
                 ;;
 	show)
-		if [ "$HWCLOCKACCESS" != no ]
+		if [ "$HWCLOCKACCESS" != "no" ]
 		then
-			hwclock -r $UTC;# --show
+			hwclock -r $UTC
 		fi
 		;;
         *)