Patchwork [4/5] autoconf: Extend to provide nativesdk recipe

login
register
mail settings
Submitter wenzong.fan@windriver.com
Date Nov. 29, 2011, 8:39 a.m.
Message ID <647b040f65373d5f2922a381f3515c62471773c8.1322554339.git.wenzong.fan@windriver.com>
Download mbox | patch
Permalink /patch/15579/
State Accepted
Commit a16cf1b67f6559b182e6bb31abc1371162b04428
Headers show

Comments

wenzong.fan@windriver.com - Nov. 29, 2011, 8:39 a.m.
From: Wenzong Fan <wenzong.fan@windriver.com>

[YOCTO #1603]

autoconf-nativesdk should be added into meta-toolchain.

Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com>
---
 meta/recipes-devtools/autoconf/autoconf_2.68.bb |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)
Koen Kooi - Nov. 29, 2011, 8:49 a.m.
Op 29 nov. 2011, om 09:39 heeft <wenzong.fan@windriver.com> <wenzong.fan@windriver.com> het volgende geschreven:

> From: Wenzong Fan <wenzong.fan@windriver.com>
> 
> [YOCTO #1603]

For every recipe: what is '[yocto #1603]'?
wenzong.fan@windriver.com - Nov. 29, 2011, 9 a.m.
On 11/29/2011 04:49 PM, Koen Kooi wrote:
> Op 29 nov. 2011, om 09:39 heeft<wenzong.fan@windriver.com>  <wenzong.fan@windriver.com>  het volgende geschreven:
>
>    
>> From: Wenzong Fan<wenzong.fan@windriver.com>
>>
>> [YOCTO #1603]
>>      
> For every recipe: what is '[yocto #1603]'?

http://bugzilla.pokylinux.org/show_bug.cgi?id=1603

The updates to each recipe was related to this requirement for yocto 
1.2, so I add the id number in all commit messages.

Thanks
Wenzong
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
Richard Purdie - Nov. 29, 2011, 9:12 a.m.
On Tue, 2011-11-29 at 17:00 +0800, wenzong fan wrote:
> On 11/29/2011 04:49 PM, Koen Kooi wrote:
> > Op 29 nov. 2011, om 09:39 heeft<wenzong.fan@windriver.com>  <wenzong.fan@windriver.com>  het volgende geschreven:
> >
> >    
> >> From: Wenzong Fan<wenzong.fan@windriver.com>
> >>
> >> [YOCTO #1603]
> >>      
> > For every recipe: what is '[yocto #1603]'?
> 
> http://bugzilla.pokylinux.org/show_bug.cgi?id=1603
> 
> The updates to each recipe was related to this requirement for yocto 
> 1.2, so I add the id number in all commit messages.

What Koen is asking for in a rather cryptic fashion is for more
explanation of the change being made in the commit message. The bug ID
is fine as a reference but we shouldn't rely on that to explain what the
change is and why its needed.

Cheers,

Richard
Koen Kooi - Nov. 29, 2011, 9:14 a.m.
Op 29 nov. 2011, om 10:00 heeft wenzong fan het volgende geschreven:

> On 11/29/2011 04:49 PM, Koen Kooi wrote:
>> Op 29 nov. 2011, om 09:39 heeft<wenzong.fan@windriver.com>  <wenzong.fan@windriver.com>  het volgende geschreven:
>> 
>>   
>>> From: Wenzong Fan<wenzong.fan@windriver.com>
>>> 
>>> [YOCTO #1603]
>>>     
>> For every recipe: what is '[yocto #1603]'?
> 
> http://bugzilla.pokylinux.org/show_bug.cgi?id=1603
> 
> The updates to each recipe was related to this requirement for yocto 1.2, so I add the id number in all commit messages.

If you add such IDs you need to add a lot more info like a summary of the bugreport. People reading commit logs aren't going to know and URI to yocto bz (especially in OE-core git) and even if they'd know, opening a webbrowser to understand a commit message is not good.
wenzong.fan@windriver.com - Nov. 29, 2011, 9:22 a.m.
On 11/29/2011 05:14 PM, Koen Kooi wrote:
> Op 29 nov. 2011, om 10:00 heeft wenzong fan het volgende geschreven:
>
>    
>> On 11/29/2011 04:49 PM, Koen Kooi wrote:
>>      
>>> Op 29 nov. 2011, om 09:39 heeft<wenzong.fan@windriver.com>   <wenzong.fan@windriver.com>   het volgende geschreven:
>>>
>>>
>>>        
>>>> From: Wenzong Fan<wenzong.fan@windriver.com>
>>>>
>>>> [YOCTO #1603]
>>>>
>>>>          
>>> For every recipe: what is '[yocto #1603]'?
>>>        
>> http://bugzilla.pokylinux.org/show_bug.cgi?id=1603
>>
>> The updates to each recipe was related to this requirement for yocto 1.2, so I add the id number in all commit messages.
>>      
> If you add such IDs you need to add a lot more info like a summary of the bugreport. People reading commit logs aren't going to know and URI to yocto bz (especially in OE-core git) and even if they'd know, opening a webbrowser to understand a commit message is not good.
>
>    

You are right, I'll update the commit messages and add more info to it, 
thanks for your advises.

Wenzong
>
>    
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>

Patch

diff --git a/meta/recipes-devtools/autoconf/autoconf_2.68.bb b/meta/recipes-devtools/autoconf/autoconf_2.68.bb
index 21b5fb3..9028e83 100644
--- a/meta/recipes-devtools/autoconf/autoconf_2.68.bb
+++ b/meta/recipes-devtools/autoconf/autoconf_2.68.bb
@@ -1,6 +1,6 @@ 
 require autoconf.inc
 
-PR = "r3"
+PR = "r4"
 
 PARALLEL_MAKE = ""
 
@@ -14,7 +14,7 @@  SRC_URI += "file://autoreconf-include.patch \
 	    file://autoreconf-foreign.patch \
 	    file://autoreconf-gnuconfigize.patch \
 	    file://autoheader-nonfatal-warnings.patch \
-	    ${@['file://path_prog_fixes.patch', ''][bb.data.inherits_class('native', d)]} \
+	    ${@['file://path_prog_fixes.patch', ''][bb.data.inherits_class('native', d) or bb.data.inherits_class('nativesdk', d)]} \
             file://config_site.patch \
             file://remove-usr-local-lib-from-m4.patch \
            "
@@ -25,8 +25,11 @@  SRC_URI[sha256sum] = "c491fb273fd6d4ca925e26ceed3d177920233c76d542b150ff35e57145
 DEPENDS_virtclass-native = "m4-native gnu-config-native"
 RDEPENDS_${PN}_virtclass-native = "m4-native gnu-config-native"
 
+DEPENDS_virtclass-nativesdk = "m4-nativesdk gnu-config-nativesdk"
+RDEPENDS_${PN}_virtclass-nativesdk = "m4-nativesdk gnu-config-nativesdk"
+
 SRC_URI_append_virtclass-native = " file://fix_path_xtra.patch"
 
 EXTRA_OECONF += "ac_cv_path_M4=m4"
 
-BBCLASSEXTEND = "native"
+BBCLASSEXTEND = "native nativesdk"