Patchwork [2/5] m4: Add m4-nativesdk recipes

login
register
mail settings
Submitter wenzong.fan@windriver.com
Date Nov. 29, 2011, 8:38 a.m.
Message ID <ba86babf9425bb34f62c879e2c44febf7308a543.1322554339.git.wenzong.fan@windriver.com>
Download mbox | patch
Permalink /patch/15573/
State New
Headers show

Comments

wenzong.fan@windriver.com - Nov. 29, 2011, 8:38 a.m.
From: Wenzong Fan <wenzong.fan@windriver.com>

[YOCTO #1603]

m4-nativesdk is required by autoconf-nativesdk.

Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com>
---
 meta/recipes-devtools/m4/m4-nativesdk_1.4.16.bb |   12 ++++++++++++
 meta/recipes-devtools/m4/m4-nativesdk_1.4.9.bb  |   12 ++++++++++++
 2 files changed, 24 insertions(+), 0 deletions(-)
 create mode 100644 meta/recipes-devtools/m4/m4-nativesdk_1.4.16.bb
 create mode 100644 meta/recipes-devtools/m4/m4-nativesdk_1.4.9.bb
McClintock Matthew-B29882 - Nov. 29, 2011, 5:48 p.m.
On Tue, Nov 29, 2011 at 2:38 AM,  <wenzong.fan@windriver.com> wrote:
> From: Wenzong Fan <wenzong.fan@windriver.com>
>
> [YOCTO #1603]
>
> m4-nativesdk is required by autoconf-nativesdk.

Is there a reason we don't just extend the m4 recipe for native and
nativesdk? (I'm just curious)

-M
Richard Purdie - Nov. 29, 2011, 6:04 p.m.
On Tue, 2011-11-29 at 17:48 +0000, McClintock Matthew-B29882 wrote:
> On Tue, Nov 29, 2011 at 2:38 AM,  <wenzong.fan@windriver.com> wrote:
> > From: Wenzong Fan <wenzong.fan@windriver.com>
> >
> > [YOCTO #1603]
> >
> > m4-nativesdk is required by autoconf-nativesdk.
> 
> Is there a reason we don't just extend the m4 recipe for native and
> nativesdk? (I'm just curious)

Its a good question, BBCLASSEXTEND = "nativesdk" should really work and
those recipes look wrong (they shouldn't need to set
INHIBIT_AUTOTOOLS_DEPS = "1" or have the custom do_configure).

The m4-native recipe is a little tricker as its one of the early
bootstrap dependencies required by autotools. This is why it does need
the INHIBIT_AUTOTOOLS_DEPS and custom do_configure line although those
should be possible with modern BBCLASSEXTEND...

Cheers,

Richard
wenzong.fan@windriver.com - Nov. 30, 2011, 1:55 a.m.
On 11/30/2011 02:04 AM, Richard Purdie wrote:
> On Tue, 2011-11-29 at 17:48 +0000, McClintock Matthew-B29882 wrote:
>    
>> On Tue, Nov 29, 2011 at 2:38 AM,<wenzong.fan@windriver.com>  wrote:
>>      
>>> From: Wenzong Fan<wenzong.fan@windriver.com>
>>>
>>> [YOCTO #1603]
>>>
>>> m4-nativesdk is required by autoconf-nativesdk.
>>>        
>> Is there a reason we don't just extend the m4 recipe for native and
>> nativesdk? (I'm just curious)
>>      
> Its a good question, BBCLASSEXTEND = "nativesdk" should really work and
> those recipes look wrong (they shouldn't need to set
> INHIBIT_AUTOTOOLS_DEPS = "1" or have the custom do_configure).
>    

Ah, this works. I'll extend the m4 recipe to support 'nativesdk'
> The m4-native recipe is a little tricker as its one of the early
> bootstrap dependencies required by autotools. This is why it does need
> the INHIBIT_AUTOTOOLS_DEPS and custom do_configure line although those
> should be possible with modern BBCLASSEXTEND...
>
>    

Thanks for let me know the story, this really confused me when I 
deciding copy/extend for the m4-nativesdk.

Wenzong
> Cheers,
>
> Richard
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>

Patch

diff --git a/meta/recipes-devtools/m4/m4-nativesdk_1.4.16.bb b/meta/recipes-devtools/m4/m4-nativesdk_1.4.16.bb
new file mode 100644
index 0000000..f1be0c8
--- /dev/null
+++ b/meta/recipes-devtools/m4/m4-nativesdk_1.4.16.bb
@@ -0,0 +1,12 @@ 
+require m4_${PV}.bb
+inherit nativesdk
+
+INHIBIT_AUTOTOOLS_DEPS = "1"
+DEPENDS += "gnu-config-nativesdk"
+
+do_configure()  {
+	install -m 0644 ${STAGING_DATADIR}/gnu-config/config.sub .
+	install -m 0644 ${STAGING_DATADIR}/gnu-config/config.guess .
+	oe_runconf
+}
+
diff --git a/meta/recipes-devtools/m4/m4-nativesdk_1.4.9.bb b/meta/recipes-devtools/m4/m4-nativesdk_1.4.9.bb
new file mode 100644
index 0000000..f1be0c8
--- /dev/null
+++ b/meta/recipes-devtools/m4/m4-nativesdk_1.4.9.bb
@@ -0,0 +1,12 @@ 
+require m4_${PV}.bb
+inherit nativesdk
+
+INHIBIT_AUTOTOOLS_DEPS = "1"
+DEPENDS += "gnu-config-nativesdk"
+
+do_configure()  {
+	install -m 0644 ${STAGING_DATADIR}/gnu-config/config.sub .
+	install -m 0644 ${STAGING_DATADIR}/gnu-config/config.guess .
+	oe_runconf
+}
+