Patchworkβ [oe,04/12] matchbox-panel-2: fix DEPENDS

login
register
about
Submitter Bernhard Reutner-Fischer
Date 2010-02-08 21:14:25
Message ID <1265663673-16312-5-git-send-email-rep.dot.nop@gmail.com>
Download mbox | patch
Permalink /patch/1556/
State Changes Requested
Headers show

Comments

Bernhard Reutner-Fischer - 2010-02-08 21:14:25
libacpi has no recipe as opposed to acpid

Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
---
 recipes/matchbox2/matchbox-panel-2_svn.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Phil Blundell - 2010-02-09 11:58:15
On Mon, 2010-02-08 at 22:14 +0100, Bernhard Reutner-Fischer wrote:
> libacpi has no recipe as opposed to acpid
> 
> Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
> ---
>  recipes/matchbox2/matchbox-panel-2_svn.bb |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Um, really?  I do seem to have a recipe for libacpi in my tree.

-rw-r--r-- 1 pb pb 463 Nov 23 14:53 recipes/libacpi/libacpi_0.2.bb

Also, from a quick look at the acpid package, it doesn't seem to stage
any libraries or headers so it is not clear to me that it would actually
satisfy matchbox-panel-2's requirements.  Did you verify that
matchbox-panel-2's ACPI code really is buildable with your patch
applied?

p.
Bernhard Reutner-Fischer - 2010-02-10 16:51:40
On Tue, Feb 09, 2010 at 11:58:15AM +0000, Phil Blundell wrote:
>On Mon, 2010-02-08 at 22:14 +0100, Bernhard Reutner-Fischer wrote:
>> libacpi has no recipe as opposed to acpid
>> 
>> Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
>> ---
>>  recipes/matchbox2/matchbox-panel-2_svn.bb |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>
>Um, really?  I do seem to have a recipe for libacpi in my tree.

Oh, there was none in september. I withdraw this patch (and sorry for
not re-checking. Will do from now on..)

Thanks,

Patch

diff --git a/recipes/matchbox2/matchbox-panel-2_svn.bb b/recipes/matchbox2/matchbox-panel-2_svn.bb
index ae3b122..1a61370 100644
--- a/recipes/matchbox2/matchbox-panel-2_svn.bb
+++ b/recipes/matchbox2/matchbox-panel-2_svn.bb
@@ -2,7 +2,7 @@  DESCRIPTION = "matchbox-panel-2 is a lightweight dock (system tray) application
 LICENSE = "GPLv2"
 SECTION = "x11/panels"
 DEPENDS = "gtk+ startup-notification dbus dbus-glib matchbox-panel-2-icon-themes"
-DEPENDS += " ${@base_contains("MACHINE_FEATURES", "acpi", "libacpi", "",d)}"
+DEPENDS += " ${@base_contains("MACHINE_FEATURES", "acpi", "acpid", "",d)}"
 DEPENDS += " ${@base_contains("MACHINE_FEATURES", "apm", "apmd", "",d)}"
 RDEPENDS_${PN} = "matchbox-panel-2-icon-theme"
 PACKAGE_ARCH = "${MACHINE_ARCH}"