Patchwork [3/4] gmp: also generate the libgmpcxx library & package it properly

login
register
mail settings
Submitter Nitin A Kamble
Date Nov. 29, 2011, 12:36 a.m.
Message ID <4f8425c0c7856dba2b3765407a97754c7b06aeb5.1322526931.git.nitin.a.kamble@intel.com>
Download mbox | patch
Permalink /patch/15493/
State New
Headers show

Comments

Nitin A Kamble - Nov. 29, 2011, 12:36 a.m.
From: Nitin A Kamble <nitin.a.kamble@intel.com>

configure runs few checks to make sure c++ compiler and runtime are working
as expected with the --enable-cxx=detect option. And it enables building
of libgmpxx library.

Same as earlier the libgmp.so.10.x file is packaged in the libgmp10 package,
and a new package named libgmpxx4 is added for libgmpxx.so.4.x file.

Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
---
 meta/recipes-support/gmp/gmp.inc      |    6 ++++++
 meta/recipes-support/gmp/gmp_5.0.2.bb |    2 +-
 2 files changed, 7 insertions(+), 1 deletions(-)
Otavio Salvador - Nov. 29, 2011, 1:06 a.m.
On Mon, Nov 28, 2011 at 22:36, <nitin.a.kamble@intel.com> wrote:

> ...

+PACKAGES =+ "libgmp10 libgmpxx4"
> +FILES_libgmp10 = "${libdir}/libgmp.so.10*"
> +FILES_libgmpxx4 = "${libdir}/libgmpxx.so.4*"
>

Why didn't you let the system to name the package using the soname by
itself and avoid putting the soname on the glob matching?
Nitin A Kamble - Nov. 29, 2011, 1:52 a.m.
From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of Otavio Salvador
Sent: Monday, November 28, 2011 5:07 PM
To: Patches and discussions about the oe-core layer
Subject: Re: [OE-core] [PATCH 3/4] gmp: also generate the libgmpcxx library & package it properly

On Mon, Nov 28, 2011 at 22:36, <nitin.a.kamble@intel.com<mailto:nitin.a.kamble@intel.com>> wrote:
...
+PACKAGES =+ "libgmp10 libgmpxx4"
+FILES_libgmp10 = "${libdir}/libgmp.so.10*"
+FILES_libgmpxx4 = "${libdir}/libgmpxx.so.4*"

Why didn't you let the system to name the package using the soname by itself and avoid putting the soname on the glob matching?

Before the generation of libgmpxx library, there was only one library, libgmp, and it was getting packaged into libgmp10 package. After addition of the libgmpxx library the package name changed to the recipe name (gmp), in order to preserve the previous package name(for distro upgrades), and to let people avoid installation of libgmpxx if they don't need it in order to save the space on target, two packages are generated for each library with this scheme.

Nitin

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br<mailto:otavio@ossystems.com.br>  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
Phil Blundell - Nov. 29, 2011, 8 a.m.
On Mon, 2011-11-28 at 17:52 -0800, Kamble, Nitin A wrote:

> Before the generation of libgmpxx library, there was only one library,
> libgmp, and it was getting packaged into libgmp10 package. After
> addition of the libgmpxx library the package name changed to the
> recipe name (gmp), in order to preserve the previous package name(for
> distro upgrades), and to let people avoid installation of libgmpxx if
> they don’t need it in order to save the space on target, two packages
> are generated for each library with this scheme.

Right, but that's not really the point.  I think what Otavio was trying
to ask was, why didn't you just do:

PACKAGES =+ "libgmpxx"
FILES_libgmpxx = "${libdir}/libgmpxx${SOLIBS}"

?  I think the way you have done it will cause the libgmp package name
to change for people not using debian.bbclass, which is probably a bad
thing.

p.
Nitin A Kamble - Nov. 29, 2011, 4:42 p.m.
> -----Original Message-----

> From: openembedded-core-bounces@lists.openembedded.org

> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of

> Phil Blundell

> Sent: Tuesday, November 29, 2011 12:00 AM

> To: Patches and discussions about the oe-core layer

> Subject: Re: [OE-core] [PATCH 3/4] gmp: also generate the libgmpcxx

> library & package it properly

> 

> On Mon, 2011-11-28 at 17:52 -0800, Kamble, Nitin A wrote:

> 

> > Before the generation of libgmpxx library, there was only one

> library,

> > libgmp, and it was getting packaged into libgmp10 package. After

> > addition of the libgmpxx library the package name changed to the

> > recipe name (gmp), in order to preserve the previous package name(for

> > distro upgrades), and to let people avoid installation of libgmpxx if

> > they don’t need it in order to save the space on target, two packages

> > are generated for each library with this scheme.

> 

> Right, but that's not really the point.  I think what Otavio was trying

> to ask was, why didn't you just do:

> 

> PACKAGES =+ "libgmpxx"

> FILES_libgmpxx = "${libdir}/libgmpxx${SOLIBS}"

> 

> ?  I think the way you have done it will cause the libgmp package name

> to change for people not using debian.bbclass, which is probably a bad

> thing.

> 

> p.


Thanks Phil,
  This was also works the same. And producing same rpm packages as previous one. So I am happy to accept this change if it helps the deb packages. Will resend the commit.
Nitin

> 

> 

> 

> 

> _______________________________________________

> Openembedded-core mailing list

> Openembedded-core@lists.openembedded.org

> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-support/gmp/gmp.inc b/meta/recipes-support/gmp/gmp.inc
index 66349e6..14e6cfc 100644
--- a/meta/recipes-support/gmp/gmp.inc
+++ b/meta/recipes-support/gmp/gmp.inc
@@ -14,3 +14,9 @@  ARM_INSTRUCTION_SET = "arm"
 acpaths = ""
 
 BBCLASSEXTEND = "native nativesdk"
+
+EXTRA_OECONF += " --enable-cxx=detect"
+
+PACKAGES =+ "libgmp10 libgmpxx4"
+FILES_libgmp10 = "${libdir}/libgmp.so.10*"
+FILES_libgmpxx4 = "${libdir}/libgmpxx.so.4*"
diff --git a/meta/recipes-support/gmp/gmp_5.0.2.bb b/meta/recipes-support/gmp/gmp_5.0.2.bb
index 16bdcbc..873fc3e 100644
--- a/meta/recipes-support/gmp/gmp_5.0.2.bb
+++ b/meta/recipes-support/gmp/gmp_5.0.2.bb
@@ -2,7 +2,7 @@  require gmp.inc
 LICENSE="LGPLv3&GPLv3"
 LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504 \
 		    file://version.c;endline=18;md5=d8c56b52b9092346b9f93b4da65ef790"
-PR = "r1"
+PR = "r2"
 
 SRC_URI_append += "file://sh4-asmfix.patch \
                    file://use-includedir.patch "